Breaking Nodes with Tool's Last Use #3931

New Issue

Dehydrate6684 · 2023-09-11T17:05:38+02:00

Dehydrate6684 commented

2023-09-11 17:05:38 +02:00

MineClone2 version:0.84.0

What happened?

When breaking nodes with a tool's last use, it is broken as if it is broken using bare hands.

Examples

Breaking stone with the 60th use of a wooden pickaxe drops nothing.
Breaking grass block with the 60th use of wooden shovel with silk touch drops dirt.
Breaking bookshelf with the 60th use of wooden axe with silk touch drops 3 books.

What should happen:

Breaking stone with the 60th use of a wooden pickaxe drops cobblestone.
Breaking grass block with the 60th use of wooden shovel with silk touch drops grass block.
Breaking bookshelf with the 60th use of wooden axe with silk touch drops bookshelf.

Steps to reproduce

Breaking nodes when a tool only have 1 use left.

MineClone2 version:0.84.0 ### What happened? When breaking nodes with a tool's last use, it is broken as if it is broken using bare hands. Examples 1. Breaking stone with the 60th use of a wooden pickaxe drops nothing. 2. Breaking grass block with the 60th use of wooden shovel with silk touch drops dirt. 3. Breaking bookshelf with the 60th use of wooden axe with silk touch drops 3 books. ### What should happen: 1. Breaking stone with the 60th use of a wooden pickaxe drops cobblestone. 2. Breaking grass block with the 60th use of wooden shovel with silk touch drops grass block. 3. Breaking bookshelf with the 60th use of wooden axe with silk touch drops bookshelf. ### Steps to reproduce Breaking nodes when a tool only have 1 use left.

Dehydrate6684 added the

bug

unconfirmed

labels 2023-09-11 17:05:38 +02:00

erle commented

2023-09-11 17:14:39 +02:00

Which Minetest version did you use?

ancientmarinerdev commented

2023-09-11 20:58:13 +02:00

From what I have been told, this is an engine bug. On the last usage, when it breaks, it doesn't have a reference to the tool so doesn't know if it's the correct tool that was used.

Dehydrate6684 commented

2023-09-13 16:47:01 +02:00

The minetest version I am using is 5.7.0.

Dehydrate6684 commented

2023-09-26 16:34:34 +02:00

From what I have been told, this is an engine bug. On the last usage, when it breaks, it doesn't have a reference to the tool so doesn't know if it's the correct tool that was used.

I read the engine source code and I can confirm that this is happening as the minetest.on_dig function wears the tools before calling the minetest.handle_node_drops callback.

However, I think there is a potential solution to this. We can try and replace the minetest.get_node_drops function to do the checks of using the right tools and plus silk touch. This will cascade the drops variable when calling the minetest.handle_node_drops function.

> From what I have been told, this is an engine bug. On the last usage, when it breaks, it doesn't have a reference to the tool so doesn't know if it's the correct tool that was used. I read the engine source code and I can confirm that this is happening as the `minetest.on_dig` function wears the tools before calling the `minetest.handle_node_drops` callback. However, I think there is a potential solution to this. We can try and replace the `minetest.get_node_drops` function to do the checks of using the right tools and plus silk touch. This will cascade the `drops` variable when calling the `minetest.handle_node_drops` function.

the-real-herowl added

and removed

labels 2023-10-08 15:15:30 +02:00

the-real-herowl referenced a pull request that will close this issue

2023-11-13 13:38:11 +01:00

Fix item not dropping at tool last use #4009

the-real-herowl closed this issue