[Bug] Blocks can be placed on "on" buttons. #3831

New Issue

ThePython10110 · 2023-07-03T21:52:13+02:00

ThePython10110 commented

2023-07-03 21:52:13 +02:00

MineClone2 version: 0.83.1

What happened?

Blocks can be placed on buttons in their "on" state.

What should happen:

You should only be able to place a block on a button (regardless of its state) when holding sneak (I don't have MineCraft, but I assume this is how it works).

Steps to reproduce

Place a button
Press the button
Before the button "turns off," place a block on it.

MineClone2 version: 0.83.1 ### What happened? Blocks can be placed on buttons in their "on" state. ### What should happen: You should only be able to place a block on a button (regardless of its state) when holding sneak (I don't have MineCraft, but I assume this is how it works). ### Steps to reproduce 1. Place a button 2. Press the button 3. Before the button "turns off," place a block on it.

ThePython10110 added the

bug

unconfirmed

labels 2023-07-03 21:52:13 +02:00

seventeenthShulker commented

2023-07-04 17:23:53 +02:00

Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak).

A no-op on_rightclick for the 'on' state button seems to do the trick perfectly (considers sneak too).

on_rightclick = function() end,

But I'm sure there's a cleaner / more official way of doing this.

Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak). A no-op `on_rightclick` for the 'on' state button seems to do the trick perfectly (considers sneak too). ```lua on_rightclick = function() end, ``` But I'm sure there's a cleaner / more official way of doing this.

Michieal commented

2023-07-04 18:33:28 +02:00

Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak).

In minecraft, the only way to place a block on a button (see image at bottom) is to sneak and place it.

A no-op on_rightclick for the 'on' state button seems to do the trick perfectly (considers sneak too).
on_rightclick = function() end,
But I'm sure there's a cleaner / more official way of doing this.

Yeah -- that is not exactly a great way to handle it. The base problem is that when they were created (and this probably applies to pressure plates too, if I recall the code correctly) no one expected someone to place a block on them.

The redstone mod in MCL2 is old, and rather decrepit, so... The quickly toggled nodes that are used by it are very basic. I couldn't add in the redstone aspects to the item frames, because it has no concept of signal strength. I've been trying to digest all of the YT vids on redstone, and practice them in a creative MC world to be able to add / implement some more redstone features to MCL2. And while I would rather implement the "Create" Mod, directly in, we really do need to have a functional redstone. I mean, @ThatMumboJumbo recently reviewed Minetest, and not Mineclone, because the redstone is so broken in MCL2. (Yes, Mumbo Jumbo, the mega minecrafter that does redstone videos on youtube, with 8 million followers...)

> Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak). In minecraft, the only way to place a block on a button (see image at bottom) is to sneak and place it. > A no-op `on_rightclick` for the 'on' state button seems to do the trick perfectly (considers sneak too). > > ```lua > on_rightclick = function() end, > ``` > > But I'm sure there's a cleaner / more official way of doing this. Yeah -- that is not exactly a great way to handle it. The base problem is that when they were created (and this probably applies to pressure plates too, if I recall the code correctly) no one expected someone to place a block on them. The redstone mod in MCL2 is old, and rather decrepit, so... The quickly toggled nodes that are used by it are very basic. I couldn't add in the redstone aspects to the item frames, because it has no concept of signal strength. I've been trying to digest all of the YT vids on redstone, and practice them in a creative MC world to be able to add / implement some more redstone features to MCL2. And while I would rather implement the "Create" Mod, directly in, we really do need to have a functional redstone. I mean, @ThatMumboJumbo recently reviewed Minetest, and not Mineclone, because the redstone is so broken in MCL2. (Yes, Mumbo Jumbo, the mega minecrafter that does redstone videos on youtube, with 8 million followers...) ![A Block on a button.](/attachments/01f7b865-579e-4a2f-b682-d3508775c20f)

image.png

862 KiB

ancientmarinerdev added

nodes

gameplay

and removed

unconfirmed

labels 2023-07-23 02:53:55 +02:00

teknomunk referenced this issue

2024-04-13 20:52:22 +02:00

WIP: Redstone Update #4234

teknomunk referenced this issue