[Bug] Blocks can be placed on "on" buttons. #3831

Open
opened 2023-07-03 21:52:13 +02:00 by ThePython10110 · 3 comments
Contributor

MineClone2 version: 0.83.1

What happened?

Blocks can be placed on buttons in their "on" state.

What should happen:

You should only be able to place a block on a button (regardless of its state) when holding sneak (I don't have MineCraft, but I assume this is how it works).

Steps to reproduce

  1. Place a button
  2. Press the button
  3. Before the button "turns off," place a block on it.
<!-- Thanks for taking the time to fill out this bug report! Please follow our contributing guidelines first: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CONTRIBUTING.md#rules-about-both-bugs-and-feature-requests By submitting this issue, you agree to follow our Code of Conduct: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/CODE_OF_CONDUCT.md --> <!-- What version of MineClone2 are you using? We do not provide support for outdated versions of MineClone2. Current latest version is listed here, at the top: https://git.minetest.land/MineClone2/MineClone2/tags --> MineClone2 version: 0.83.1 ### What happened? Blocks can be placed on buttons in their "on" state. ### What should happen: You should only be able to place a block on a button (regardless of its state) when holding sneak (I don't have MineCraft, but I assume this is how it works). ### Steps to reproduce 1. Place a button 2. Press the button 3. Before the button "turns off," place a block on it.
ThePython10110 added the
bug
unconfirmed
labels 2023-07-03 21:52:13 +02:00

Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak).

A no-op on_rightclick for the 'on' state button seems to do the trick perfectly (considers sneak too).

on_rightclick = function() end,

But I'm sure there's a cleaner / more official way of doing this.

Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak). A no-op `on_rightclick` for the 'on' state button seems to do the trick perfectly (considers sneak too). ```lua on_rightclick = function() end, ``` But I'm sure there's a cleaner / more official way of doing this.
Member

Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak).

In minecraft, the only way to place a block on a button (see image at bottom) is to sneak and place it.

A no-op on_rightclick for the 'on' state button seems to do the trick perfectly (considers sneak too).

on_rightclick = function() end,

But I'm sure there's a cleaner / more official way of doing this.

Yeah -- that is not exactly a great way to handle it. The base problem is that when they were created (and this probably applies to pressure plates too, if I recall the code correctly) no one expected someone to place a block on them.

The redstone mod in MCL2 is old, and rather decrepit, so... The quickly toggled nodes that are used by it are very basic. I couldn't add in the redstone aspects to the item frames, because it has no concept of signal strength. I've been trying to digest all of the YT vids on redstone, and practice them in a creative MC world to be able to add / implement some more redstone features to MCL2. And while I would rather implement the "Create" Mod, directly in, we really do need to have a functional redstone. I mean, @ThatMumboJumbo recently reviewed Minetest, and not Mineclone, because the redstone is so broken in MCL2. (Yes, Mumbo Jumbo, the mega minecrafter that does redstone videos on youtube, with 8 million followers...)

A Block on a button.

> Yep, can confirm this is permitted, and also pretty sure that you can't in Minecraft (without sneak). In minecraft, the only way to place a block on a button (see image at bottom) is to sneak and place it. > A no-op `on_rightclick` for the 'on' state button seems to do the trick perfectly (considers sneak too). > > ```lua > on_rightclick = function() end, > ``` > > But I'm sure there's a cleaner / more official way of doing this. Yeah -- that is not exactly a great way to handle it. The base problem is that when they were created (and this probably applies to pressure plates too, if I recall the code correctly) no one expected someone to place a block on them. The redstone mod in MCL2 is old, and rather decrepit, so... The quickly toggled nodes that are used by it are very basic. I couldn't add in the redstone aspects to the item frames, because it has no concept of signal strength. I've been trying to digest all of the YT vids on redstone, and practice them in a creative MC world to be able to add / implement some more redstone features to MCL2. And while I would rather implement the "Create" Mod, directly in, we really do need to have a functional redstone. I mean, @ThatMumboJumbo recently reviewed Minetest, and not Mineclone, because the redstone is so broken in MCL2. (Yes, Mumbo Jumbo, the mega minecrafter that does redstone videos on youtube, with 8 million followers...) ![A Block on a button.](/attachments/01f7b865-579e-4a2f-b682-d3508775c20f)
862 KiB
ancientmarinerdev added
nodes
gameplay
and removed
unconfirmed
labels 2023-07-23 02:53:55 +02:00
teknomunk added this to the Redstone Update project 2024-11-29 12:37:15 +01:00
Member

I am unable to reproduce this in master@a399182375.

I am unable to reproduce this in `master`@https://git.minetest.land/VoxeLibre/VoxeLibre/commit/a3991823757d8871ea399841351fe231e4d89cfc.
teknomunk added the
possible close
label 2024-12-02 13:31:29 +01:00
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#3831
No description provided.