A few issues with sheep #3734

New Issue

kneekoo · 2023-05-16T20:34:56+02:00

kneekoo commented

2023-05-16 20:34:56 +02:00

MineClone2 version: latest master (6ded4d2322)

What happened?

~~1. Sheep eat way too fast;~~
2. Sheep don't make a sound when they graze;
~~3. Sheep don't tilt their heads to graze;~~
4. After breeding, some seem to stay in love mode, showing heart particles;
5. Applying dye to their wool also activates their stand/walk ability (do we really need sheep to have this?)
6. Baby sheep are not properly coloured on breeding. (bug 4 also shown: hearts particles) The problem here is a bit weirder because the colours are not predictable when you make correct combinations, and killing the resulted (grown) sheep can also give you a different colour wool.

As an example, I bred a blue + green sheep a few times, and the results were:

attempt 1: green
attempt 2: blue
attempt 3: cyan (and after I fed it to become adult, and killed it, it gave white wool)

7. Mobs don't move toward each other when they breed.

What should happen:

~~1. [FIXED] I made a 10x10 pen in both Minecraft and MineClone2, and took screenshots 5 minutes later. Both pens have 16 sheep (one for each available colour).~~

This is MineClone2 (and it got worse 5 minutes later, about 75% grazed):

This is Minecraft (1.19.4):

We need the grazing sound in, normalized.

~~3. [FIXED] This is how sheep look grazing in Minecraft:~~

Love mode should be disabled after breeding, along with the heart particles.
Applying dye should strictly dye the wool.

Below is a breeding table for colour combos (tested in Minecraft, based on the dye crafting table). If the two sheep are not in the combo table, the offspring will get their colour from one of the parents.

Colour	Parent combo
cyan	green + blue
gray	white + black
light blue	white + blue
light gray	white + gray
lime	green + white
magenta	pink + purple
orange	red + yellow
pink	red + white
purple	red + blue

When two mobs decide to breed, they should move towards each other (this applies to all breedables). They walk to each other, stop when they meet head to head, wait for 2-3 seconds, make the baby, then resume walking around.

MineClone2 version: latest master (6ded4d2322) ### What happened? ~~1. Sheep eat way too fast;~~ 2. Sheep don't make a sound when they graze; ~~3. Sheep don't tilt their heads to graze;~~ 4. After breeding, some seem to stay in love mode, showing heart particles; 5. Applying dye to their wool also activates their stand/walk ability *(do we really need sheep to have this?)* 6. Baby sheep are not properly coloured on breeding. (bug 4 also shown: hearts particles) The problem here is a bit weirder because the colours are not predictable when you make correct combinations, and killing the resulted (grown) sheep can also give you a different colour wool. As an example, I bred a blue + green sheep a few times, and the results were: - attempt 1: green - attempt 2: blue - attempt 3: cyan (and after I fed it to become adult, and killed it, it gave white wool) ![breeding a green sheep with a blue one, yielding a green baby sheep](https://i.imgur.com/RCKoLBO.jpg) 7. Mobs don't move toward each other when they breed. ### What should happen: ~~1. [FIXED] I made a 10x10 pen in both Minecraft and MineClone2, and took screenshots 5 minutes later. Both pens have 16 sheep (one for each available colour).~~ This is MineClone2 (and it got worse 5 minutes later, about 75% grazed): ![10x10 sheep pen in MineClone2](https://i.imgur.com/COcdKaV.jpg) This is Minecraft (1.19.4): ![10x10 sheep pen in Minecraft 1.19.4](https://i.imgur.com/vfYLt93.jpg) 2. We need the grazing sound in, normalized. ~~3. [FIXED] This is how sheep look grazing in Minecraft:~~ ![sheep eating grass in Minecraft](https://static.wikia.nocookie.net/minecraft_gamepedia/images/c/c7/Sheep_eating_grass.gif) 4. Love mode should be disabled after breeding, along with the heart particles. 5. Applying dye should strictly dye the wool. 6. Below is a breeding table for colour combos (tested in Minecraft, based on the [dye crafting table](https://minecraft.fandom.com/wiki/Dye#Crafting)). If the two sheep are not in the combo table, the offspring will get their colour from one of the parents. | Colour | Parent combo | | - | - | | cyan | green + blue | | gray | white + black | | light blue | white + blue | | light gray | white + gray | | lime | green + white | | magenta | pink + purple | | orange | red + yellow | | pink | red + white | | purple | red + blue | 7. When two mobs decide to breed, they should move towards each other *(this applies to all breedables)*. They walk to each other, stop when they meet head to head, wait for 2-3 seconds, make the baby, then resume walking around.

kneekoo added the

bug

gameplay

mobs

labels 2023-05-16 20:34:56 +02:00

epCode referenced this issue from a commit

2023-05-30 07:05:02 +02:00

Incorperate sheep eating animation. #3734

epCode referenced this issue

2023-05-30 18:32:23 +02:00

Incorperate sheep eating animation. #3768

epCode referenced this issue from a commit

2023-06-05 00:41:43 +02:00

Incorperate sheep eating animation. #3734

ancientmarinerdev commented

2023-06-05 16:08:05 +02:00

@kneekoo Are you ok to update this issue with what is outstanding now epCode's branch is merged, please? Thanks.

kneekoo commented

2023-06-06 02:30:21 +02:00

Ok, I crossed two items out. :)

👍 1

Laudrin commented

2024-06-24 15:10:50 +02:00

Sheep don't make a sound when they are fed with wheat.

8. Sheep don't make a sound when they are fed with wheat.

Laudrin referenced this issue

2024-06-24 15:15:20 +02:00

The definitive sound effects, music, & ambiance issues discussion #3548

kneekoo commented

2024-06-25 02:02:26 +02:00

But are they supposed to make a sound when feeding them? I haven't tried it in-game, but the Minecraft wiki doesn't mention a sound for this - only for grazing ("Block broken").

But are they supposed to make a sound when feeding them? I haven't tried it in-game, but the [Minecraft wiki](https://minecraft.wiki/w/Sheep#Sounds) doesn't mention a sound for this - only for grazing (*"Block broken"*).

Laudrin commented

2024-06-25 03:28:20 +02:00

Well, as feeding every other kind of farming mob produces a sound (cows, chickens and pigs), it is strange when sheep stay quiet.

Also the acoustic feedback is helpful to the player, as this sometimes is the only way to know if feeding was successful in a crowded area, where hungry and already fed animals run around and through each other.

And even if MC had no sound (haven't checked yet): I think if it is an improvement, you don't have to stick to the MC wiki exactly, more so, as VL aims to be different enough from MC not to be an exact clone, and to do some things in it's own way.

Well, as feeding every other kind of farming mob produces a sound (cows, chickens and pigs), it is strange when sheep stay quiet. Also the acoustic feedback is helpful to the player, as this sometimes is the only way to know if feeding was successful in a crowded area, where hungry and already fed animals run around and through each other. And even if MC had no sound (haven't checked yet): I think if it is an improvement, you don't have to stick to the MC wiki exactly, more so, as VL aims to be different enough from MC not to be an exact clone, and to do some things in it's own way.

the-real-herowl commented

2024-06-25 12:09:00 +02:00

But are they supposed to make a sound when feeding them? I haven't tried it in-game, but the Minecraft wiki doesn't mention a sound for this - only for grazing ("Block broken").

That's not an argument.

> But are they supposed to make a sound when feeding them? I haven't tried it in-game, but the [Minecraft wiki](https://minecraft.wiki/w/Sheep#Sounds) doesn't mention a sound for this - only for grazing (*"Block broken"*). That's not an argument.

kneekoo commented

2024-06-26 21:57:42 +02:00

Indeed, it was just a question. I still haven't tested that in Minecraft, so I was wondering if the wiki is missing these details or even Minecraft doesn't have a sound for feeding. I'm all for it if we can find a good one, for the record.

Laudrin commented

2024-06-27 11:38:27 +02:00

Feeding chicken, cows and pigs seems to be the same sound. So IMHO VL could just use this one feeding sound for sheep, too. No new sound required, except if you want all farm animals to have distinct feeding sounds as an enhancement.

kneekoo commented

2024-06-27 20:10:54 +02:00

Short sounds are probably small enough to tolerate as an addition even when each mob has its own. I know you've suggested sounds before, so if you already have suggestions for different sounds for mobs, add them here. We have a few sound-related items open, so I think we should check in with our music/sound people and ask them to look into equalizing the sounds to good levels and whatever else they decide that has to be done here.

Short sounds are probably small enough to tolerate as an addition even when each mob has its own. I know you've [suggested sounds](https://git.minetest.land/VoxeLibre/VoxeLibre/issues/4057#issuecomment-75775) before, so if you already have suggestions for different sounds for mobs, add them here. We have a few sound-related items open, so I think we should check in with our music/sound people and ask them to look into equalizing the sounds to good levels and whatever else they decide that has to be done here.

Sign in to join this conversation.