Structure Biome Colour Problems #3689

New Issue

Ghost · 2023-05-05T12:44:43+02:00

Ghost commented

2023-05-05 12:44:43 +02:00

Structures which contain any nodes that utilise a biome colour (such as grass, foliage, and water), will always have said nodes be the default colour (param2 = 0). This usually means that said nodes will be incorrectly coloured for the biome that these are located in (for example, green vines in a badlands biome where said vines should be a drier colour).

My proposed solution to this issue would be to add some sort of function which runs after the placement of said structures which contain these types of nodes, which ensures that these nodes have the correct colour for the biome that these are located in.

This may have a small impact on performance, however, I would consider this impact very negatable, since not only do these functions only run once after the placement of said structures, but said structures don't really appear that often to be causing any lag.

Structures which contain any nodes that utilise a biome colour (such as grass, foliage, and water), will always have said nodes be the default colour (`param2 = 0`). This usually means that said nodes will be incorrectly coloured for the biome that these are located in (for example, green vines in a badlands biome where said vines should be a drier colour). My proposed solution to this issue would be to add some sort of function which runs after the placement of said structures which contain these types of nodes, which ensures that these nodes have the correct colour for the biome that these are located in. This may have a small impact on performance, however, I would consider this impact very negatable, since not only do these functions only run once after the placement of said structures, but said structures don't really appear that often to be causing any lag.

Ghost added the

labels 2023-05-05 12:44:44 +02:00

the-real-herowl added this to the Mapgen update project 2024-06-27 21:51:13 +02:00

kno10 referenced a pull request that will close this issue

2024-09-03 22:51:23 +02:00

WIP: BIG mapgen update for structures and villages, needs testing #4611

Sign in to join this conversation.