22 translation files have syntax errors #3540
Labels
No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: VoxeLibre/VoxeLibre#3540
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
MineClone2 version:
7b53b6e45f
What happened?
I've written a quick and dirty Python script to automatically test locale files (
*.tr
andtemplate.txt
) for syntax errors such as missing placeholders or bad escaping.I'm running this script on various games now to see what happens and in MCL2 the script has found a lot of errors.
This is the test result:
What should happen:
The script should return 0 errors.
Possible fixes
Easiest fix: Clear the offending strings. Maybe move a copy of the broken string to the bottom as a comment for future reference.
If you happen to speak the language, fix the translation yourself.
You might also check if running the locale update script fixes some of these already.
Steps to reproduce
mods
directory of MCL260 translation files have syntax errorsto 55 translation files have syntax errors55 translation files have syntax errorsto 22 translation files have syntax errorsOK, it turned out my script had a lot of false-positives so I've rewrote and re-run it, and they seem legit now. But there are still 22 errors left, and they seem legit. Plus some warnings.
Phew. That seemed a big bit of work! This looks more manageable. Thanks for running this and sharing the results.
Oh, and thanks for MineClone2 and all the energy you invested in it! :D
After the French update, the script now returns:
(Note I've added a new error type to the script which is why the number of errors went down by only 2.)
If you have any questions, just ask.
If the errors still persist, I would like to help fixing them for the German translation if you tell me what I have to do when there is the error message
Missing placeholder(s) in translation: '@1'
(or @2) in your list.Can you give me an example how to fix the syntax errors or missing placeholders?
Basically, translation files look like
and the original string may have stuff like
@1
,@2
and so on in them, which are obviously placeholders for something that can be filled when the string is used. The translated string should contain the placeholders appropriately placed in the same amount (and there should be no space between@
and the number).However, I don't think you would find any in the German translation in particular.
Ah, thank you, I think I now understand! :-)
Hope I can post the corrected versions here:
./mods/ITEMS/mcl_enchanting/locale/mcl_enchanting.de.tr, lines 90 and 91
Not sure about this one:
./mods/HELP/mcl_doc/locale/mcl_doc.de.tr, line 54
But I found and fixed in line 53:
I think the next one is a false positive, seems okay to me:
./mods/HUD/awards/locale/awards.de.tr, line 4
The achievements file is incomplete. If the English template locale/translations file is complete, I may be able to add the missing translations later today.