Banner texture looks incorrect? #347

New Issue

Closed

opened 2018-06-22 08:30:10 +02:00 by Wuzzy · 11 comments

Wuzzy commented 2018-06-22 08:30:10 +02:00

Member

Copy Link

Author: @WSDguy2014 Posted at: 30.07.2017 10:04

Subgame version: 0.25.0

Author: @WSDguy2014 Posted at: 30.07.2017 10:04  Subgame version: 0.25.0

Wuzzy added the

bug

graphics

#P6: low

contribution inside

non-mob entities

labels 2018-06-22 08:30:10 +02:00

Wuzzy closed this issue 2018-06-22 08:30:10 +02:00

Wuzzy commented 2018-06-22 08:30:10 +02:00

Author

Member

Copy Link

Author: @Wuzzy2 Posted at: 30.07.2017 16:17

I summon you, @22i!

Author: @Wuzzy2 Posted at: 30.07.2017 16:17 I summon you, @22i!

Wuzzy commented 2018-06-22 08:30:11 +02:00

Author

Member

Copy Link

Author: @22i Posted at: 30.07.2017 18:13

Good find @WSDguy2014 @Wuzzy2

there was a small texture mapping flip that needed to be done on the lower side of the horizontal - wood

also it seem like the problem is with the pixel perfection baner_base texture itself so here is the new texture

baner_base texture https://github.com/22i/amc/blob/master/textures/amc_banner_base.png

banner model https://github.com/22i/amc/blob/master/models/amc_banner.b3d

banner hanging https://github.com/22i/amc/blob/master/models/amc_banner_hanging.b3d

Author: @22i Posted at: 30.07.2017 18:13 Good find @WSDguy2014 @Wuzzy2 there was a small texture mapping flip that needed to be done on the lower side of the horizontal - wood  also it seem like the problem is with the pixel perfection baner_base texture itself so here is the new texture baner_base texture https://github.com/22i/amc/blob/master/textures/amc_banner_base.png banner model https://github.com/22i/amc/blob/master/models/amc_banner.b3d banner hanging https://github.com/22i/amc/blob/master/models/amc_banner_hanging.b3d

Wuzzy commented 2018-06-22 08:30:11 +02:00

Author

Member

Copy Link

Author: @22i Posted at: 30.07.2017 18:19

with the new modified pixel perfection banner_base texture and new models it should look like this

Author: @22i Posted at: 30.07.2017 18:19 with the new modified pixel perfection banner_base texture and new models it should look like this 

Wuzzy commented 2018-06-22 08:30:11 +02:00

Author

Member

Copy Link

Author: @Wuzzy2 Posted at: 31.07.2017 00:25

@22i: Are you sure it's the PP texture which is to blame here? I looked at Faithful and the texture looks similar.
I'd rather like to avoid having incompatible textures in the repo.

Author: @Wuzzy2 Posted at: 31.07.2017 00:25 @22i: Are you sure it's the PP texture which is to blame here? I looked at Faithful and the texture looks similar. I'd rather like to avoid having incompatible textures in the repo.

Wuzzy commented 2018-06-22 08:30:11 +02:00

Author

Member

Copy Link

Author: @22i Posted at: 31.07.2017 08:09

yes im sure test the bannner in minecraft with different resource packs - pixel perfection, faithfull

minecraft default

pixel perfection

faithfull

papercutout

Author: @22i Posted at: 31.07.2017 08:09 yes im sure test the bannner in minecraft with different resource packs - pixel perfection, faithfull minecraft default  pixel perfection  faithfull  papercutout 

Wuzzy commented 2018-06-22 08:30:11 +02:00

Author

Member

Copy Link

Author: @Wuzzy2 Posted at: 31.07.2017 12:46

Sorry, I still have my doubts because you didn't post PP in comparison.

Author: @Wuzzy2 Posted at: 31.07.2017 12:46 Sorry, I still have my doubts because you didn't post PP in comparison.

Wuzzy commented 2018-06-22 08:30:12 +02:00

Author

Member

Copy Link

Author: @Wuzzy2 Posted at: 04.08.2017 20:29

Whatever. I went ahead and just fixed the texture.

Author: @Wuzzy2 Posted at: 04.08.2017 20:29 Whatever. I went ahead and just fixed the texture.

Wuzzy commented 2018-06-22 08:30:12 +02:00

Author

Member

Copy Link

Author: @22i Posted at: 11.08.2017 07:08

updated with new pixel perfection and papercutout comparisons - my guess is that when making the texture packs they did not check under the banner

Author: @22i Posted at: 11.08.2017 07:08 updated with new pixel perfection and papercutout comparisons - my guess is that when making the texture packs they did not check under the banner

Wuzzy commented 2018-06-22 08:30:12 +02:00

Author

Member

Copy Link

Author: @Wuzzy2 Posted at: 11.08.2017 13:43

So … is everything fine then? Or do I need to update something again?

And why are there amc_bannerhanging.b3d and amc_banner_hanging.b3d?

Author: @Wuzzy2 Posted at: 11.08.2017 13:43 So … is everything fine then? Or do I need to update something again? And why are there `amc_bannerhanging.b3d` and `amc_banner_hanging.b3d`?

Wuzzy commented 2018-06-22 08:30:13 +02:00

Author

Member

Copy Link

Author: @22i Posted at: 19.08.2017 11:59

i also discovered that minecraft default banner texture was different in minecraft 1.8 than in minecraft 1.11

minecraft 1.8 banner_base

minecraft 1.11 banner_base

Author: @22i Posted at: 19.08.2017 11:59 i also discovered that minecraft default banner texture was different in minecraft 1.8 than in minecraft 1.11 minecraft 1.8 banner_base   minecraft 1.11 banner_base  

Wuzzy commented 2018-06-22 08:30:13 +02:00

Author

Member

Copy Link

Author: @22i Posted at: 19.08.2017 15:23

when i fixed the model i forgot to rename it from amc_bannerhanging.b3d to amc_banner_hanging.b3d so you just need to change the hanging model

banner hanging https://github.com/22i/amc/blob/master/models/amc_banner_hanging.b3d

i checked the standing banner in the mineclone2 and its fine

Author: @22i Posted at: 19.08.2017 15:23 when i fixed the model i forgot to rename it from amc_bannerhanging.b3d to amc_banner_hanging.b3d so you just need to change the hanging model banner hanging https://github.com/22i/amc/blob/master/models/amc_banner_hanging.b3d i checked the standing banner in the mineclone2 and its fine

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

mcl_mobs_cleanup

mcl_chests_redo

improve_planks

fix-has_room

opencollective-link

upstream/unbreaking_on_crossbows

mob_ignore_fix

slabs_block_light

hardness_blast_res_fixes

buildable_flowers

burning_in_thunder

redstone-update

add_shader_support

hammers_spears

EE_armor

mapgen_update

projectile-refactor

world_aligned_textures

zombie_texture_improvements

mcl_weathered_nodes

orb_of_exchange

fix_pumpkin_names

patch_skins

hollow_logs_ref_recovery

copper-adaptation-refs-recovery

add_asset_attributions_1

fix_pumpkin_typo_pumkin

cherry_grove

lush_caves

release/0.86.1

mobile_bow_workaround

release/0.85.1

optimize_jukebox_sounds

optimize_theme_ogg

Optimize_backgrounds_jpg

archaeology

spanish-translations

fish_bucket_nametag

villager-golem-fixes

fix_beetroot_fortune_drops

fix_sliding

illager_banner_description

release_0.83.1

skelly_horse_thunder

mobs_armor

mobsarmorfix

smoother_biome_borders

jukebox_sound_distance

cobble_abm_height

callable-tool-rightclick-functions

effects_rewrite

respiration

make-new-music-louder

damage

texture_conversion_wool

dehardcoded_signs

mcl_oxidization

Texture-Rename2

Bamboo-Piston-Dig

hardcore_mode_test

update_german_translation_attempt2

test_mob_tweaks_branch

csm-enabled

move_physics_tweak

water_footstep

biome_skycolor

bambootoo

lower_ow_mapgen

release/0.81.1

revert_chest_models

mcl-craftguide-drop-sfinv

mcl-structures-fixes

turtlestriderbeefox

arrow_node_collision

pvp_knockback

icebergs

light_dump

testing

mobs-redo

wood_api

mobs_head_rotation

bonemeal

dyable-leather-armor

new_mapgen_api

newmobs-master

formspec_overhaul

mobs

mapgen

mineclone5

chat-command-builder-2

formspec-v4

doc-refactoring

production

objects

0.87.2

0.87.1

0.87.0

0.86.2

0.86.1

0.86.0

0.85.0

0.84.0

0.83.1

0.83.0

0.82.0

0.81.1

0.81.0

0.80.1

0.80.0

0.79.0

0.78.0

0.77.0

0.76.0

0.75.0

0.74.0

0.73.1

0.73.0

0.72.1

0.72.0

0.71.0

0.70.0

0.69.1

0.69.0

0.68.0

0.67.2

0.67.1

0.67.0

0.66.2

0.66.1

0.66.0

0.65.2

0.65.1

0.65.0

0.64.0

0.63.0

0.62.0

0.61.0

0.60.0

0.59.2

0.59.1

0.59.0

0.58.1

0.58.0

0.57.1

0.57.0

0.56.2

0.56.1

0.56.0

0.55.1

0.55.0

0.54.1

0.54.0

0.53.4

0.53.3

0.53.2

0.53.1

0.53.0

0.52.1

0.52.0

0.51.1

0.51.0

0.50.2

0.50.1

0.50.0

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.0

0.45.1

0.45.0

0.44.0

0.43.0

0.42.0

0.21.0

Labels

Clear labels   

#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  

#P2: HIGH

highest priority level

  

#P3: elevated

2nd-highest priority level

  

#P4 priority: medium

for things that aren't elevated but have been prioritised

  

#P6: low

low priority level

  

#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  

annoying

non-bugs that annoys people

  

API

  

bug

  

code quality

  

combat

  

commands

  

compatibility

Label to cover migration issues from old worlds or mcl5

  

configurability

  

contribution inside

  

controls

  

core feature

  

creative mode

  

delayed for engine release

  

documentation

  

duplicate

  

enhancement

enhancement request/suggestion

  

environment

Issues that affect weather or light

  

gameplay

  

graphics

  

ground content conflict

mapgen gc-specific quirks

  

GUI/HUD

  

help wanted

  

incomplete feature

  

invalid / won't fix

Invalid, or will not fix

  

items

  

looking for contributor

  

mapgen

  

meta

Relating to VoxeLibre on Mesehub and elsewhere

  

mineclone2+

fit for MineClone2-Plus

  

Minecraft >= 1.13

  

Minecraft >= 1.17

  

missing feature

  

mobile

involving Minetest on mobile devices (android)

  

mobs

  

mod support

Issues related to mod support

  

model needed

A model is needed to be created or updated

  

multiplayer

Issues affecting multiplayer

  

Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  

needs discussion

  

needs engine change

  

needs more information

  

needs research

  

nodes

  

non-Minecraft feature

  

non-mob entities

  

performance

  

player

issues related to the player

  

possible close

  

redstone

  

release notes

This ticket will need information adding to release notes

  

schematics

  

Skyblock

  

sounds

  

Testing / Retest

This needs testing or retesting

  

tools

Related to the tools scripts, which aren't run in game

  

translation

  

unconfirmed

  

mcl5

Possibly relevant for MineClone5

  

mcla

Possibly relevant for Mineclonia

  

Media missing

media files for this feature are missing - contributions welcome

No Label

#P1 CRITICAL

#P2: HIGH

#P3: elevated

#P4 priority: medium

#P6: low

#Review

annoying

API

bug

code quality

combat

commands

compatibility

configurability

contribution inside

controls

core feature

creative mode

delayed for engine release

documentation

duplicate

enhancement

environment

gameplay

graphics

ground content conflict

GUI/HUD

help wanted

incomplete feature

invalid / won't fix

items

looking for contributor

mapgen

meta

mineclone2+

Minecraft >= 1.13

Minecraft >= 1.17

missing feature

mobile

mobs

mod support

model needed

multiplayer

Needs adoption

needs discussion

needs engine change

needs more information

needs research

nodes

non-Minecraft feature

non-mob entities

performance

player

possible close

redstone

release notes

schematics

Skyblock

sounds

Testing / Retest

tools

translation

unconfirmed

mcl5

mcla

Media missing

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#347

No description provided.