Player animation must be preserved after skin change #3340

New Issue

kneekoo · 2023-01-20T13:43:54+01:00

kneekoo commented

2023-01-20 13:43:54 +01:00

MineClone2 version: master snapshot 99d09c76ae (2023-01-20)

What happened?

When entering a minecart or boat, the player sits. If you change your skin, the player will stand.

What should happen:

The player needs to keep the same position after a skin change.

MineClone2 version: master snapshot 99d09c76ae (2023-01-20) ### What happened? When entering a minecart or boat, the player sits. If you change your skin, the player will stand. ### What should happen: The player needs to keep the same position after a skin change.

👍 1

kneekoo added the

bug

gameplay

labels 2023-01-20 13:44:02 +01:00

kneekoo referenced this issue

2023-01-20 14:06:48 +01:00

Default male char mesh_hand broken #3338

epCode changed title from ~~Player position must be preserved after skin change~~ to Player animation must be preserved after skin change

2023-01-25 01:47:03 +01:00

MrRar commented

2023-03-21 19:19:26 +01:00

I can't reproduce this. Maybe it was fixed by some random PR since this was posted.

kneekoo commented

2023-03-21 23:07:42 +01:00

This is still in, I could reproduce it with a fresh master.

use right-click to enter a minecart
press F7 so see yourself sitting in it
change your skin and the player gets switched to standing

This is still in, I could reproduce it with a fresh `master`. 1. use right-click to enter a minecart 2. press F7 so see yourself sitting in it 3. change your skin and the player gets switched to standing

MrRar commented

2023-03-29 18:46:48 +02:00

This is still in, I could reproduce it with a fresh master.

use right-click to enter a minecart

press F7 so see yourself sitting in it

change your skin and the player gets switched to standing

I tried that. Except change camera is 'C' for me. I can change my character's skin all day when he's in a minecart and he never stands up.

> This is still in, I could reproduce it with a fresh `master`. > > 1. use right-click to enter a minecart > 2. press F7 so see yourself sitting in it > 3. change your skin and the player gets switched to standing I tried that. Except change camera is 'C' for me. I can change my character's skin all day when he's in a minecart and he never stands up.

ancientmarinerdev commented

2023-03-29 20:30:11 +02:00

I tested it, I went from custom -> Barry, and character remained seated. I changed from Barry -> Amy, and character stood up. Between that though, a pig joined me on my journey and I couldn't stop laughing. Took me by surprise. Thanks @anarquimico !

(not officially Barry and Amy, but I had to call them something. We probably need to shortlist and pick best 2.)

I tested it, I went from custom -> Barry, and character remained seated. I changed from Barry -> Amy, and character stood up. Between that though, a pig joined me on my journey and I couldn't stop laughing. Took me by surprise. Thanks @anarquimico ! (not officially Barry and Amy, but I had to call them something. We probably need to shortlist and pick best 2.)

pig in minecart.png

389 KiB