Some fences Nether connect to the overworld fences ;) #3290

New Issue

ancientmarinerdev · 2023-01-10T15:34:00+01:00

ancientmarinerdev commented

2023-01-10 15:34:00 +01:00

MineClone2 version: Master

What happened?

The nether fences do not connect to overworld fences or each other.

What should happen:

They should connect like one big fence conga train.

Steps to reproduce

Make fence next to other fences.

MineClone2 version: Master ### What happened? The nether fences do not connect to overworld fences or each other. ### What should happen: They should connect like one big fence conga train. ### Steps to reproduce Make fence next to other fences.

nether fence.png

68 KiB

ancientmarinerdev added the

bug

label 2023-01-10 15:34:28 +01:00

ancientmarinerdev commented

2023-01-10 15:35:44 +01:00

They do connect to themselves, however.

They need to use the group, rather than name I'm guessing.

They do connect to themselves, however. They need to use the group, rather than name I'm guessing.

connected.png

101 KiB

Michieal commented

2023-01-11 04:33:51 +01:00

They do connect to themselves, however.

They need to use the group, rather than name I'm guessing.

Your assumption is correct.

Example:

	local id = "bamboo_fence"
	local wood_groups = {handy = 1, axey = 1, flammable = 2, fence_wood = 1, fire_encouragement = 5, fire_flammability = 20}
	local wood_connect = {"group:fence_wood"}

	local fence_id = mcl_fences.register_fence(id, S("Bamboo Fence"), "mcl_bamboo_fence_bamboo.png", wood_groups,
			2, 15, wood_connect, node_sound)

Note the variable wood_connect -- this allows bamboo fencing to connect to any of the fences made out of wood, that have been properly registered.

I would imagine that whoever made them, really didn't know what to connect them to. The crimson and warped fence should connect to other wood fences. The Netherbrick fence... probably to a stone fence; but those are actually "walls" (different module).

> They do connect to themselves, however. > > They need to use the group, rather than name I'm guessing. Your assumption is correct. Example: ``` local id = "bamboo_fence" local wood_groups = {handy = 1, axey = 1, flammable = 2, fence_wood = 1, fire_encouragement = 5, fire_flammability = 20} local wood_connect = {"group:fence_wood"} local fence_id = mcl_fences.register_fence(id, S("Bamboo Fence"), "mcl_bamboo_fence_bamboo.png", wood_groups, 2, 15, wood_connect, node_sound) ``` Note the variable `wood_connect` -- this allows bamboo fencing to connect to any of the fences made out of wood, that have been properly registered. I would imagine that whoever made them, really didn't know what to connect them to. The crimson and warped fence should connect to other wood fences. The Netherbrick fence... probably to a stone fence; but those are actually "walls" (different module).

AFCMS commented

2023-01-11 21:19:14 +01:00

Just tested in MC.

The wood fences should connect (including the nether ones) except with the brick ones.

I think everything is right here.

Just tested in MC. The wood fences should connect (including the nether ones) except with the brick ones. I think everything is right here.

ancientmarinerdev added the

nodes

code quality

labels 2023-03-12 23:06:06 +01:00

Ghost commented

2023-05-12 05:14:41 +02:00

The fence connects for me, and the code looks correct. Close?

👍 1

Ghost added the

possible close

label 2023-05-12 05:14:59 +02:00

ancientmarinerdev commented

2023-05-12 13:47:23 +02:00

Actually, this looks like a mistake on my part, I thought it was a crimson wood fence and wouldn't connect to the warped. Looks like there is 2 types of nether brick. I'm not sure why nether bricks are fences rather than walls, but hey, a minor issue.

Anyway, I'll close this.

Actually, this looks like a mistake on my part, I thought it was a crimson wood fence and wouldn't connect to the warped. Looks like there is 2 types of nether brick. I'm not sure why nether bricks are fences rather than walls, but hey, a minor issue. Anyway, I'll close this.

ancientmarinerdev closed this issue

2023-05-12 13:47:26 +02:00

Michieal commented

2023-06-09 04:52:07 +02:00

Actually, this looks like a mistake on my part, I thought it was a crimson wood fence and wouldn't connect to the warped. Looks like there is 2 types of nether brick. I'm not sure why nether bricks are fences rather than walls, but hey, a minor issue.

Anyway, I'll close this.

Nether brick: the game (mc/mcl) has both. the nether brick fences do not connect to the nether brick walls.

Crimson and Warped fences will connect to overworld fences. Nether brick fences will not connect to overworld fences, but connect to other Nether style fences.

One of the ways to make a pen or wall, is that you put overworld fences and nether brick fences together in an every-other-one fashion. You can walk through it, but all other mobs cannot.

> Actually, this looks like a mistake on my part, I thought it was a crimson wood fence and wouldn't connect to the warped. Looks like there is 2 types of nether brick. I'm not sure why nether bricks are fences rather than walls, but hey, a minor issue. > > Anyway, I'll close this. Nether brick: the game (mc/mcl) has both. the nether brick fences do not connect to the nether brick walls. Crimson and Warped fences will connect to overworld fences. Nether brick fences will *not* connect to overworld fences, but connect to other Nether style fences. One of the ways to make a pen or wall, is that you put overworld fences and nether brick fences together in an every-other-one fashion. You can walk through it, but all other mobs cannot.

Sign in to join this conversation.