Village structures are placed too high in thin snow #3246

New Issue

MrRar · 2023-01-04T23:03:51+01:00

MrRar commented

2023-01-04 23:03:51 +01:00

No description provided.

Capture.PNG

197 KiB

👍 3

ancientmarinerdev commented

2023-01-04 23:25:35 +01:00

Definitely good to raise that. I'll have to compare path placement to snow and see why that's doing that. Same for buildings.

Still some way to go on them, but hopefully can get them more functional :).

Definitely good to raise that. I'll have to compare path placement to snow and see why that's doing that. Same for buildings. Still some way to go on them, but hopefully can get them more functional :).

👍 1

CyberMango commented

2023-01-04 23:58:08 +01:00

Definitely good to raise that.

pun intended?

anyways this bug has to happen because the structures' placement is relative to the snow above the ground and not to the ground itself.

> Definitely good to raise that. pun intended? anyways this bug has to happen because the structures' placement is relative to the snow above the ground and not to the ground itself.

👍 1 😆 2

Michieal commented

2023-01-05 05:32:44 +01:00

anyways this bug has to happen because the structures' placement is relative to the snow above the ground and not to the ground itself.

looks like this to me...

Maybe do ground.y-1 ? dunno, but -- trying to be helpful.

> anyways this bug has to happen because the structures' placement is relative to the snow above the ground and not to the ground itself. looks like this to me... Maybe do ground.y-1 ? dunno, but -- trying to be helpful.

ancientmarinerdev commented

2023-01-05 12:45:20 +01:00

No pun intented... but I wish I saw it!

This is used for many things other than snow. It iterates down from air, or up from ground and looks for surface materials (snow, flowers etc.). I don't want to do y-1 unless it's only for this case or doesn't regress other cases. For leaves, I did check y-1 to see there wasn't leaves below. I'll do some thinking for this, testing and check the output of y-1 for different village formations and see what happens in different biomes.

No pun intented... but I wish I saw it! This is used for many things other than snow. It iterates down from air, or up from ground and looks for surface materials (snow, flowers etc.). I don't want to do y-1 unless it's only for this case or doesn't regress other cases. For leaves, I did check y-1 to see there wasn't leaves below. I'll do some thinking for this, testing and check the output of y-1 for different village formations and see what happens in different biomes.

❤️ 1

CyberMango commented

2023-01-05 13:28:10 +01:00

@ancientmarinerdev so perhaps work with a white list or black list of nodes it should regard as "this is the surface", such as only accept dirt/sand/stone/cobblestone, or dont accept leaves/thin snow/wood.

ancientmarinerdev commented

2023-01-05 14:23:42 +01:00

It does have something like that. I could probably do it, but the level of time for testing and checking cases won't be fun. There is also a question about whether the bottom dirt level goes from schematics.

A few things on my list, but it isn't top priority for me yet.

I do plan to revisit villages and schematics though as the building at the highest or lowest point annoys me and looks horrific.

It does have something like that. I could probably do it, but the level of time for testing and checking cases won't be fun. There is also a question about whether the bottom dirt level goes from schematics. A few things on my list, but it isn't top priority for me yet. I do plan to revisit villages and schematics though as the building at the highest or lowest point annoys me and looks horrific.

👍 2

ancientmarinerdev added the

mapgen

label 2023-01-07 14:57:45 +01:00

Sign in to join this conversation.