VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
57
134
Fork 174
Code Issues 963 Pull Requests 96 Projects 4 Releases Wiki Activity

Villager spawning code not working effectively #2779

New Issue
Open
opened 2022-10-14 17:48:13 +02:00 by ancientmarinerdev · 15 comments
ancientmarinerdev commented 2022-10-14 17:48:13 +02:00
Owner
Copy Link

I've found 2 villages, and only 1 villager, the second village has at least 7 red beds, possibly more, there is about 10 buildings. The code should spawn a villager per red bed, but it does not.

Code in buildings.lui is below:

local function spawn_villagers(minp,maxp)
	local beds=minetest.find_nodes_in_area(vector.offset(minp,-20,-20,-20),vector.offset(maxp,20,20,20),{"mcl_beds:bed_red_bottom"})
	for _,bed in pairs(beds) do
		local m = minetest.get_meta(bed)
		if m:get_string("villager") == "" then
			local v=minetest.add_entity(bed,"mobs_mc:villager")
			if v then
				local l=v:get_luaentity()
				l._bed = bed
				m:set_string("villager",l._id)
			end
		end
	end
end

Cora mentioned this spawn code sometimes fails. Villages already seem rarer than minecraft, and when the ones you find are non functional, it's quite demoralising and painfully grindy, especially without zoomed out maps, so feels quite a high priority bug. I'll try and add some debug logs in and see if anything is going wrong when I next discover one to give some more information.

I've found 2 villages, and only 1 villager, the second village has at least 7 red beds, possibly more, there is about 10 buildings. The code should spawn a villager per red bed, but it does not. Code in buildings.lui is below: ``` local function spawn_villagers(minp,maxp) local beds=minetest.find_nodes_in_area(vector.offset(minp,-20,-20,-20),vector.offset(maxp,20,20,20),{"mcl_beds:bed_red_bottom"}) for _,bed in pairs(beds) do local m = minetest.get_meta(bed) if m:get_string("villager") == "" then local v=minetest.add_entity(bed,"mobs_mc:villager") if v then local l=v:get_luaentity() l._bed = bed m:set_string("villager",l._id) end end end end ``` Cora mentioned this spawn code sometimes fails. Villages already seem rarer than minecraft, and when the ones you find are non functional, it's quite demoralising and painfully grindy, especially without zoomed out maps, so feels quite a high priority bug. I'll try and add some debug logs in and see if anything is going wrong when I next discover one to give some more information.
epCode commented 2022-10-14 18:59:35 +02:00
Member
Copy Link

here's something: we will always be updating, and the villages are currently, better than they have ever been.

here's something: we will always be updating, and the villages are currently, better than they have ever been.
cora added the
bug
mapgen
mobs
 labels 2022-10-14 19:12:22 +02:00
ancientmarinerdev commented 2022-10-14 19:16:11 +02:00
Author
Owner
Copy Link

I'm not trying to criticise here. You've all done a great job. I'm raising a genuine bug to help isolate issues that could affect user experience.

I found a third village with something like 15 houses. When I got there, there was zero villagers despite the fact it seems to have tried to spawn them...

2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers

I don't know if the spawning them and they're dying. This one was a mountain village, and half was high and half was down, but even down I couldn't see anything. I did see a rabbit suicide after jumping from a height in front of me. I'm wondering if they're pathfinding to their death.

I did have a cave which ended up having loads of farm animals end up stuck in. The safety check before moving could have an issue.

I am adding more debug logging in and will keep reviewing.

I'm not trying to criticise here. You've all done a great job. I'm raising a genuine bug to help isolate issues that could affect user experience. I found a third village with something like 15 houses. When I got there, there was zero villagers despite the fact it seems to have tried to spawn them... 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:07: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-14 17:25:08: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers I don't know if the spawning them and they're dying. This one was a mountain village, and half was high and half was down, but even down I couldn't see anything. I did see a rabbit suicide after jumping from a height in front of me. I'm wondering if they're pathfinding to their death. I did have a cave which ended up having loads of farm animals end up stuck in. The safety check before moving could have an issue. I am adding more debug logging in and will keep reviewing.
Ghost commented 2022-10-14 19:20:12 +02:00
Copy Link

Animals are dumb when it comes to heights. In my main lets play world, I have a cliff aply named the Suicide Cliffs because wolves constantly jump off to their death instead of taking the bridge I built. I also call it the Cliffs of Insanity, but you have to have watched a certain movie to know where that comes from.

Animals are dumb when it comes to heights. In my main lets play world, I have a cliff aply named the Suicide Cliffs because wolves constantly jump off to their death instead of taking the bridge I built. I also call it the Cliffs of Insanity, but you have to have watched a certain movie to know where that comes from.
😆 1
cora commented 2022-10-14 19:39:44 +02:00
Contributor
Copy Link

well the villagers are somewhat safe in their houses at least until they find a way out.

see if the add_entity returns a valid object (e.g. put some debug code into the "if v then"

well the villagers are somewhat safe in their houses at least until they find a way out. see if the add_entity returns a valid object (e.g. put some debug code into the "if v then"
👍 1
ancientmarinerdev commented 2022-10-15 00:54:18 +02:00
Author
Owner
Copy Link

I've been reading through the mobs code for walk, and it seems that mobs will walk if they aren't scared of the height of the block. Villagers have that at 4, so if it's a 3 drop, they'll still have a chance of going down, and not going back up. In this case, they'll always eventually end up at the lowest point.

I don't think they check for a cliff unless in danger.

I saw this with a cave near my base that all farm animals ended up in (see screenshot).

I don't believe mobs should (when calm and not in danger), walk down from a block that is more than 1 high, and they can't get back up.

With farm animals, they struggle to jump up when lead (can fail 5 jumps first before getting up), so I suspect fail to jump, change direction, go down, fail to jump, change direction go down, etc.

This is even more important if it's a villager and needs to get back to it's job block or bed.

Please can someone validate I have understood this correctly?

I've been reading through the mobs code for walk, and it seems that mobs will walk if they aren't scared of the height of the block. Villagers have that at 4, so if it's a 3 drop, they'll still have a chance of going down, and not going back up. In this case, they'll always eventually end up at the lowest point. I don't think they check for a cliff unless in danger. I saw this with a cave near my base that all farm animals ended up in (see screenshot). I don't believe mobs should (when calm and not in danger), walk down from a block that is more than 1 high, and they can't get back up. With farm animals, they struggle to jump up when lead (can fail 5 jumps first before getting up), so I suspect fail to jump, change direction, go down, fail to jump, change direction go down, etc. This is even more important if it's a villager and needs to get back to it's job block or bed. Please can someone validate I have understood this correctly?
Screenshot_20221013_004516.png
442 KiB
Screenshot_20221013_004516.png
epCode commented 2022-10-15 01:01:33 +02:00
Member
Copy Link

then at a midly high slope have mobs just not even moving on at all, it would be a nightmare trying to lura a tamagble mob into your animal pen.

then at a midly high slope have mobs just not even moving on at all, it would be a nightmare trying to lura a tamagble mob into your animal pen.
ancientmarinerdev commented 2022-10-15 01:22:19 +02:00
Author
Owner
Copy Link

It is already a nightmare trying to lure a cow to your pen. Any uphill is agony. They don't struggle to jump like the in Minecraft.

It is already a nightmare trying to lure a cow to your pen. Any uphill is agony. They don't struggle to jump like the in Minecraft.
cora commented 2022-10-15 01:25:45 +02:00
Contributor
Copy Link

they do have some tendency to end up at low points yes. But if that was the case with your villagers you should be able to still find them ... I think the spawning actually doesn't work out sometimes. Not sure why though i thought its maybe if the player is too far away or something but i could not reproduce that so far.

I mean we could make a minetest.after loop and keep trying to spawn them until the object is there if that's actually the case.

they do have some tendency to end up at low points yes. But if that was the case with your villagers you should be able to still find them ... I think the spawning actually doesn't work out sometimes. Not sure why though i thought its maybe if the player is too far away or something but i could not reproduce that so far. I mean we could make a minetest.after loop and keep trying to spawn them until the object is there if that's actually the case.
epCode commented 2022-10-15 01:26:19 +02:00
Member
Copy Link

They don't struggle to jump like the in Minecraft.

I am working on this.

> They don't struggle to jump like the in Minecraft. I am working on this.
👍 1 🚀 1
ancientmarinerdev commented 2022-10-15 01:54:16 +02:00
Author
Owner
Copy Link

I'm watching them operate on creative.

They are jumping down 3 blocks, maybe more into water.
They jump down more than 3 blocks on to land.
They also walk onto flowing lava.
They get off of water on to flowing lava.
They also walk diagonally onto lava source.

It could be that they don't spawn, but if they are suicidal, then it wouldn't matter if they did spawn because they might not last long enough for you to find them.

Edited.

I'm watching them operate on creative. They are jumping down 3 blocks, maybe more into water. They jump down more than 3 blocks on to land. They also walk onto flowing lava. They get off of water on to flowing lava. They also walk diagonally onto lava source. It could be that they don't spawn, but if they are suicidal, then it wouldn't matter if they did spawn because they might not last long enough for you to find them. Edited.
cora commented 2022-10-15 01:56:05 +02:00
Contributor
Copy Link

well as i said they usually take some time to get out of their houses - and even more now that far mobs don't move anymore.

well as i said they usually take some time to get out of their houses - and even more now that far mobs don't move anymore.
👍 1
ancientmarinerdev commented 2022-10-16 19:07:00 +02:00
Author
Owner
Copy Link

A bit of an update on this, I added some logging in:

local function spawn_villagers(minp,maxp)
	minetest.log("warning", "[mcl_villages] Attempted to spawn villagers" .. minp.x .. ":" .. minp.z)
	local beds=minetest.find_nodes_in_area(vector.offset(minp,-20,-20,-20),vector.offset(maxp,20,20,20),{"mcl_beds:bed_red_bottom"})
	for _,bed in pairs(beds) do
		minetest.log("warning", "[mcl_villages] Attempted to spawn villager for this bed")
		local m = minetest.get_meta(bed)
		if m:get_string("villager") == "" then
			minetest.log("warning", "[mcl_villages] Meta set, try to spawn")
			local v=minetest.add_entity(bed,"mobs_mc:villager")
			if v then
				minetest.log("warning", "[mcl_villages] Successfully added villager entity")
				local l=v:get_luaentity()
				l._bed = bed
				m:set_string("villager",l._id)
			end
		end
	end
end

Obviously, I made a slight error on the meta set, log should say meta for villager blank, but it gives better information on what is happening.

One issue is that I played on a version that probably doesn't have the code you added so mobs far away don't move, so by the time I got there, villagers probably suicided. I was exploring (checking logs every 3 to 4 mins and ran there as soon as I could. But when I got there, I found 4 in their house, and 1 roaming away (that eventually dissappeared) out of 10 spawns, so villagers could be emotionally unstable and do not want to live. It was a mountain village so definitely more risky (the village spawn code for houses may be something that could be adapted eventually).

Summary :

20 houses
?? beds (will verify and update)
10 attempts
10 successful spawns
5 villager found

Log result:

2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Place beltower
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 1
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 2
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 3
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 4
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 5
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 6
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 7
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 8
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 9
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 10
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 11
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 12
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 13
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 14
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 15
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 16
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 17
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 18
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 19
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 20
2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic
2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_structures] mineshaft placed at (815,-33,1963)
2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_structures] mineshaft placed at (815,-59,1963)
2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_structures] mineshaft placed at (721,-9,1864)
2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_dungeons] Placing new dungeon at (817,-50,2080)
2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_dungeons] Filling chest 2 at (820,-49,2085)
2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_dungeons] Filling chest 1 at (819,-49,2085)
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Spawn iron golum
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers706:2028
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers713:2003
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers727:2007
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers741:2007
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers742:2033
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers721:2031
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers731:2021
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers717:2017
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers723:1993
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers736:1991
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers747:2019
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers709:1989
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers749:1995
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers757:2007
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers698:1999
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers719:1978
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers735:1978
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers752:2032
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers727:2045
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers690:2017
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity
2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed

My view:

The moving far away is one issue (solved by Cora)
The villager path finding needs refinement (I think they should move on a square that is no more than 1 square drop, so they can get back up, also that block shouldn't be lava or flowing lava). This way, I think there livecycle will dramatically improve. Happier villagers make happier players :D.

A bit of an update on this, I added some logging in: ``` local function spawn_villagers(minp,maxp) minetest.log("warning", "[mcl_villages] Attempted to spawn villagers" .. minp.x .. ":" .. minp.z) local beds=minetest.find_nodes_in_area(vector.offset(minp,-20,-20,-20),vector.offset(maxp,20,20,20),{"mcl_beds:bed_red_bottom"}) for _,bed in pairs(beds) do minetest.log("warning", "[mcl_villages] Attempted to spawn villager for this bed") local m = minetest.get_meta(bed) if m:get_string("villager") == "" then minetest.log("warning", "[mcl_villages] Meta set, try to spawn") local v=minetest.add_entity(bed,"mobs_mc:villager") if v then minetest.log("warning", "[mcl_villages] Successfully added villager entity") local l=v:get_luaentity() l._bed = bed m:set_string("villager",l._id) end end end end ``` Obviously, I made a slight error on the meta set, log should say meta for villager blank, but it gives better information on what is happening. One issue is that I played on a version that probably doesn't have the code you added so mobs far away don't move, so by the time I got there, villagers probably suicided. I was exploring (checking logs every 3 to 4 mins and ran there as soon as I could. But when I got there, I found 4 in their house, and 1 roaming away (that eventually dissappeared) out of 10 spawns, so villagers could be emotionally unstable and do not want to live. It was a mountain village so definitely more risky (the village spawn code for houses may be something that could be adapted eventually). Summary : 20 houses ?? beds (will verify and update) 10 attempts 10 successful spawns 5 villager found Log result: 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Place beltower 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 1 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 2 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 3 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 4 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 5 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 6 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 7 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 8 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 9 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 10 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 11 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 12 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 13 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 14 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 15 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 16 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 17 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 18 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 19 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Build house 20 2022-10-16 02:18:46: WARNING[Emerge-0]: [mcl_villages] Get ready to place schematic 2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_structures] mineshaft placed at (815,-33,1963) 2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_structures] mineshaft placed at (815,-59,1963) 2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_structures] mineshaft placed at (721,-9,1864) 2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_dungeons] Placing new dungeon at (817,-50,2080) 2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_dungeons] Filling chest 2 at (820,-49,2085) 2022-10-16 02:18:46: ACTION[Emerge-0]: [mcl_dungeons] Filling chest 1 at (819,-49,2085) 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Spawn iron golum 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers706:2028 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers713:2003 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers727:2007 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers741:2007 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers742:2033 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers721:2031 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers731:2021 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers717:2017 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers723:1993 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers736:1991 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers747:2019 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers709:1989 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers749:1995 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers757:2007 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers698:1999 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers719:1978 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers735:1978 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers752:2032 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers727:2045 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Init nodes called 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villagers690:2017 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Meta set, try to spawn 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Successfully added villager entity 2022-10-16 02:18:47: WARNING[Emerge-0]: [mcl_villages] Attempted to spawn villager for this bed My view: The moving far away is one issue (solved by Cora) The villager path finding needs refinement (I think they should move on a square that is no more than 1 square drop, so they can get back up, also that block shouldn't be lava or flowing lava). This way, I think there livecycle will dramatically improve. Happier villagers make happier players :D.
cora commented 2022-10-16 21:39:06 +02:00
Contributor
Copy Link

They should in theory try to go back to the village when they go too far away – but ig in a lot of cases they simply can't. I've thought about teleporting them back before tbh.

The biggest problem with the pathfinding is that it does not take y space on the path into account (1 high holes are enough for it).

But actually implementing pathfinding is prob beyond me honestly - i just used the minetest function.

I'm wondering how you're able to reproduce this so seemingly consistently though because i've tried all kinds of things and could not (p sure i have seen the issue "in the wild" though).

If you think they move away too quickly you could try fast/flying there ... or use a more convenient client like dragonfire (it can show you where entities are, make everything bright and much more).

https://github.com/dragonfireclient/dragonfireclient

They should in theory try to go back to the village when they go too far away – but ig in a lot of cases they simply can't. I've thought about teleporting them back before tbh. The biggest problem with the pathfinding is that it does not take y space on the path into account (1 high holes are enough for it). But actually implementing pathfinding is prob beyond me honestly - i just used the minetest function. I'm wondering how you're able to reproduce this so seemingly consistently though because i've tried all kinds of things and could not (p sure i have seen the issue "in the wild" though). If you think they move away too quickly you could try fast/flying there ... or use a more convenient client like dragonfire (it can show you where entities are, make everything bright and much more). https://github.com/dragonfireclient/dragonfireclient
Laudrin commented 2024-01-14 15:43:50 +01:00
Copy Link

It could be that they don't spawn, but if they are suicidal, then it wouldn't matter if they did spawn because they might not last long enough for you to find them.

I created a new issue #4141, as this was mostly about the question of spawning and is already two years old, but I recently came upon the same problem. @ancientmarinerdev: You may be right that it may just be the tendency of villagers being suicidal. You have a better oversight over the code and the villager behavior.

If village life starts even when the player does not see the village and still has some distance between and they "live" out their full suicidal potential, it may result in "village death" when the player finally discovers the village.

It would be great if this could be improved! :-)

> It could be that they don't spawn, but if they are suicidal, then it wouldn't matter if they did spawn because they might not last long enough for you to find them. I created a new issue #4141, as this was mostly about the question of spawning and is already two years old, but I recently came upon the same problem. @ancientmarinerdev: You may be right that it may just be the tendency of villagers being suicidal. You have a better oversight over the code and the villager behavior. If village life starts even when the player does not see the village and still has some distance between and they "live" out their full suicidal potential, it may result in "village death" when the player finally discovers the village. It would be great if this could be improved! :-)
Laudrin commented 2024-01-14 15:50:02 +01:00
Copy Link

[…] I added some logging […]

@ancientmarinerdev: Is this something we could use, too, with some kind of setting or option in the MCL2 option page in Minetest options? It would be great to have some kind of way to see what the cause was for villagers disappearing, "ghost villages" and so on. Just to make sure it is not a bug but some "natural" cause.

Like a ravine or mobs the player has not already detected, but roam inside the village or beside the paths villagers take.

> […] I added some logging […] @ancientmarinerdev: Is this something we could use, too, with some kind of setting or option in the MCL2 option page in Minetest options? It would be great to have some kind of way to see what the cause was for villagers disappearing, "ghost villages" and so on. Just to make sure it is not a bug but some "natural" cause. Like a ravine or mobs the player has not already detected, but roam inside the village or beside the paths villagers take.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
upstream/unbreaking_on_crossbows
burning_in_thunder
mcl_mobs_cleanup
mcl_chests_redo
improve_planks
fix-has_room
opencollective-link
mob_ignore_fix
slabs_block_light
hardness_blast_res_fixes
buildable_flowers
redstone-update
add_shader_support
hammers_spears
EE_armor
mapgen_update
projectile-refactor
world_aligned_textures
zombie_texture_improvements
mcl_weathered_nodes
orb_of_exchange
fix_pumpkin_names
patch_skins
hollow_logs_ref_recovery
copper-adaptation-refs-recovery
add_asset_attributions_1
fix_pumpkin_typo_pumkin
cherry_grove
lush_caves
release/0.86.1
mobile_bow_workaround
release/0.85.1
optimize_jukebox_sounds
optimize_theme_ogg
Optimize_backgrounds_jpg
archaeology
spanish-translations
fish_bucket_nametag
villager-golem-fixes
fix_beetroot_fortune_drops
fix_sliding
illager_banner_description
release_0.83.1
skelly_horse_thunder
mobs_armor
mobsarmorfix
smoother_biome_borders
jukebox_sound_distance
cobble_abm_height
callable-tool-rightclick-functions
effects_rewrite
respiration
make-new-music-louder
damage
texture_conversion_wool
dehardcoded_signs
mcl_oxidization
Texture-Rename2
Bamboo-Piston-Dig
hardcore_mode_test
update_german_translation_attempt2
test_mob_tweaks_branch
csm-enabled
move_physics_tweak
water_footstep
biome_skycolor
bambootoo
lower_ow_mapgen
release/0.81.1
revert_chest_models
mcl-craftguide-drop-sfinv
mcl-structures-fixes
turtlestriderbeefox
arrow_node_collision
pvp_knockback
icebergs
light_dump
testing
mobs-redo
wood_api
mobs_head_rotation
bonemeal
dyable-leather-armor
new_mapgen_api
newmobs-master
formspec_overhaul
mobs
mapgen
mineclone5
chat-command-builder-2
formspec-v4
doc-refactoring
production
objects
0.87.2
0.87.1
0.87.0
0.86.2
0.86.1
0.86.0
0.85.0
0.84.0
0.83.1
0.83.0
0.82.0
0.81.1
0.81.0
0.80.1
0.80.0
0.79.0
0.78.0
0.77.0
0.76.0
0.75.0
0.74.0
0.73.1
0.73.0
0.72.1
0.72.0
0.71.0
0.70.0
0.69.1
0.69.0
0.68.0
0.67.2
0.67.1
0.67.0
0.66.2
0.66.1
0.66.0
0.65.2
0.65.1
0.65.0
0.64.0
0.63.0
0.62.0
0.61.0
0.60.0
0.59.2
0.59.1
0.59.0
0.58.1
0.58.0
0.57.1
0.57.0
0.56.2
0.56.1
0.56.0
0.55.1
0.55.0
0.54.1
0.54.0
0.53.4
0.53.3
0.53.2
0.53.1
0.53.0
0.52.1
0.52.0
0.51.1
0.51.0
0.50.2
0.50.1
0.50.0
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.0
0.45.1
0.45.0
0.44.0
0.43.0
0.42.0
0.21.0
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-Minecraft feature

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#2779
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?