Leaves, like grass, should change colour depending on the biome. #2683

New Issue

FossFanatic · 2022-09-27T20:34:06+02:00

FossFanatic commented

2022-09-27 20:34:06 +02:00

Currently, grass seems to change colour depending on which biome it is on, but the same cannot be said for leaves, or other plants for that matter.

Leaves should also change their colours depending on which biome they're located on. This will help give the biomes a more uniform and overall more beautiful look.

This colour change should also count for most other plants, like vines.

Currently, grass seems to change colour depending on which biome it is on, but the same cannot be said for leaves, or other plants for that matter. Leaves should also change their colours depending on which biome they're located on. This will help give the biomes a more uniform and overall more beautiful look. This colour change should also count for most other plants, like vines.

cora commented

2022-09-27 22:04:40 +02:00

it's just reeds / sugarcane and grass. Tallgrass and fern might work i suppose, leaves and vines are probably off the table (vines bc they use param2 which is used for the color for the orientation) and leaves because they get placed through schematics - i think going over them after the fact might be quite expensive.

I've made it for water before, only works for water source not flowing water though you can have a look in this commit if anyone wants to play around with this stuff - that's basically how it works: biome has a "palette index" number and the node definitions include a palette file - the number signifies which pixel from the palette to use as the color.

What about creepers though? I think we need chameleocreepers

it's just reeds / sugarcane and grass. Tallgrass and fern might work i suppose, leaves and vines are probably off the table (vines bc they use param2 which is used for the color for the orientation) and leaves because they get placed through schematics - i think going over them after the fact might be quite expensive. I've made it for water before, only works for water source not flowing water though you can have a look in this commit if anyone wants to play around with this stuff - that's basically how it works: biome has a "palette index" number and the node definitions include a palette file - the number signifies which pixel from the palette to use as the color. What about creepers though? I think we need chameleocreepers

😆 1

FossFanatic commented

2022-09-27 22:56:03 +02:00

leaves and vines are probably off the table (vines bc they use param2 which is used for the color for the orientation) and leaves because they get placed through schematics - i think going over them after the fact might be quite expensive.

What a shame. Hopefully one day the development team can get around fixing this seemingly easy but actually difficult issue.

But I guess "chameleon creepers" that blend in with the environment could make for a new type of danger. It doesn't seem very vanilla though, so it should probably be a mod that can be installed instead.

>leaves and vines are probably off the table (vines bc they use param2 which is used for the color for the orientation) and leaves because they get placed through schematics - i think going over them after the fact might be quite expensive. What a shame. Hopefully one day the development team can get around fixing this seemingly easy but actually difficult issue. But I guess "chameleon creepers" that blend in with the environment could make for a new type of danger. It doesn't seem very vanilla though, so it should probably be a mod that can be installed instead.

Ghost commented

2022-09-27 23:07:53 +02:00

Who cares about vanilla :)

😕 1

cora commented

2022-09-28 01:36:27 +02:00

b485364feb - here's the water thing only works with water sources though so also not ideal but it does kind of look nice - except at the interface between flowing and source water haha

But it shows how it works: the biomes have a "palette_index" property which is a number that correlates to a pixel in a palette which is used by the minetest paramtype2 "color" (which means param2 set's the color if you hadn't guessed)

https://git.minetest.land/MineClone2/MineClone2/commit/b485364febc55aec8bf0b49b98d634dd778cf61b - here's the water thing only works with water sources though so also not ideal but it does kind of look nice - except at the interface between flowing and source water haha But it shows how it works: the biomes have a "palette_index" property which is a number that correlates to a pixel in a palette which is used by the minetest paramtype2 "color" (which means param2 set's the color if you hadn't guessed)

cora referenced a pull request that will close this issue

2022-09-29 06:16:28 +02:00

Add biome color to more nodes #2687

cora commented

2022-09-29 06:17:10 +02:00

There everything you asked for except vines totally does work with leaves - forget what i said.

cora commented

2022-09-29 06:35:53 +02:00

and vines can maybe work as well using the "colorwallmounted" paramtype2 - the palette would be limited 32 but mcl_core_palette_grass only has 30 at the moment anyways

and vines can *maybe* work as well using the "colorwallmounted" paramtype2 - the palette would be limited 32 but mcl_core_palette_grass only has 30 at the moment anyways

FossFanatic commented

2022-10-01 19:14:17 +02:00

This sounds like great news.
So, it's only flowing water that is unable to change colours, and vines are limited in which colours they can use? What is the reason behind this?

This sounds like great news. So, it's only flowing water that is unable to change colours, and vines are limited in which colours they can use? What is the reason behind this?

FossFanatic closed this issue

2022-10-01 19:26:29 +02:00

FossFanatic reopened this issue

2022-10-01 19:26:38 +02:00

cora commented

2022-10-01 22:58:12 +02:00

as i said they use the same field for the orientation so only 5 bit remain ig https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L729

FossFanatic commented

2022-10-02 00:22:36 +02:00

So, does this mean that it's impossible to change the colour of flowing water? Or will a solution be found to this one day?

ancientmarinerdev added the

graphics

label 2023-02-02 21:55:37 +01:00

FossFanatic commented

2023-02-18 17:37:44 +01:00

I guess I should close this now, since biome coloured leaves have finally been added: MineClone2/MineClone2#3420.

It has been quite the journey to get this added.

I guess I should close this now, since biome coloured leaves have finally been added: https://git.minetest.land/MineClone2/MineClone2/pulls/3420. It has been quite the journey to get this added.

❤️ 1

FossFanatic closed this issue

2023-02-18 17:37:51 +01:00

Sign in to join this conversation.