Wither Skeleton Skull is kept in inventory if placed in survival #2416

Closed
opened 2022-07-12 15:55:08 +02:00 by 40W · 9 comments

title

title
Contributor

Sure you didn't do /gamemode creative? Because that seems quite strange

Sure you didn't do /gamemode creative? Because that seems quite strange
Contributor

Ill try it later though

Ill try it later though
MysticTempest added the
bug
label 2022-07-12 18:27:02 +02:00
Member

Yea, confirmed.

Yea, confirmed.
Contributor

This is gonna be fun to debug

This is gonna be fun to debug
Member

This is gonna be fun to debug

~~I've been taking a look; since earlier.
Seems to just be missing a "return itemstack"

From the following section:
https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/ENTITIES/mcl_wither_spawning/init.lua#L50~~

Edit: Nvm; weird, it worked in my first test world, but not in a new world...

Edit2: Wait, it does work, mostly; I was just dumb & had commented out my fix again.
Though it seems laggy; like it take a little to update when placing them down.

Edit3: Sorry, okay; now I see. It fixes most placement; like on the ground. But, it's still bugged if you place a head onto the front of another head.
Probably something to do with the mcl_heads "wall" code.

> This is gonna be fun to debug ~~I've been taking a look; since earlier. Seems to just be missing a "return itemstack" From the following section: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/ENTITIES/mcl_wither_spawning/init.lua#L50~~ Edit: Nvm; weird, it worked in my first test world, but not in a new world... Edit2: Wait, it does work, mostly; I was just dumb & had commented out my fix again. Though it seems laggy; like it take a little to update when placing them down. Edit3: Sorry, okay; now I see. It fixes most placement; like on the ground. But, it's still bugged if you place a head onto the front of another head. Probably something to do with the mcl_heads "wall" code.
Contributor

aw spoilers hehe

yeah sounds about right. might be best to have on_place immediately return old_on_place() when no soul sand below the head.

aw spoilers hehe yeah sounds about right. might be best to have on_place immediately return old_on_place() when no soul sand below the head.
Contributor

the unconditional minetest.after() is kinda sus tbh

the unconditional minetest.after() is kinda sus tbh
Contributor

just adding return in front of the old_on_place call fixes it though

i still kinda wanna protect that mt.after

just adding return in front of the old_on_place call fixes it though i still kinda wanna protect that mt.after
cora closed this issue 2022-07-13 00:51:07 +02:00
Contributor

fixed by merge of #2417

fixed by merge of #2417
cora added the
items
#P3: elevated
labels 2022-07-13 00:52:23 +02:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#2416
No description provided.