Maps and Compasses having a far bigger performance impact than reasonable #1213

New Issue

LizzyFleckenstein03 · 2021-02-27T15:38:14+01:00

2021-02-27 15:38:14 +01:00

When looking at some profiling output from my server, the mods with the biggest average performance impact were mobs_mc (24.3%); ?? (28.9%) - i'm mostly sure this one is mcl_mobs because it contains lots of on_step, get_staticdata etc. but fore some reason it does not show that name in profiler, and the weird thing is that mcl_mobs shows up later with 0.1%, which is very unrealistic, it's probably caused by some overrides; mcl_compass (22.4%) and mcl_maps (7.3%). Mobs consuming performance is perfectly fine; but why would something simple as Compasses and Maps take that much (both in a globalstep)? It does not make sense to me, some checking needs to be done. My guess would be that they call other functions that are very performance critical. There is no other explination for compasses taking up almost as much performance as the mob engine or the mobs mod.

Or, similar to mcl_mobs, its called by weird mod interactions and overrides that the profiler can't handle properly.

When looking at some profiling output from my server, the mods with the biggest average performance impact were mobs_mc (24.3%); ?? (28.9%) - i'm mostly sure this one is mcl_mobs because it contains lots of on_step, get_staticdata etc. but fore some reason it does not show that name in profiler, and the weird thing is that mcl_mobs shows up later with 0.1%, which is very unrealistic, it's probably caused by some overrides; mcl_compass (22.4%) and mcl_maps (7.3%). Mobs consuming performance is perfectly fine; but why would something simple as Compasses and Maps take that much (both in a globalstep)? It does not make sense to me, some checking needs to be done. My guess would be that they call other functions that are very performance critical. There is no other explination for compasses taking up almost as much performance as the mob engine or the mobs mod. Or, similar to mcl_mobs, its called by weird mod interactions and overrides that the profiler can't handle properly.

LizzyFleckenstein03 added the

bug

performance

labels 2021-02-27 15:38:27 +01:00

LizzyFleckenstein03 self-assigned this 2021-02-27 15:38:35 +01:00

LizzyFleckenstein03 commented

2021-02-27 19:51:03 +01:00

Created a branch #compass-debug for temporary performance debugging. Do not merge it or use it on your servers, it's just in case someone is interested in helping to fix the problem. (It contains debugging code that should not actually be used in "production")

👍 3

AFCMS commented

2021-03-01 10:25:30 +01:00

Created a branch #compass-debug for temporary performance debugging. Do not merge it or use it on your servers, it's just in case someone is interested in helping to fix the problem. (It contains debugging code that should not actually be used in "production")

What about adding a setting to disable these features for now?
The impact on gameplay is realy too big.

> Created a branch #compass-debug for temporary performance debugging. Do not merge it or use it on your servers, it's just in case someone is interested in helping to fix the problem. (It contains debugging code that should not actually be used in "production") What about adding a setting to disable these features for now? The impact on gameplay is realy too big.

LizzyFleckenstein03 removed their assignment 2021-11-13 18:21:55 +01:00

Sign in to join this conversation.