WIP mcl_torchlighter #45

SmokeyDope · 2023-09-19T03:52:02+02:00

SmokeyDope commented

2023-09-19 03:52:02 +02:00

This is a mostly complete mod that adds the ability for torches to be placed by right-clicking with a pickaxe on a node. I don't know when I will get enough drive to finish it off. I figured I would upload it here and maybe someone else can fix up the last two issues.

Things that still need done:

- Currently torches will place even if none are in inventory. Make local 'success' depend on if player has torches in inventory, maybe with variables 'torch_stack' or 'torch_stack_id'
- I ran into a really wierd issue where trying to call 'player' in a function like

examplefunction(player, itemstack, ect)

results in a nil value. I tried everything to get it to call right but it won't and I don't understand right. As a workaround I manually set player = 'singleplayer' which does work but obviously not for multiplayer games. This is the real problem, the wall I hit and could not overcome. Im sure one of you more experienced programmers will spot my mistake right away and tell me how it was so easy to fix.

This is a mostly complete mod that adds the ability for torches to be placed by right-clicking with a pickaxe on a node. I don't know when I will get enough drive to finish it off. I figured I would upload it here and maybe someone else can fix up the last two issues. Things that still need done: - [ ] - Currently torches will place even if none are in inventory. Make local 'success' depend on if player has torches in inventory, maybe with variables 'torch_stack' or 'torch_stack_id' - [ ] - I ran into a really wierd issue where trying to call 'player' in a function like ``` examplefunction(player, itemstack, ect) ``` results in a nil value. I tried everything to get it to call right but it won't and I don't understand right. As a workaround I manually set player = 'singleplayer' which does work but obviously not for multiplayer games. This is the real problem, the wall I hit and could not overcome. Im sure one of you more experienced programmers will spot my mistake right away and tell me how it was so easy to fix.

SmokeyDope added 1 commit 2023-09-19 03:52:04 +02:00

a1764aa49a mcl_torchlighter initial upload

Michieal commented

2023-09-25 01:04:17 +02:00

There should be a placer in the on_place parameters that would return the player, if the player is placing the object.

maybe check to see if that is not nil?

There should be a `placer` in the `on_place` parameters that would return the player, if the player is placing the object. maybe check to see if that is not nil?

SmokeyDope closed this pull request

2024-01-03 19:15:39 +01:00

Michieal commented

2024-01-05 08:26:37 +01:00

Oh, uhm... look at the Sprint code or the FOVAPI code for how to get player...

Oh, uhm... look at the Sprint code or the FOVAPI code for how to get `player`...

SmokeyDope commented

2024-01-05 15:37:00 +01:00

I recently saw a commit for a nil check which sounds like it may be what could be needed. Ill check out what you suggested in a bit

I recently saw a [commit](https://git.minetest.land/MineClone2/MineClone2/commit/2f8389d3f52c18304976987d018bf5d5304d5de9) for a nil check which sounds like it may be what could be needed. Ill check out what you suggested in a bit

Michieal commented

2024-01-06 01:57:52 +01:00

Okay. let me know what you find out.