Include mcl_cozy #36

New Issue

rudzik8 · 2023-04-16T02:56:50+02:00

rudzik8 commented

2023-04-16 02:56:50 +02:00

It's already in the MineClone2 org, and works fine. Adds /sit and /lay commands, which are useful for multiplayer, and maybe even for some photosets in singleplayer :D

MineClone2/mcl_cozy

What do you think?

It's already in the MineClone2 org, and works fine. Adds /sit and /lay commands, which are useful for multiplayer, and maybe even for some photosets in singleplayer :D [MineClone2/mcl_cozy](https://git.minetest.land/MineClone2/mcl_cozy) ![ContentDB Screenshot](https://content.minetest.net/uploads/d80f36718f.png) What do you think?

👍 4 ❤️ 3

kneekoo commented

2023-04-16 02:59:28 +02:00

Honestly, I'd like this in MineClone2 as well. :) I see no reason not to have it, it doesn't break the gameplay.

Ghost commented

2023-04-23 17:52:50 +02:00

@rudzik8 make a PR to add it, and I will get it in.

rudzik8 commented

2023-04-24 04:22:17 +02:00

@rudzik8 make a PR to add it, and I will get it in.

I'll make a PR after the French translation for mcl_cozy is released (I've merged it, but I can't release it because of org permission stuff).

BTW, I wonder if we could keep mcl_cozy as a standalone mod on ContentDB (mainly for servers). maybe it could be included here as a git submodule even?

> @rudzik8 make a PR to add it, and I will get it in. I'll make a PR after the French translation for mcl_cozy is released (I've merged it, but I can't release it because of org permission stuff). BTW, I wonder if we could keep mcl_cozy as a standalone mod on ContentDB (mainly for servers). maybe it could be included here as a git submodule even?

Ghost commented

2023-04-24 17:27:18 +02:00

Hey, all of the mods I personally have in this modpack are also standalone mods. Perfectly fine with me.

Michieal commented

2023-10-18 03:31:46 +02:00

BTW, I wonder if we could keep mcl_cozy as a standalone mod on ContentDB (mainly for servers).

I don't see an issue with it being both places. Smokey's mods are up on CDB. Thinking Longer-Term for this and for minetest usage, I would suggest that on the individual mods, that a note be added that it's also in this mod-pack, so that players don't try to have both installed in their game.

maybe it could be included here as a git submodule even?

I personally, would prefer that it be included as a PR, as that prevents non-inclusion issues when downloading it in its zipped form.

> BTW, I wonder if we could keep mcl_cozy as a standalone mod on ContentDB (mainly for servers). I don't see an issue with it being both places. Smokey's mods are up on CDB. Thinking Longer-Term for this and for minetest usage, I would suggest that on the individual mods, that a note be added that it's also in this mod-pack, so that players don't try to have both installed in their game. > maybe it could be included here as a git submodule even? I personally, would prefer that it be included as a PR, as that prevents non-inclusion issues when downloading it in its zipped form.

erlehmann commented

2023-10-18 04:25:47 +02:00

maybe it could be included here as a git submodule even?

I personally, would prefer that it be included as a PR, as that prevents non-inclusion issues when downloading it in its zipped form.

I suggest to try git subtree then.

> > maybe it could be included here as a git submodule even? > > I personally, would prefer that it be included as a PR, as that prevents non-inclusion issues when downloading it in its zipped form. I suggest to try git subtree then.

Sign in to join this conversation.