From 8fff20eec9f1045c9d16d2a4cdb79c989d627966 Mon Sep 17 00:00:00 2001
From: AFCMS <afcm.contact@gmail.com>
Date: Wed, 14 Jul 2021 15:18:12 +0200
Subject: [PATCH] fix misleading API

---
 mods/ITEMS/mcl_buckets/init.lua     | 12 ++++++------
 mods/ITEMS/mcl_buckets/register.lua |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/mods/ITEMS/mcl_buckets/init.lua b/mods/ITEMS/mcl_buckets/init.lua
index 312669c5ef..17d3334852 100644
--- a/mods/ITEMS/mcl_buckets/init.lua
+++ b/mods/ITEMS/mcl_buckets/init.lua
@@ -153,7 +153,7 @@ function mcl_buckets.register_liquid(def)
 			source_place = def.source_place,
 			source_take = source,
 			on_take = def.on_take,
-			itemname = def.itemname,
+			bucketname = def.bucketname,
 		}
 		pointable_sources[source] = true
 		if type(def.source_place) == "string" then
@@ -161,11 +161,11 @@ function mcl_buckets.register_liquid(def)
 		end
 	end
 
-	if def.itemname == nil or def.itemname == "" then
+	if def.bucketname == nil or def.bucketname == "" then
 		error(string.format("[mcl_bucket] Invalid itemname then registering [%s]!", def.name))
 	end
 
-	minetest.register_craftitem(def.itemname, {
+	minetest.register_craftitem(def.bucketname, {
 		description = def.name,
 		_doc_items_longdesc = def.longdesc,
 		_doc_items_usagehelp = def.usagehelp,
@@ -289,7 +289,7 @@ minetest.register_craftitem("mcl_buckets:bucket_empty", {
 					-- FIXME: remove this line
 					--if not minetest.is_creative_enabled(user:get_player_name()) then
 					if not false then
-						new_bucket = ItemStack({name = liquid_def.itemname})
+						new_bucket = ItemStack({name = liquid_def.bucketname})
 						if liquid_def.on_take then
 							liquid_def.on_take(user)
 						end
@@ -337,9 +337,9 @@ minetest.register_craftitem("mcl_buckets:bucket_empty", {
 
 		local liquiddef = mcl_buckets.liquids[dropnode.name]
 		local new_bucket
-		if liquiddef and liquiddef.itemname and (dropnode.name  == liquiddef.source_take) then
+		if liquiddef and liquiddef.bucketname and (dropnode.name  == liquiddef.source_take) then
 			-- Fill bucket
-			new_bucket = ItemStack({name = liquiddef.itemname})
+			new_bucket = ItemStack({name = liquiddef.bucketname})
 			sound_take(dropnode.name, droppos)
 			collect_liquid = true
 		end
diff --git a/mods/ITEMS/mcl_buckets/register.lua b/mods/ITEMS/mcl_buckets/register.lua
index 97349533e3..1a7c8fe141 100644
--- a/mods/ITEMS/mcl_buckets/register.lua
+++ b/mods/ITEMS/mcl_buckets/register.lua
@@ -34,7 +34,7 @@ if mod_mcl_core then
                 awards.unlock(user:get_player_name(), "mcl:hotStuff")
             end
         end,
-		itemname = "mcl_buckets:bucket_lava",
+		bucketname = "mcl_buckets:bucket_lava",
 		inventory_image = "bucket_lava.png",
 		name = S("Lava Bucket"),
 		longdesc = S("A bucket can be used to collect and release liquids. This one is filled with hot lava, safely contained inside. Use with caution."),
@@ -46,7 +46,7 @@ if mod_mcl_core then
 	mcl_buckets.register_liquid({
 		source_place = "mcl_core:water_source",
 		source_take = {"mcl_core:water_source"},
-		itemname = "mcl_buckets:bucket_water",
+		bucketname = "mcl_buckets:bucket_water",
 		inventory_image = "bucket_water.png",
 		name = S("Water Bucket"),
 		longdesc = S("A bucket can be used to collect and release liquids. This one is filled with water."),
@@ -80,7 +80,7 @@ if mod_mclx_core then
 	mcl_buckets.register_liquid({
 		source_place = "mclx_core:river_water_source",
 		source_take = {"mclx_core:river_water_source"},
-		itemname = "mcl_buckets:bucket_river_water",
+		bucketname = "mcl_buckets:bucket_river_water",
 		inventory_image = "bucket_river_water.png",
 		name = S("River Water Bucket"),
 		longdesc = S("A bucket can be used to collect and release liquids. This one is filled with river water."),