Crash on putting item that is not meshnode glue in meshnode controller #3

New Issue

erlehmann · 2021-08-20T20:18:18+02:00

erlehmann commented

2021-08-20 20:18:18 +02:00

How to reproduce

Swap the meshnode glue from a meshnode controller with another item
Observe crash

##### How to reproduce 1. Swap the meshnode glue from a meshnode controller with another item 2. Observe crash

erlehmann commented

2021-08-20 20:19:02 +02:00

Fix:

diff --git a/init.lua b/init.lua
index d20dcec..199319e 100644
--- a/init.lua
+++ b/init.lua
@@ -356,6 +368,9 @@ minetest.register_node("meshnode:controller", {
                show_meshnode_formspec(pos, clicker)
        end,
        allow_metadata_inventory_put = function(pos, listname, index, stack, player)
+               if stack:get_name() ~= "meshnode:glue" then
+                       return 0
+               end
                local meta = stack:get_metadata()
                if meta then
                        if vector.equals(minetest.string_to_pos(meta), pos) then

Fix: ``` diff --git a/init.lua b/init.lua index d20dcec..199319e 100644 --- a/init.lua +++ b/init.lua @@ -356,6 +368,9 @@ minetest.register_node("meshnode:controller", { show_meshnode_formspec(pos, clicker) end, allow_metadata_inventory_put = function(pos, listname, index, stack, player) + if stack:get_name() ~= "meshnode:glue" then + return 0 + end local meta = stack:get_metadata() if meta then if vector.equals(minetest.string_to_pos(meta), pos) then ```

erlehmann referenced this issue

2021-08-26 01:42:48 +02:00

Allow only meshnode glue in controller inventory #9

cora commented

2021-08-26 02:07:40 +02:00

fixed by #9

cora closed this issue

2021-08-26 02:07:41 +02:00

Sign in to join this conversation.