Mod should work with MineClone2-derived games #1

New Issue

erlehmann · 2021-08-20T18:39:52+02:00

erlehmann commented

2021-08-20 18:39:52 +02:00

How to reproduce

Create a new world with Mineclonia
Activate the meshnode mod
Start the game
Verify that you get the following error message:
- “mod "meshnode" has unatisfied dependencies: "default"”

##### How to reproduce 1. Create a new world with Mineclonia 2. Activate the meshnode mod 3. Start the game 4. Verify that you get the following error message: * “mod "meshnode" has unatisfied dependencies: "default"”

erlehmann changed title from ~~Mod depends on default mod, should depend on mcl* mods instead~~ to Mod depends on default mod, should depend on mcl_player instead

2021-08-20 18:40:50 +02:00

erlehmann changed title from ~~Mod depends on default mod, should depend on mcl_player instead~~ to Mod depends on “default”, should depend on “mcl_player”

2021-08-20 18:41:23 +02:00

erlehmann commented

2021-08-20 18:59:33 +02:00

Fix:

diff --git a/depends.txt b/depends.txt
index 671375a..5861976 100644
--- a/depends.txt
+++ b/depends.txt
@@ -1,3 +1,3 @@
-default
+mcl_player
 wordedit?
 intllib?

Fix: ``` diff --git a/depends.txt b/depends.txt index 671375a..5861976 100644 --- a/depends.txt +++ b/depends.txt @@ -1,3 +1,3 @@ -default +mcl_player wordedit? intllib? ```

erlehmann commented

2021-08-20 19:05:06 +02:00

Fix:

diff --git a/init.lua b/init.lua
index d20dcec..199319e 100644
--- a/init.lua
+++ b/init.lua
@@ -6,6 +6,10 @@ end
 
 dofile(minetest.get_modpath(minetest.get_current_modname()).."/api.lua")
 
+default = {}
+default.player_attached = mcl_player.player_attached
+default.player_set_animation = mcl_player.player_set_animation
+
 local ctrl_groups = {choppy=2, oddly_breakable_by_hand=2}
 local has_worldedit = minetest.global_exists("worldedit")
 local is_singleplayer = minetest.is_singleplayer()

Fix: ``` diff --git a/init.lua b/init.lua index d20dcec..199319e 100644 --- a/init.lua +++ b/init.lua @@ -6,6 +6,10 @@ end dofile(minetest.get_modpath(minetest.get_current_modname()).."/api.lua") +default = {} +default.player_attached = mcl_player.player_attached +default.player_set_animation = mcl_player.player_set_animation + local ctrl_groups = {choppy=2, oddly_breakable_by_hand=2} local has_worldedit = minetest.global_exists("worldedit") local is_singleplayer = minetest.is_singleplayer() ```

erlehmann changed title from ~~Mod depends on “default”, should depend on “mcl_player”~~ to Mod should work with MineClone2-derived games

2021-08-30 01:55:13 +02:00

erlehmann commented

2021-08-30 01:55:27 +02:00

Fixed with merge of PR #10 (mostly).

Fixed with merge of PR https://git.minetest.land/Mineclonia/mcl_meshnode/pulls/10 (mostly).

erlehmann closed this issue

2021-08-30 01:55:28 +02:00

Sign in to join this conversation.