Pumpkins grow and generate with faces, even though faceless pumpkins and carving them are both fully implemented #94

New Issue

erlehmann · 2021-06-19T07:28:38+02:00

erlehmann commented

2021-06-19 07:28:38 +02:00

Problem

Pumpkins created by the map generator and grow from seeds have faces.

This is a bit weird and different from Minecraft.

https://minecraft.fandom.com/wiki/Pumpkin

Solution

I would like pumpkins to generate without faces.

Faceless pumpkins are accessible in creative mode and seem to work.

The logic to make pumpkin with faces using shears also already exists in the game.

##### Problem Pumpkins created by the map generator and grow from seeds have faces. This is a bit weird and different from Minecraft. https://minecraft.fandom.com/wiki/Pumpkin ##### Solution I would like pumpkins to generate without faces. Faceless pumpkins are accessible in creative mode and seem to work. The logic to make pumpkin with faces using shears also already exists in the game.

erlehmann commented

2021-06-19 07:30:04 +02:00

Pumpkins should generate without faces if the string pumpkin_face is replaced with pumpkin in these files:

mods/MAPGEN/mcl_mapgen_core/init.lua
mods/MAPGEN/mcl_biomes/init.lua

Pumpkins should generate without faces if the string `pumpkin_face` is replaced with `pumpkin` in these files: * mods/MAPGEN/mcl_mapgen_core/init.lua * mods/MAPGEN/mcl_biomes/init.lua

erlehmann commented

2021-06-19 07:51:17 +02:00

In MineClone2/MineClone2#682 anon5 says:

It seems some crafting recipes would also need to be changed.

Pumpkin pie comes to mind.

In https://git.minetest.land/MineClone2/MineClone2/issues/682 anon5 says: > It seems some crafting recipes would also need to be changed. Pumpkin pie comes to mind.

erlehmann commented

2021-06-19 07:52:02 +02:00

More evidence that people are surprised by pumpkins with faces: MineClone2/MineClone2#797

More evidence that people are surprised by pumpkins with faces: https://git.minetest.land/MineClone2/MineClone2/issues/797

erlehmann commented

2021-06-19 07:53:08 +02:00

See also https://git.minetest.land/Athemis/MineClone2/src/branch/pumpkins

erlehmann commented

2021-06-19 07:55:26 +02:00

@Wuzzy has rejected a patch to generate and grow faceless pumpkins MineClone2/MineClone2#684 before – for reasons:

I have to reject this because if you shear a pumpkin, the upper face rotates. This is the reason why I did not implement this because of this bug.

@Wuzzy has rejected a patch to generate and grow faceless pumpkins https://git.minetest.land/MineClone2/MineClone2/pulls/684 before – for reasons: > I have to reject this because if you shear a pumpkin, the upper face rotates. This is the reason why I did not implement this because of this bug.

erlehmann changed title from ~~MAPGEN/mcl_mapgen_core & MAPGEN/mcl_biomes: Pumpkins generate with faces~~ to Pumpkins grow and generate with faces, even though faceless pumpkins and carving them is fully implemented

2021-06-19 07:58:02 +02:00

erlehmann changed title from ~~Pumpkins grow and generate with faces, even though faceless pumpkins and carving them is fully implemented~~ to Pumpkins grow and generate with faces, even though faceless pumpkins and carving them are both fully implemented

2021-06-19 07:58:21 +02:00

erlehmann commented

2021-06-19 07:59:22 +02:00

I found another duped pumpkin issue: MineClone2/MineClone2#1666

I found another duped pumpkin issue: https://git.minetest.land/MineClone2/MineClone2/issues/1666

erlehmann commented

2021-06-19 15:36:09 +02:00

Wuzzy told me that the rotation thing was really the only issue.

My counter-argument is that unless you want to define a different top texture rotation for each of the four face directions, making a face on the side where you apply the shears actually implies rotating the top texture in 3 out of 4 cases. In my opinion, gameplay trumps aesthetics here by, like, a lot.

Wuzzy told me that the rotation thing was really the only issue. My counter-argument is that unless you want to define a different top texture rotation for each of the four face directions, making a face on the side where you apply the shears actually implies rotating the top texture in 3 out of 4 cases. In my opinion, gameplay trumps aesthetics here by, like, a lot.

basxto commented

2021-07-01 11:50:11 +02:00

This is a bit weird and different from Minecraft.

That's not true, at least if the target is still Minecraft 1.12

1.13 renamed pumpkins to carved pumpkins and added a new blank pumpkin, which can be sheared into the old one.

> This is a bit weird and different from Minecraft. That's not true, at least if the target is still Minecraft 1.12 1.13 renamed pumpkins to carved pumpkins and added a new blank pumpkin, which can be sheared into the old one.

erlehmann referenced this issue

2021-07-31 01:25:40 +02:00

WIP: ITEMS/mcl_farming: Use uncarved pumpkin in survival #133

erlehmann commented

2021-07-31 12:39:44 +02:00

I have started a PR to use uncarved pumpkins in survival mode: #133

I have started a PR to use uncarved pumpkins in survival mode: https://git.minetest.land/Mineclonia/Mineclonia/pulls/133

erlehmann referenced this issue

2021-07-31 20:50:37 +02:00

WIP: ITEMS/mcl_farming: Use uncarved pumpkin in survival #134

erlehmann commented

2021-07-31 21:06:58 +02:00