Hollow logs fixes #4268

the-real-herowl · 2024-04-30T02:26:35+02:00

the-real-herowl commented

2024-04-30 02:26:35 +02:00

Doing a few fixes to the hollow logs before final merging, squashed #4267 into an intermediate branch.

Testing

Try crafting and placing some of the hollow logs, verify that you can jump into such a log, verify that you can use stonecutter to craft them, verify that they all look good in the creative menu.

Doing a few fixes to the hollow logs before final merging, squashed #4267 into an intermediate branch. ### Testing Try crafting and placing some of the hollow logs, verify that you can jump into such a log, verify that you can use stonecutter to craft them, verify that they all look good in the creative menu.

the-real-herowl added this to the 0.87.0 - Prismatic milestone 2024-04-30 02:26:35 +02:00

the-real-herowl added the

nodes

code quality

labels 2024-04-30 02:26:35 +02:00

the-real-herowl added 1 commit 2024-04-30 02:26:37 +02:00

1161d5cd36 Hollow logs (#4267 )

Reviewed-on: MineClone2/MineClone2#4267
Co-authored-by: JoseDouglas26 <josedouglas20002014@gmail.com>
Co-committed-by: JoseDouglas26 <josedouglas20002014@gmail.com>

the-real-herowl changed title from ~~Hollow logs fixes~~ to WIP: Hollow logs fixes

2024-04-30 02:26:42 +02:00

the-real-herowl added 4 commits 2024-04-30 03:54:06 +02:00

7ad4ca2dbe Spaces to tabs

9f65c5efb7 New hollow log model (optimized + UV map improved)

e0aadc7996 Updated the textures to the new UV map

Also added explicit use_texture_alpha = "clip"

ee2998e21b Replaced early returns with error calls

the-real-herowl changed title from ~~WIP: Hollow logs fixes~~ to Hollow logs fixes

2024-04-30 03:54:13 +02:00

the-real-herowl added the

Testing / Retest

label 2024-04-30 03:54:34 +02:00

the-real-herowl added 1 commit 2024-04-30 03:55:39 +02:00

a25e2b8eb3 Spaces to tabs

teknomunk reviewed 2024-04-30 05:28:48 +02:00

mods/ITEMS/vl_hollow_logs/init.lua Outdated

					
				@ -0,0 +19,4 @@

								error("Invalid arg #".. tostring(i))

							end

						end

					end

teknomunk commented

2024-04-30 05:28:48 +02:00

Since #defs must be at least 4 here, I think this would look cleaner if this was something like this:

for i = 1,4 do
    if type(defs[i]) ~= "string" then
        error("def["..tostring(i).."] must be string")
    end
end

if defs[5] and type(defs[5]) ~= "boolean" then
    error("Expected def[5] to be boolean or not present")
end

Since #defs must be at least 4 here, I think this would look cleaner if this was something like this: ```` for i = 1,4 do if type(defs[i]) ~= "string" then error("def["..tostring(i).."] must be string") end end if defs[5] and type(defs[5]) ~= "boolean" then error("Expected def[5] to be boolean or not present") end ````

the-real-herowl commented

2024-05-01 21:42:33 +02:00

You're right

the-real-herowl marked this conversation as resolved

the-real-herowl added 2 commits 2024-05-01 22:00:33 +02:00

b9428e3438 Definition validation improved

cc1e01ad78 Made API actually work for outside the mod

teknomunk commented

2024-05-03 23:46:10 +02:00

Looks to work to me.

the-real-herowl removed the

Testing / Retest