fix mcl_beds: ignore players in other dimensions than overwold #4257

nixnoxus · 2024-04-21T22:41:40+02:00

nixnoxus commented

2024-04-21 22:41:40 +02:00

MineClone2/MineClone2#4185 + bugfix

beds ignore players in other dimensions than "overworld" (because players can only sleep in the "overworld")

see also: https://minecraft.fandom.com/wiki/Bed#Passing_the_night

To skip the night in multiplayer, all players in the Overworld must be in bed at the same time

Testing

player1 lies down -> formspec: 1/1 players
a new player2 joins the game in the "overworld" -> formspec update: 1/2 players
player2 player goes through a portal into the nether -> formspec update: 1/1 players, night skipped, player1 is kicked out of bed
.. the day goes by ..
player1 lies down -> formspec: 1/1 players
player2 comes back from the nether -> formspec update 1/2 players
player2 lies down -> formspec update: 2/2 players, night skipped, player1 and player2 are kicked out of bed

https://git.minetest.land/MineClone2/MineClone2/pulls/4185 + bugfix beds ignore players in other dimensions than "overworld" (because players can only sleep in the "overworld") see also: https://minecraft.fandom.com/wiki/Bed#Passing_the_night > To skip the night in multiplayer, all players in the Overworld must be in bed at the same time ### Testing - player1 lies down -> formspec: 1/1 players - a new player2 joins the game in the "overworld" -> formspec update: 1/2 players - player2 player goes through a portal into the nether -> formspec update: 1/1 players, night skipped, player1 is kicked out of bed - .. the day goes by .. - player1 lies down -> formspec: 1/1 players - player2 comes back from the nether -> formspec update 1/2 players - player2 lies down -> formspec update: 2/2 players, night skipped, player1 and player2 are kicked out of bed

nixnoxus added 3 commits 2024-04-21 22:41:42 +02:00

2848156e3a beds ignore players in other dimensions

a0024b1884 use `pairs()`, not `ipairs()`

a0db231709 bugfix: use `player_in_bed` instead `check_in_beds()`

nixnoxus referenced this pull request

2024-04-21 22:43:08 +02:00

Beds only check players in the overworld to skip the night #4185

Ghost commented

2024-04-27 14:43:25 +02:00

First-time contributor

What to do with this PR?

the-real-herowl added the