VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
56
133
Fork 173
Code Issues 934 Pull Requests 74 Projects 4 Releases Wiki Activity

Fix crash with ghast achievement fireball_redir_serv #4179

Merged
the-real-herowl merged 1 commits from Araca/MineClone2:master into ghast_fixes 2024-05-02 00:15:58 +02:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
Araca commented 2024-02-04 21:47:47 +01:00
Contributor
Copy Link

My server crash a lot since I updated yesterday into master branch.

Logs

2024-02-04 16:56:38: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback luaentity_Step(): .../bin/../games/mineclone2/mods/ENTITIES/mobs_mc/ghast.lua:136: attempt to index field '_puncher' (a nil value)
2024-02-04 16:56:38: ERROR[Main]: stack traceback:
2024-02-04 16:56:38: ERROR[Main]:       .../bin/../games/mineclone2/mods/ENTITIES/mobs_mc/ghast.lua:136: in function 'hit_mob'
2024-02-04 16:56:38: ERROR[Main]:       .../bin/../games/mineclone2/mods/ENTITIES/mcl_mobs/init.lua:464: in function 'on_step_old'
2024-02-04 16:56:38: ERROR[Main]:       ...mes/mineclone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:24: in function <...mes/mineclone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:23>

self._puncher is nil

My guess on "Why", is that a ghast was spawn before I updated the server and as a consequence, it doesn't have the new attribute _puncher

My server crash a lot since I updated yesterday into master branch. Logs ``` 2024-02-04 16:56:38: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback luaentity_Step(): .../bin/../games/mineclone2/mods/ENTITIES/mobs_mc/ghast.lua:136: attempt to index field '_puncher' (a nil value) 2024-02-04 16:56:38: ERROR[Main]: stack traceback: 2024-02-04 16:56:38: ERROR[Main]: .../bin/../games/mineclone2/mods/ENTITIES/mobs_mc/ghast.lua:136: in function 'hit_mob' 2024-02-04 16:56:38: ERROR[Main]: .../bin/../games/mineclone2/mods/ENTITIES/mcl_mobs/init.lua:464: in function 'on_step_old' 2024-02-04 16:56:38: ERROR[Main]: ...mes/mineclone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:24: in function <...mes/mineclone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:23> ``` self._puncher is `nil` My guess on "Why", is that a ghast was spawn before I updated the server and as a consequence, it doesn't have the new attribute `_puncher`
the-real-herowl commented 2024-02-04 22:12:34 +01:00
Owner
Copy Link

This is not guaranteed to work because of operator associativity (and is to or like × is to +). Also now that I looked at the code again, it seems there may be more problems than just this...

This is not guaranteed to work because of operator associativity (and is to or like × is to +). Also now that I looked at the code again, it seems there may be more problems than just this...
Araca reviewed 2024-02-04 22:15:58 +01:00
mods/ENTITIES/mobs_mc/ghast.lua Outdated
@ -133,3 +133,3 @@
mcl_mobs.mob_class.boom(self,self.object:get_pos(), 1, true)
local ent = mob:get_luaentity()
if not ent or ent.health <= 0 then
if not ent or ent.health <= 0 and self._puncher then
Araca commented 2024-02-04 22:15:58 +01:00
Author
Contributor
Copy Link

Damned you are right, I was to fast.

This should work : if (not ent or ent.health <= 0) and self._puncher then

Damned you are right, I was to fast. This should work : `if (not ent or ent.health <= 0) and self._puncher then`
Araca force-pushed master from 82f37daef2 to eb8b5cc5da 2024-02-04 22:22:48 +01:00 Compare
Araca force-pushed master from eb8b5cc5da to c791622d60 2024-02-08 07:07:21 +01:00 Compare
the-real-herowl added the
#P1 CRITICAL
 label 2024-03-07 21:14:25 +01:00
the-real-herowl added the
#Review
 label 2024-04-29 18:23:07 +02:00
the-real-herowl added this to the 0.87.0 - Prismatic milestone 2024-04-29 18:23:17 +02:00
rudzik8 approved these changes 2024-04-30 16:12:04 +02:00
rudzik8 left a comment
Member
Copy Link

No issues found, pretty straight-forward fix.

No issues found, pretty straight-forward fix.
the-real-herowl changed title from Fix crash with ghast achievement fireball_redir_serv to Fix crash with ghast achievement fireball_redir_serv 2024-05-02 00:14:46 +02:00
the-real-herowl changed target branch from master to ghast_fixes 2024-05-02 00:14:47 +02:00
the-real-herowl removed the
#Review
 label 2024-05-02 00:14:56 +02:00
the-real-herowl merged commit cd0509c2e6 into ghast_fixes 2024-05-02 00:15:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
rudzik8
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-Minecraft feature

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
0.87.0 - Prismatic
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#4179
No description provided.
Delete Branch "Araca/MineClone2:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?