Show elytra animation when using elytra #4108

MrRar · 2023-12-29T19:25:04+01:00

MrRar commented

2023-12-29 19:25:04 +01:00

Background

Before e1d5899aa5 (diff-5b1214c31d429c4988c8268df3a9b655e576e123) the elytra animation was shown but the player model was upside down. I think this commit causes the load order of mcl_player_plus and mcl_player to change. These two mods are both trying to set the player animation when elytra is in use. The mod who's global_step gets called last will win. This is determined by mod load order.

I think mcl_playerplus functionality should be moved to mcl_player. It's dumb to have two mods doing the same thing.

What this PR does

Stop mcl_player from setting the player animation when elytra is in use.
Flip the player when using elytra so the player is the right side up.

# Background Before https://git.minetest.land/MineClone2/MineClone2/commit/e1d5899aa53337dcaf0354614910ea6b2070635b#diff-5b1214c31d429c4988c8268df3a9b655e576e123 the elytra animation was shown but the player model was upside down. I think this commit causes the load order of mcl_player_plus and mcl_player to change. These two mods are both trying to set the player animation when elytra is in use. The mod who's global_step gets called last will win. This is determined by mod load order. I think mcl_playerplus functionality should be moved to mcl_player. It's dumb to have two mods doing the same thing. # What this PR does - Stop mcl_player from setting the player animation when elytra is in use. - Flip the player when using elytra so the player is the right side up.

❤️ 1

MrRar force-pushed elytra from 1a53c66fc2 to 9b9a18c6b0

2024-01-11 20:46:11 +01:00

Compare

MrRar changed title from ~~WIP:Show elytra animation when using elytra~~ to Show elytra animation when using elytra

2024-01-11 20:47:28 +01:00

MrRar commented

2024-01-11 20:47:42 +01:00

Ready for review

❤️ 1

the-real-herowl added the

graphics