Finish PVP Combat Parity with the rest + PVP Tweaks #4078

Eliy21 · 2023-12-13T18:20:52+01:00

Eliy21 commented

2023-12-13 18:20:52 +01:00

Add missing pvp attack reach limit
Add minimum pvp knockbacks for non-enchant weapons and fists
Nerf and limit long pvp sword enchant knockbacks
~~Fix not being able to continuously damage players when holding the attack key~~

Testing

In game let another player join and see if you can damage players that are between 3 to 4.5 blocks away
Test if punching a player now feels similar to MC (Also test other non-enchant weapons)
Get a sword with knockback enchant I & II and test if the knockback on players is more closer to MC than before when running
~~Punch a player while holding the attack key and see if that player is damaged continuously~~

- Add missing pvp attack reach limit - Add minimum pvp knockbacks for non-enchant weapons and fists - Nerf and limit long pvp sword enchant knockbacks - ~~Fix not being able to continuously damage players when holding the attack key~~ ### Testing - In game let another player join and see if you can damage players that are between 3 to 4.5 blocks away - Test if punching a player now feels similar to MC (Also test other non-enchant weapons) - Get a sword with knockback enchant I & II and test if the knockback on players is more closer to MC than before when running - ~~Punch a player while holding the attack key and see if that player is damaged continuously~~

Eliy21 added 1 commit 2023-12-13 18:34:46 +01:00

a8806fe04e Add player invulnerability & fix not continuously damaging players when holding the attack key

Player invulnerability is the same as Minecraft's Damage Immunity https://minecraft.wiki/w/Damage#Immunity

The old code for some reason only allows a few damage by holding and does not continuously damage other players after a few hits

Eliy21 added 1 commit 2023-12-13 18:42:46 +01:00

a8c2d4534a Nerf long pvp enchanted knockbacks especially when running

Eliy21 changed title from ~~WIP: Finish PVP & PVE Combat Parity + PVP Tweaks & Bug Fixes~~ to Finish PVP & PVE Combat Parity + PVP Tweaks & Bug Fixes

2023-12-13 18:43:12 +01:00

Eliy21 added 1 commit 2023-12-13 19:49:12 +01:00

96aaf89036 Readjust pvp enchant knockback to make the running knockback difference more pronounced

Eliy21 added 1 commit 2023-12-13 21:04:20 +01:00

b0e33793ec Fix a potential bug that could bypass attack reach limit when a stronger attack breaches the invul

Eliy21 added 1 commit 2023-12-13 21:36:59 +01:00

2b71462c1e Prevent knockback if player is beyond attack reach limit

Bakawun commented

2023-12-14 08:08:28 +01:00

Can you make knockback work for basic unenchanted weapons(and fists?) Like in mc?

Eliy21 added 1 commit 2023-12-14 08:46:22 +01:00

85b1f5247a Add vertical lift & minimum pvp knockback

Eliy21 commented

2023-12-14 08:47:27 +01:00

Can you make knockback work for basic unenchanted weapons(and fists?) Like in mc?

Done

> Can you make knockback work for basic unenchanted weapons(and fists?) Like in mc? Done

Eliy21 added 1 commit 2023-12-14 09:12:17 +01:00

b2507c3640 Make fire aspect enchant respect attack reach limit

Eliy21 added 1 commit 2023-12-14 09:16:00 +01:00

ed507d8509 Remove unnecessary space in the attack reach limit on mobs code

Eliy21 added 1 commit 2023-12-14 09:51:40 +01:00

49af5d2013 Rebalance minimum pvp knockback to account for added knockbacks when moving

Bakawun commented

2023-12-14 09:51:56 +01:00

Can you make knockback work for basic unenchanted weapons(and fists?) Like in mc?

Done

I don't think there's enough knockback.

Using a wooden sword and sprinting mobs fly up a bit but nowhere close to the 3 or so blocks they fly back in mc under de same conditions

> > Can you make knockback work for basic unenchanted weapons(and fists?) Like in mc? > > Done I don't think there's enough knockback. Using a wooden sword and sprinting mobs fly up a bit but nowhere close to the 3 or so blocks they fly back in mc under de same conditions

Eliy21 added 1 commit 2023-12-14 10:27:33 +01:00

bf9e487fa9 Adjust minimum pvp knockback to be closer to MC

Eliy21 commented

2023-12-14 10:29:39 +01:00

I don't think there's enough knockback.

Using a wooden sword and sprinting mobs fly up a bit but nowhere close to the 3 or so blocks they fly back in mc under de same conditions

Oh this PR is mainly for PVP and adding attack reach limit that already exists in PVE hence the "PVP & PVE Combat Parity" title. I didn't touch the PVE aspect on this PR except for removing that unnecessary space in mob combat which functionally does absolutely nothing in gameplay.

But for the PVP side, punching other players now feels closer to MC.

> I don't think there's enough knockback. > > Using a wooden sword and sprinting mobs fly up a bit but nowhere close to the 3 or so blocks they fly back in mc under de same conditions Oh this PR is mainly for PVP and adding attack reach limit that already exists in PVE hence the "PVP & PVE Combat Parity" title. I didn't touch the PVE aspect on this PR except for removing that unnecessary space in mob combat which functionally does absolutely nothing in gameplay. But for the PVP side, punching other players now feels closer to MC.

Bakawun commented

2023-12-14 10:55:31 +01:00

Okay

I hacked your minimum knockback change into combat.lua and it's looking a lot better now

-- add minimum knockback if kb <= 1.5 then kb = kb + 4.875 end

Okay I hacked your minimum knockback change into combat.lua and it's looking a lot better now ` -- add minimum knockback if kb <= 1.5 then kb = kb + 4.875 end`

Eliy21 commented

2023-12-14 11:13:36 +01:00

Okay

I hacked your minimum knockback change into combat.lua and it's looking a lot better now

Oh no. I think it's my fault for not trying to get across the point of why I didn't touch the PVE combat code and here's the big reason: It will ruin the balance of the entire combat aspect for mobs unless you test very thoroughly.

I wish it were that simple as blindly copy pasting MC mechanics into MCL without careful consideration as I've spent my sanity just balancing everything in that mob combat PR. See the actual mob combat PR(s) of which are not just one to get an idea of how delicate it is to balance that as it affects all the mobs. Not to mention to be prepended to study player meta techs and how it will affect the balance of your changes. (See my rant on knockback juggling player tech)

It's an entire can of worms and I don't advise to change it unless you want to do a deep dive into everything combat related and do thorough testing with each and every little aspect of gameplay in combat and the potential situations that may arise which you have to balance as MCL is not 1:1 with MC so you have to account and adjust for that.

> Okay > > I hacked your minimum knockback change into combat.lua and it's looking a lot better now Oh no. I think it's my fault for not trying to get across the point of why I didn't touch the PVE combat code and here's the big reason: **It will ruin the balance of the entire combat aspect for mobs unless you test very thoroughly.** I wish it were that simple as blindly copy pasting MC mechanics into MCL without careful consideration as I've spent my sanity just balancing everything in that mob combat PR. See the actual mob combat PR(s) of which are not just one to get an idea of how delicate it is to balance that as it affects **all** the mobs. Not to mention to be prepended to study player meta techs and how it will affect the balance of your changes. (See my rant on knockback juggling player tech) It's an entire can of worms and I don't advise to change it unless you want to do a deep dive into everything combat related and do thorough testing with each and every little aspect of gameplay in combat and the potential situations that may arise which you have to balance as MCL is not 1:1 with MC so you have to account and adjust for that.

Bakawun commented

2023-12-14 11:20:56 +01:00

Currently there is zero knockback on mobs and with the recent changes it's almost impossible to survive in the early game.

The mob juggling doesn't work at all and mobs just run into you like freight trains .

Maybe I should open a ticket instead of talking about it here

Currently there is zero knockback on mobs and with the recent changes it's almost impossible to survive in the early game. The mob juggling doesn't work at all and mobs just run into you like freight trains . Maybe I should open a ticket instead of talking about it here

the-real-herowl commented

2023-12-14 11:23:57 +01:00

Okay

I hacked your minimum knockback change into combat.lua and it's looking a lot better now

Oh no. I think it's my fault for not trying to get across the point of why I didn't touch the PVE combat code and here's the big reason: It will ruin the balance of the entire combat aspect for mobs unless you test very thoroughly.

I wish it were that simple as blindly copy pasting MC mechanics into MCL without careful consideration as I've spent my sanity just balancing everything in that mob combat PR. See the actual mob combat PR(s) of which are not just one to get an idea of how delicate it is to balance that as it affects all the mobs. Not to mention to be prepended to study player meta techs and how it will affect the balance of your changes. (See my rant on knockback juggling player tech)

It's an entire can of worms and I don't advise to change it unless you want to do a deep dive into everything combat related and do thorough testing with each and every little aspect of gameplay in combat and the potential situations that may arise which you have to balance as MCL is not 1:1 with MC so you have to account and adjust for that.

Something like

local MIN_KNOCKBACK = 4.5 -- we need to balance this value
if kb < MIN_KNOCKBACK then kb = MIN_KNOCKBACK end

And then test it on creepers and magma cubes perhaps...

> > Okay > > > > I hacked your minimum knockback change into combat.lua and it's looking a lot better now > > Oh no. I think it's my fault for not trying to get across the point of why I didn't touch the PVE combat code and here's the big reason: **It will ruin the balance of the entire combat aspect for mobs unless you test very thoroughly.** > > I wish it were that simple as blindly copy pasting MC mechanics into MCL without careful consideration as I've spent my sanity just balancing everything in that mob combat PR. See the actual mob combat PR(s) of which are not just one to get an idea of how delicate it is to balance that as it affects **all** the mobs. Not to mention to be prepended to study player meta techs and how it will affect the balance of your changes. (See my rant on knockback juggling player tech) > > It's an entire can of worms and I don't advise to change it unless you want to do a deep dive into everything combat related and do thorough testing with each and every little aspect of gameplay in combat and the potential situations that may arise which you have to balance as MCL is not 1:1 with MC so you have to account and adjust for that. > Something like ``` local MIN_KNOCKBACK = 4.5 -- we need to balance this value if kb < MIN_KNOCKBACK then kb = MIN_KNOCKBACK end ``` And then test it on creepers and magma cubes perhaps...

Eliy21 commented

2023-12-14 11:32:56 +01:00

Okay since you insisted on this. If you want to add that minimum knockback of which you really have to test thoroughly as I see you just blindly copied my PVP code into PVE, which is already bad since there's subtle difference in the way the mob code works vs pvp so you must test for it, here's the thing you have to solve first: Find the code responsible for the hidden MCL exclusive quirk that exponentially increases knockback on the right timing of the second hit of your attack on mobs which is obviously not in MC. Unless you account for that your code has the potential to knockback mobs as if you had the knockback enchant while unenchanted. That's the minimum even before the very thorough testing that you need. ~~There's more but see if you can solve that first.~~ EDIT: (On second thought that is already a bit much so I think it will be fine if you just solved that one and just do thorough testing. Forgive my ranting, my Mob Combat PR trauma is resurfacing lol)

EDIT2:

Now that I've calmed down and has taken a rest from testing this PR, I realized that I may have been forcing the way I did my mob combat PR onto you @Bakawun and I'd like to apologize. Although it would be very nice if you could do something about that MCL exclusive quirk, you don't have to mind what I said and just do your own stuff. I can always add a PR in the future like what I'm doing now with this PR.

Okay since you insisted on this. If you want to add that minimum knockback of which you really have to test thoroughly as I see you just blindly copied my PVP code into PVE, which is already bad since there's subtle difference in the way the mob code works vs pvp so you must test for it, here's the thing you have to solve first: Find the code responsible for the hidden MCL exclusive quirk that exponentially increases knockback on the right timing of the second hit of your attack on mobs which is obviously not in MC. Unless you account for that your code has the potential to knockback mobs as if you had the knockback enchant while unenchanted. That's the minimum even before the very thorough testing that you need. ~~There's more but see if you can solve that first.~~ EDIT: (On second thought that is already a bit much so I think it will be fine if you just solved that one and just do thorough testing. Forgive my ranting, my Mob Combat PR trauma is resurfacing lol) EDIT2: Now that I've calmed down and has taken a rest from testing this PR, I realized that I may have been forcing the way I did my mob combat PR onto you @Bakawun and I'd like to apologize. Although it would be very nice if you could do something about that MCL exclusive quirk, you don't have to mind what I said and just do your own stuff. I can always add a PR in the future like what I'm doing now with this PR.

Eliy21 added 1 commit 2023-12-14 12:57:59 +01:00

6b439fd1de Add maximum pvp knockback limit & approximate enchant knockback distance to be similar to MC

Eliy21 commented

2023-12-14 14:47:55 +01:00

Something like
local MIN_KNOCKBACK = 4.5 -- we need to balance this value
if kb < MIN_KNOCKBACK then kb = MIN_KNOCKBACK end
And then test it on creepers and magma cubes perhaps...

Sorry looking back again after I finished testing this PR, I realized that there's a possibility that this comment is for me which I hope it isn't. The scope of this PR is PVP so it probably isn't but just making sure.

> Something like > ``` > local MIN_KNOCKBACK = 4.5 -- we need to balance this value > if kb < MIN_KNOCKBACK then kb = MIN_KNOCKBACK end > ``` > > And then test it on creepers and magma cubes perhaps... Sorry looking back again after I finished testing this PR, I realized that there's a possibility that this comment is for me which I hope it isn't. The scope of this PR is PVP so it probably isn't but just making sure.

the-real-herowl added the

labels 2023-12-14 22:10:20 +01:00

the-real-herowl added this to the 2 - Next milestone 2023-12-14 22:10:25 +01:00

the-real-herowl added the

Testing / Retest

needs discussion

labels 2023-12-14 22:10:38 +01:00

the-real-herowl requested review from the-real-herowl 2023-12-14 22:10:50 +01:00

Wbjitscool commented

2023-12-15 01:46:57 +01:00

can we also make it so that only the zombie and baby zombies that are set alight on fire to make the player burn apon being attacked only instead of every single mob causing the player to burn including the passive mobs when they walk past you when they are burning atm they cause the player to bur and it's super annoying it's only meant to be the zombies and baby zombies that only come in contact with the player only when it hits you then they player catches fire

Eliy21 commented

2023-12-15 02:44:06 +01:00

can we also make it so that only the zombie and baby zombies that are set alight on fire to make the player burn apon being attacked only instead of every single mob causing the player to burn including the passive mobs when they walk past you when they are burning atm they cause the player to bur and it's super annoying it's only meant to be the zombies and baby zombies that only come in contact with the player only when it hits you then they player catches fire

Is that burning mechanic in MC? I rarely encounter burning passive mobs in MC much more be burned by them to remember if this was how it's done there because I don't think they will make an exception for it. If you link a wiki or any other evidence then I'll conclude that there must be a significant gameplay balancing reason to warrant such weird exception. Normally it would make sense to expect that if a burning mob burns you then other mobs will too.

All that being said, this is a PVP PR and mobs are out of scope for this PR. I probably should just remove the PVE in the title.

> can we also make it so that only the zombie and baby zombies that are set alight on fire to make the player burn apon being attacked only instead of every single mob causing the player to burn including the passive mobs when they walk past you when they are burning atm they cause the player to bur and it's super annoying it's only meant to be the zombies and baby zombies that only come in contact with the player only when it hits you then they player catches fire > Is that burning mechanic in MC? I rarely encounter burning passive mobs in MC much more be burned by them to remember if this was how it's done there because I don't think they will make an exception for it. If you link a wiki or any other evidence then I'll conclude that there must be a significant gameplay balancing reason to warrant such weird exception. Normally it would make sense to expect that if a burning mob burns you then other mobs will too. All that being said, this is a PVP PR and mobs are out of scope for this PR. I probably should just remove the PVE in the title.

Eliy21 changed title from ~~Finish PVP & PVE Combat Parity + PVP Tweaks & Bug Fixes~~ to Finish PVP ~~& PVE~~ Combat Parity + PVP Tweaks & Bug Fixes

2023-12-15 02:45:18 +01:00

Eliy21 changed title from ~~Finish PVP ~~& PVE~~ Combat Parity + PVP Tweaks & Bug Fixes~~ to Finish PVP Combat Parity with PVE + PVP Tweaks & Bug Fixes

2023-12-15 02:46:03 +01:00

Eliy21 changed title from ~~Finish PVP Combat Parity with PVE + PVP Tweaks & Bug Fixes~~ to Finish PVP Combat Parity with *cough*pve*cough* + PVP Tweaks & Bug Fixes

2023-12-15 02:48:08 +01:00

Eliy21 changed title from ~~Finish PVP Combat Parity with *cough*pve*cough* + PVP Tweaks & Bug Fixes~~ to Finish PVP Combat Parity with the rest + PVP Tweaks & Bug Fixes

2023-12-15 03:02:36 +01:00

Eliy21 added 1 commit 2023-12-15 16:42:53 +01:00

60367cdbe0 Revert unreliable bugfix

There are times when the continuous damage when punching players does not happen so will not fix at the moment as using other weapons does still work.

Eliy21 changed title from ~~Finish PVP Combat Parity with the rest + PVP Tweaks & Bug Fixes~~ to Finish PVP Combat Parity with the rest + PVP Tweaks

2023-12-15 16:43:31 +01:00

Eliy21 added 1 commit 2023-12-15 16:52:30 +01:00

ca556c052f Prevent pvp knockbacks when invulnerable

Eliy21 added 1 commit 2023-12-15 16:59:12 +01:00

8e2c5249f5 Fix comment on player invul code

Eliy21 added 1 commit 2023-12-15 17:27:13 +01:00

d7b10d18d8 Fix not being able to give minimum knockback to players when both near and lower than them

Eliy21 added 1 commit 2023-12-15 19:17:20 +01:00

cd83305f07 Make the vertical lift on pvp knockback similar to MC

Eliy21 added 1 commit 2023-12-15 20:49:10 +01:00

c9692c6224 Fix player invulnerability not getting disabled permanently bug

Eliy21 commented

2023-12-15 21:53:37 +01:00

@the-real-herowl I encountered a sort of critical bug in your player invulnerability code that makes a player permanently invulnerable and it cannot be reset by leaving or rejoining the server. It's quite a game breaking bug that I encountered in my tests which I fixed in this PR by switching to the code I used in mob invulnerability and I believe that the bugged code is also in master and in release 0.85 so if people decided to do combat intensely (I tested on pvp), someone might accidentally become the god of the server.

Eliy21 added 1 commit 2023-12-15 22:02:13 +01:00

9b9747b3d8 Prevent excessive vertical knockbacks if hit by a player from below

Eliy21 added 1 commit 2023-12-15 23:56:10 +01:00

f799596db9 Make vertical pvp knockbacks respect attack reach limit & complete excess vertical kb prevention

Eliy21 added 1 commit 2023-12-16 08:58:30 +01:00

33e8337bbb Finish remaining excessive vertical pvp knockback prevention adjustments when hit from below

Eliy21 added 1 commit 2023-12-16 10:20:33 +01:00

cfab59d68a Rebalanced moving pvp knockbacks

Eliy21 added 1 commit 2023-12-16 10:46:23 +01:00

8fbd72c142 Optimize code by calling get_enchantment function only once

Eliy21 added 1 commit 2023-12-16 12:48:21 +01:00

32e91b45ae Add vertical pvp knockbacks from downward hits & reduce pvp kb on half block angled upward hits

Eliy21 added 1 commit 2023-12-16 13:59:04 +01:00

e8ee9c4463 Remove obsolete work-around code

Eliy21 added 1 commit 2023-12-17 17:39:09 +01:00

0a8874ecad Make vertical pvp knockbacks less floaty

Eliy21 added 1 commit 2023-12-17 18:48:43 +01:00

8612350fa7 Make vertical pvp knockback floatiness reduction include moving hits

Eliy21 added 1 commit 2023-12-17 20:59:21 +01:00

6d7ae8ba2d Add minimum unenchanted knockback to bow

Eliy21 added 1 commit 2023-12-17 21:01:38 +01:00

c39e55e2d4 Add minimum knockback to crossbow

Eliy21 added 1 commit 2023-12-17 22:16:00 +01:00

200f7451eb Remove unnecessary invul code & add damage animation code

Eliy21 added 1 commit 2023-12-17 22:19:00 +01:00

12109e7f44 Add player damage animation

Eliy21 added 1 commit 2023-12-18 22:31:43 +01:00

14cec16c63 Increase enchanted bow knockback

Eliy21 added 1 commit 2023-12-18 22:42:30 +01:00

fe90424ee4 Add pvp knockback reduction when moving towards player while attacking

Eliy21 added 1 commit 2023-12-18 23:04:21 +01:00

44c656502f Add a prevention in case players get stuck with the damage animation

Michieal commented

2023-12-19 02:21:10 +01:00

You're probably aware of this, but make sure that the bows/arrows don't do a "one hit kill" on players. Also, arrows that fall from a removed block shouldn't have knockback.

Eliy21 commented

2023-12-19 11:05:48 +01:00

You're probably aware of this, but make sure that the bows/arrows don't do a "one hit kill" on players. Also, arrows that fall from a removed block shouldn't have knockback.

The only think I've changed so far in bows/crossbows is the increase or additions of knockbacks themselves. Other things like damage or behavior remains the same. As of this PR or post 0.85 the damage on players does not onehit kill and the arrows dug doesn't give knockback and becomes an item that you can pick up.

> You're probably aware of this, but make sure that the bows/arrows don't do a "one hit kill" on players. Also, arrows that fall from a removed block shouldn't have knockback. The only think I've changed so far in bows/crossbows is the increase or additions of knockbacks themselves. Other things like damage or behavior remains the same. As of this PR or post 0.85 the damage on players does not onehit kill and the arrows dug doesn't give knockback and becomes an item that you can pick up.

Bakawun referenced this pull request

2023-12-19 12:18:30 +01:00

PVE combat missing the knockback needed to juggle mobs #4087

Eliy21 added 1 commit 2023-12-19 16:31:35 +01:00

d7ed37ef25 Remove redundant knockback limiter

Eliy21 added 1 commit 2023-12-19 17:15:45 +01:00

ff882707de Rework moving majority of the added velocity knockbacks into sprinting

Eliy21 added 1 commit 2023-12-19 17:49:52 +01:00

76bff2b540 Add minimum pvp knockbacks to other meele weapons

Eliy21 added 1 commit 2023-12-19 18:19:16 +01:00

e19de85990 Adjust the difference between sprinting & walking knockbacks for a more seemless transition

Michieal commented

2023-12-20 07:14:12 +01:00

You're probably aware of this, but make sure that the bows/arrows don't do a "one hit kill" on players. Also, arrows that fall from a removed block shouldn't have knockback.

The only think I've changed so far in bows/crossbows is the increase or additions of knockbacks themselves. Other things like damage or behavior remains the same. As of this PR or post 0.85 the damage on players does not onehit kill and the arrows dug doesn't give knockback and becomes an item that you can pick up.

I believe that what @the-real-herowl was doing, was shooting an arrow straight up into the air. And when it landed, it killed him. just something to make sure of so we don't have a regression.

> > You're probably aware of this, but make sure that the bows/arrows don't do a "one hit kill" on players. Also, arrows that fall from a removed block shouldn't have knockback. > > The only think I've changed so far in bows/crossbows is the increase or additions of knockbacks themselves. Other things like damage or behavior remains the same. As of this PR or post 0.85 the damage on players does not onehit kill and the arrows dug doesn't give knockback and becomes an item that you can pick up. I believe that what @the-real-herowl was doing, was shooting an arrow straight up into the air. And when it landed, it killed him. just something to make sure of so we don't have a regression.

Eliy21 commented

2023-12-20 14:18:10 +01:00

I believe that what @the-real-herowl was doing, was shooting an arrow straight up into the air. And when it landed, it killed him. just something to make sure of so we don't have a regression.

I've shot a regular bow and an enchantet bow with Power V at full charge directly straight up into the air and tried to catch the arrow with no armor and it still didn't kill me.

> I believe that what @the-real-herowl was doing, was shooting an arrow straight up into the air. And when it landed, it killed him. just something to make sure of so we don't have a regression. I've shot a regular bow and an enchantet bow with Power V at full charge directly straight up into the air and tried to catch the arrow with no armor and it still didn't kill me.

the-real-herowl commented

2023-12-20 14:32:39 +01:00

I believe that what @the-real-herowl was doing, was shooting an arrow straight up into the air. And when it landed, it killed him. just something to make sure of so we don't have a regression.

I've shot a regular bow and an enchantet bow with Power V at full charge directly straight up into the air and tried to catch the arrow with no armor and it still didn't kill me.

The only enchantment that was needed for that bug was Punch II. It was basically knocking the player into the ground and the player would take fall damage.

I would test it myself, but I sadly don't have the time for it for now.

> > > I believe that what @the-real-herowl was doing, was shooting an arrow straight up into the air. And when it landed, it killed him. just something to make sure of so we don't have a regression. > > I've shot a regular bow and an enchantet bow with Power V at full charge directly straight up into the air and tried to catch the arrow with no armor and it still didn't kill me. The only enchantment that was needed for that bug was Punch II. It was basically knocking the player into the ground and the player would take fall damage. I would test it myself, but I sadly don't have the time for it for now.

Eliy21 commented

2023-12-20 14:55:49 +01:00

The only enchantment that was needed for that bug was Punch II. It was basically knocking the player into the ground and the player would take fall damage.

I would test it myself, but I sadly don't have the time for it for now.

I've tested it now with Punch II bow and I didn't die.

> The only enchantment that was needed for that bug was Punch II. It was basically knocking the player into the ground and the player would take fall damage. > > I would test it myself, but I sadly don't have the time for it for now. I've tested it now with Punch II bow and I didn't die.

Eliy21 added 1 commit 2023-12-20 16:50:46 +01:00

96fa6c251e Counteract self forward velocity when hit by players in pvp

Eliy21 added 1 commit 2023-12-21 16:52:32 +01:00

10dcdb7d6b Remove unnecessary player vector magnitude calculation

the-real-herowl modified the milestone from 2 - Next to 0.87.0 - Prismatic

2023-12-24 19:59:14 +01:00

the-real-herowl added the

#P2: HIGH

label 2023-12-29 11:38:44 +01:00

the-real-herowl modified the milestone from 0.87.0 - Prismatic to 1 - Now

2023-12-29 11:41:57 +01:00

the-real-herowl approved these changes 2023-12-30 05:20:24 +01:00