Respawn dead players when they login so they don't get stuck without the death formspec #4041

Eliy21 · 2023-12-01T17:30:57+01:00

Eliy21 commented

2023-12-01 17:30:57 +01:00

Hopefully will prevent the dead player not respawning when logging in bug from happening https://forum.minetest.net/viewtopic.php?p=430589#p430589

Testing

I can't replicate the bug but if players with 0 hp joins, they will be forcibly respawned. I tested being forcibly respawned on joining without the "if then condition" and I also tested that the hp variable is correct. But for the actual bug to happen, I don't know how.

Hopefully will prevent the dead player not respawning when logging in bug from happening https://forum.minetest.net/viewtopic.php?p=430589#p430589 ### Testing I can't replicate the bug but if players with 0 hp joins, they will be forcibly respawned. I tested being forcibly respawned on joining without the "if then condition" and I also tested that the hp variable is correct. But for the actual bug to happen, I don't know how.

Eliy21 force-pushed respawn_joining_dead_players from 869680d927 to 22952fd591

2023-12-01 17:32:13 +01:00

Compare

the-real-herowl added the

gameplay

Testing / Retest

#P4 priority: medium

labels 2023-12-05 01:06:33 +01:00

the-real-herowl approved these changes 2023-12-05 02:08:13 +01:00

the-real-herowl added this to the 0.85.0 - Fire and Stone milestone 2023-12-05 02:08:21 +01:00

the-real-herowl merged commit 0673fcc25b into master

2023-12-05 02:08:52 +01:00

the-real-herowl referenced this issue from a commit

2023-12-05 02:08:53 +01:00

Respawn dead players when they login so they don't get stuck without the death formspec (#4041)

ancientmarinerdev commented

2023-12-05 02:38:02 +01:00

Oooh, good idea and fixes a really nasty bug. Thanks for knocking up this PR :).

Eliy21 commented

2023-12-05 03:02:31 +01:00

Oooh, good idea and fixes a really nasty bug. Thanks for knocking up this PR :).

I thought that this may have repercussions on hiding the bug that does not show the death formspec instead of actually fixing it but I deemed that the positives outweigh the negative since people have resorted to abandoning accounts because of this bug.

> Oooh, good idea and fixes a really nasty bug. Thanks for knocking up this PR :). I thought that this may have repercussions on hiding the bug that does not show the death formspec instead of actually fixing it but I deemed that the positives outweigh the negative since people have resorted to abandoning accounts because of this bug.

ancientmarinerdev commented

2023-12-05 03:19:17 +01:00

Oooh, good idea and fixes a really nasty bug. Thanks for knocking up this PR :).

I thought that this may have repercussions on hiding the bug that does not show the death formspec instead of actually fixing it but I deemed that the positives outweigh the negative since people have resorted to abandoning accounts because of this bug.

100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us.

> > Oooh, good idea and fixes a really nasty bug. Thanks for knocking up this PR :). > > I thought that this may have repercussions on hiding the bug that does not show the death formspec instead of actually fixing it but I deemed that the positives outweigh the negative since people have resorted to abandoning accounts because of this bug. 100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us.

Eliy21 commented

2023-12-05 03:36:04 +01:00

100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us.

Uh oh should I have added that log to this PR? But since this is already merged its probably too late now. Should I make another PR adding that in?

> 100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us. Uh oh should I have added that log to this PR? But since this is already merged its probably too late now. Should I make another PR adding that in?

ancientmarinerdev commented

2023-12-05 03:39:33 +01:00

100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us.

Uh oh should I have added that log to this PR? But since this is already merged its probably too late now. Should I make another PR adding that in?

That is a decision for @the-real-herowl . It's worth it imho, but we are close to release.

> > > 100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us. > > Uh oh should I have added that log to this PR? But since this is already merged its probably too late now. Should I make another PR adding that in? That is a decision for @the-real-herowl . It's worth it imho, but we are close to release.

the-real-herowl commented

2023-12-05 03:41:50 +01:00

100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us.

Uh oh should I have added that log to this PR? But since this is already merged its probably too late now. Should I make another PR adding that in?

Make the PR.

> > > 100% true and definitely a good thought process. In future, you can always minetest.log this with "action" or "warning" and it'll log it. Maybe last one will be easier to grep for for server owners who can pass the info on to us. > > Uh oh should I have added that log to this PR? But since this is already merged its probably too late now. Should I make another PR adding that in? Make the PR.

Eliy21 commented

2023-12-05 03:48:28 +01:00

That is a decision for @the-real-herowl . It's worth it imho, but we are close to release.

Make the PR.

Ok will do it later in a few hours since I can't right now. Hopefully I'll make it in time.

> That is a decision for @the-real-herowl . It's worth it imho, but we are close to release. > Make the PR. Ok will do it later in a few hours since I can't right now. Hopefully I'll make it in time.

the-real-herowl commented

2023-12-05 03:51:25 +01:00

That is a decision for @the-real-herowl . It's worth it imho, but we are close to release.

Make the PR.

Ok will do it later in a few hours since I can't right now. Hopefully I'll make it in time.

You will. Take your time, I'm merging #4036 in 2-3 days and we're not doing release before that.

> > > That is a decision for @the-real-herowl . It's worth it imho, but we are close to release. > > > Make the PR. > > Ok will do it later in a few hours since I can't right now. Hopefully I'll make it in time. You will. Take your time, I'm merging #4036 in 2-3 days and we're not doing release before that.

Eliy21 commented

2023-12-05 03:55:23 +01:00

You will. Take your time, I'm merging #4036 in 2-3 days and we're not doing release before that.

For a second I thought the release is happening today as I see a release PR and everything. Ok that takes the pressure off me thanks.

> You will. Take your time, I'm merging #4036 in 2-3 days and we're not doing release before that. For a second I thought the release is happening today as I see a release PR and everything. Ok that takes the pressure off me thanks.

Eliy21 referenced this pull request

2023-12-05 06:18:23 +01:00

Add warning log if players with 0 hp joined #4051

the-real-herowl removed the

Testing / Retest

label 2023-12-13 03:10:06 +01:00

Ghost referenced this issue from a commit

2023-12-22 18:46:48 +01:00

Respawn dead players when they login so they don't get stuck without the death formspec (#4041)

Ghost referenced this issue from a commit

2023-12-22 18:46:48 +01:00

Respawn dead players when they login so they don't get stuck without the death formspec (#4041)