Improve mob floating #3883

Codiac · 2023-08-12T06:04:52+02:00

Codiac commented

2023-08-12 06:04:52 +02:00

This changes mob floating so they stay inside the top water node instead of standing on it. The head of the mob should still be above water.

Changes drowning so that mobs will not drown in one block of water. They will drown in 2 or more blocks of water.

Does not appear to affect them getting out of deep water :( But they do seem to die somewhat faster when they stay in deep water.

Testing

Grab some eggs in creative mode and spawn mobs in various depths of water.

This changes mob floating so they stay inside the top water node instead of standing on it. The head of the mob should still be above water. Changes drowning so that mobs will not drown in one block of water. They will drown in 2 or more blocks of water. Does not appear to affect them getting out of deep water :( But they do seem to die somewhat faster when they stay in deep water. ### Testing Grab some eggs in creative mode and spawn mobs in various depths of water.

Codiac added 1 commit 2023-08-12 06:04:54 +02:00

6ae597c97f This changes mob floating so they stay inside the top water node instead of

standing on it. The head of the mod should still be above water.

Changes drowning so that mobs will not drown in one block of water. They will
drown in 2 or more blocks of water.

Does not appear to affect them getting out of deep water :( But they do seem to
die somewhat faster when they stay in deep water.

Codiac added 1 commit 2023-08-13 04:13:24 +02:00

898a183ccd Prevent floating mobs from drowning all the time

Less dieing for mobs in deep water.

Codiac added 1 commit 2023-08-13 04:15:21 +02:00

034382c883 Fix float check :(

Codiac commented

2023-08-13 06:26:39 +02:00

FYI the stuff up in the Minclonea patch merge is all mine :(

ancientmarinerdev requested changes 2023-08-13 15:31:31 +02:00

mods/ENTITIES/mcl_mobs/physics.lua Outdated

					
				@ -675,6 +675,9 @@ function mob_class:do_env_damage()

					self.standing_in = node_ok(pos, "air").name

					self.standing_on = node_ok(pos2, "air").name

					local pos3 = {x=pos.x, y=pos.y+1, z=pos.z}

ancientmarinerdev commented

2023-08-13 15:30:54 +02:00

We should use vector.offset for this. The vector functions have assertions in there. This could be invalid and fail further down the line.

Codiac commented

2023-08-14 02:36:47 +02:00

I just copied how pos2 is done. Should we just change pos3, change pos2 and pos3, or do a separate PR that changes to vectors in a bunch of places?

Codiac commented

2023-08-14 02:49:25 +02:00

I just did pos3.

ancientmarinerdev commented

2023-08-14 14:08:39 +02:00

Thanks. As long as we don't add more to the tech debt bonfire. Ideally we fix surrounding cases as we go, but I won't be that harsh, just yet. You're learning the project, and I don't want the learning curve to be offputting.

Long term, improving code around where we work will help to chip through that tech debt and eventually we'll have a good code base :).

Thanks. As long as we don't add more to the tech debt bonfire. Ideally we fix surrounding cases as we go, but I won't be that harsh, just yet. You're learning the project, and I don't want the learning curve to be offputting. Long term, improving code around where we work will help to chip through that tech debt and eventually we'll have a good code base :).

👍 1

Codiac marked this conversation as resolved

mods/ENTITIES/mcl_mobs/physics.lua Outdated

					
				@ -940,3 +944,3 @@

					-- in water then float up

					if registered_node.groups.water then

						if acc and self.floats == 1 then

						if acc and self.floats == 1 minetest.registered_nodes[node_ok(vector.offset(pos,0,self.collisionbox[5] -0.25,0)).name].groups.water then