Banners color editing #3868

VanicGame · 2023-08-02T13:01:51+02:00

VanicGame commented

2023-08-02 13:01:51 +02:00

Changing banner colors

Reason: I think the current colors of the banners do not match the palette of the surrounding world.
Solution: Muting Banner Tones

Testing

Check out the new colors on 12 color banners.

Attachments

Changed banner colors/Current banner appearance

UPDATE: Adjusted colors, see the third attachment

UPDATE: Changed the color of the white flag. Fixed a bug with different colors of patterns and banners, increased the contrast of folds. The last four attachments display all.

### Changing banner colors Reason: I think the current colors of the banners do not match the palette of the surrounding world. Solution: Muting Banner Tones ### Testing Check out the new colors on 12 color banners. ### Attachments Changed banner colors/Current banner appearance UPDATE: Adjusted colors, see the third attachment UPDATE: Changed the color of the white flag. Fixed a bug with different colors of patterns and banners, increased the contrast of folds. The last four attachments display all.

screenshot_20230801_214619.png

266 KiB

screenshot_20230801_215405.png

319 KiB

screenshot_20230802_212040.png

302 KiB

screenshot_20230804_223314.png

213 KiB

screenshot_20230804_223309.png

257 KiB

screenshot_20230804_223305.png

257 KiB

screenshot_20230804_223255.png

260 KiB

👍 3

VanicGame added 1 commit 2023-08-02 13:01:58 +02:00

02303cc82c Banners color editing

Wbjitscool commented

2023-08-02 13:48:20 +02:00

looks good

rudzik8 commented

2023-08-02 15:28:09 +02:00

if we are to tune the colors based off the wool, I think this PR fails at some of them. mostly on these (cropped out of the image using an editor, then changed the banner colors):

what do you think?

if we are to tune the colors based off the wool, I think this PR fails at some of them. mostly on these (cropped out of the image using an editor, then changed the banner colors): ![выява](/attachments/7cf12497-44fc-43a6-8487-43a9dfb450d2) ![выява](/attachments/80c051f1-4319-4356-a881-dd4db7b4aec6) what do you think?

выява.png

23 KiB

выява.png

23 KiB

VanicGame added 1 commit 2023-08-02 20:38:29 +02:00

532bf22d2d Banner color correction

VanicGame commented

2023-08-02 20:41:17 +02:00

Corrected colors, updated description

👍 1

chmodsayshello added the

graphics

enhancement

labels 2023-08-04 17:06:15 +02:00

chmodsayshello commented

2023-08-04 17:13:30 +02:00

Looks good! You've got my merge approval one tweaking the white banner

VanicGame added 1 commit 2023-08-04 20:07:49 +02:00

a7abf092a5 White banner color adjustment

chmodsayshello commented

2023-08-04 20:58:21 +02:00

Thanks for adjusting the white banner, but as long as the result of the PR is that color palette of the banner's content is different than the ones the banners use, we'll have to mark it as WIP

chmodsayshello changed title from ~~Banners color editing~~ to WIP: Banners color editing

2023-08-04 20:58:27 +02:00

VanicGame added 1 commit 2023-08-04 21:33:56 +02:00

4ff1d9fd22 Fixing a bug with patterns on the banner, displaying textured folds

chmodsayshello changed title from ~~WIP: Banners color editing~~ to Banners color editing

2023-08-04 21:38:42 +02:00

VanicGame added 1 commit 2023-08-04 22:00:04 +02:00

5c6d47e1fd Optimaze texture

chmodsayshello approved these changes 2023-08-31 19:02:31 +02:00

ancientmarinerdev added this to the 0.85.0 - Fire and Stone milestone 2023-09-01 00:26:49 +02:00

ancientmarinerdev merged commit 7b764adbc0 into master

2023-09-01 00:27:10 +02:00