Rename Bucket Textures #3708

Ghost · 2023-05-10T11:13:00+02:00

Ghost commented

2023-05-10 11:13:00 +02:00

First-time contributor

This pull request renames buckets so that they use the mcl_ naming convention.

I originally was going to do some renaming on a bigger scope, but decided against it for now.

This pull request renames buckets so that they use the `mcl_` naming convention. I originally was going to do some renaming on a bigger scope, but decided against it for now.

Ghost added the

enhancement

label 2023-05-10 11:13:00 +02:00

Ghost changed title from ~~WIP: Minetest Game Textures Rename~~ to WIP: Textures Rename: Part 1

2023-05-10 11:50:22 +02:00

Ghost changed title from ~~WIP: Textures Rename: Part 1~~ to Rename Bucket Textures

2023-05-10 12:07:26 +02:00

ancientmarinerdev approved these changes 2023-05-14 13:37:01 +02:00

ancientmarinerdev left a comment

Looks good, and works even with stored buckets.

Small scale changes are probably better and easier to test and review without blocking others.

@PrairieWind Could this impact the portal bucket mod? If so, it may need updating on release.

Any other mods that could be impacted?

Looks good, and works even with stored buckets. Small scale changes are probably better and easier to test and review without blocking others. @PrairieWind Could this impact the portal bucket mod? If so, it may need updating on release. Any other mods that could be impacted?

ancientmarinerdev force-pushed mtg_textures_rename from d0d7c5b2b2 to 81ea69cd33

2023-05-14 13:37:59 +02:00

Compare

ancientmarinerdev added this to the 0.84.0 - Very Nice milestone 2023-05-14 13:38:04 +02:00

ancientmarinerdev added the

release notes

label 2023-05-14 13:39:52 +02:00

ancientmarinerdev referenced this issue from a commit

2023-05-14 13:41:42 +02:00

Rename Bucket Textures (#3708)

ancientmarinerdev merged commit 998983445b into master

2023-05-14 13:41:42 +02:00

ancientmarinerdev deleted branch mtg_textures_rename

2023-05-14 13:41:49 +02:00

Ghost commented

2023-05-14 17:50:50 +02:00

First-time contributor

I do not think it would affect it, as the portal mod has its own texture. I will check it later though to confirm. Only texture packs would take a hit as far as I am aware. I am not aware of any new mineclone2 (compatible) mods that would use that texture.

👍 1

ancientmarinerdev commented

2023-05-14 17:51:50 +02:00

I do not think it would affect it, as the portal mod has its own texture. I will check it later though to confirm. Only texture packs would take a hit as far as I am aware. I am not aware of any new mineclone2 (compatible) mods that would use that texture.

Thanks for the info.

> I do not think it would affect it, as the portal mod has its own texture. I will check it later though to confirm. Only texture packs would take a hit as far as I am aware. I am not aware of any new mineclone2 (compatible) mods that would use that texture. Thanks for the info.

ancientmarinerdev referenced this pull request

2023-06-06 12:05:44 +02:00

Could not load image "bucket_lava.png" while building texture #3779

ryvnf referenced this pull request

2023-06-16 17:45:39 +02:00

Reconsider the renaming of texture files #3802

Sign in to join this conversation.

No reviewers