New sweet berry textures #3654

SmokeyDope · 2023-04-19T04:32:38+02:00

SmokeyDope commented

2023-04-19 04:32:38 +02:00

This PR Fixes #3647 by adding a set of new sweet berry textures to replace the old ones which were apparently unfinished dummy textures.

Screenshot from 2023-04-18 22-14-40.png

570 KiB

Screenshot from 2023-04-18 22-35-15.png

513 KiB

❤️ 2 🚀 1

MrRar requested changes 2023-04-19 20:28:30 +02:00

MrRar left a comment

The premature berry bush looks like a weird cactus. The single red pixels on the berry bushes could be anything. I think 4 pixel berries are better.

The picked berries look better than the original although the shading direction is not consistent (the light is coming from different directions for different berries).

The premature berry bush looks like a weird cactus. The single red pixels on the berry bushes could be anything. I think 4 pixel berries are better. The picked berries look better than the original although the shading direction is not consistent (the light is coming from different directions for different berries).

SmokeyDope commented

2023-04-20 03:51:56 +02:00

@MrRar What do you think of these changes? Fixed shading on sweet berry item, made berries 2x2 on bushes and smoothed out the premature bush a little

Screenshot from 2023-04-19 22-00-45.png

617 KiB

MrRar commented

2023-04-20 14:45:14 +02:00

@MrRar What do you think of these changes? Fixed shading on sweet berry item, made berries 2x2 on bushes and smoothed out the premature bush a little

It's looking much better. Thank you!

> @MrRar What do you think of these changes? Fixed shading on sweet berry item, made berries 2x2 on bushes and smoothed out the premature bush a little It's looking much better. Thank you!

SmokeyDope requested review from MrRar 2023-04-20 17:09:51 +02:00

MrRar commented

2023-04-27 20:34:38 +02:00

I would recommend having no berries at the seam of the plant. The berries at the seams look kind of weird.

I would also recommend having the white pixel on the berries be on the top because the light is coming from above.

I would recommend using a brighter red for the berries see my example.

I would recommend having no berries at the seam of the plant. The berries at the seams look kind of weird. I would also recommend having the white pixel on the berries be on the top because the light is coming from above. I would recommend using a brighter red for the berries see my example.

Screenshot_2023-04-27_13-22-05.png

67 KiB

berry.png

680 B

SmokeyDope commented

2023-04-27 21:51:37 +02:00

Done!

Screenshot from 2023-04-27 15-47-19.png

378 KiB

Screenshot from 2023-04-27 15-47-51.png

425 KiB

Screenshot from 2023-04-27 15-49-01.png

751 KiB

kneekoo commented

2023-04-27 23:08:46 +02:00

Do you guys think a slightly less bright pixel would look good on the berry? It looks a bit too white to me.

👍 1

ancientmarinerdev commented

2023-04-27 23:15:48 +02:00

Do you guys think a slightly less bright pixel would look good on the berry? It looks a bit too white to me.

Yeah, it does a little. It is supposed to symbolise light and light will brighten colours but not necessarily make it white.

> Do you guys think a slightly less bright pixel would look good on the berry? It looks a bit too white to me. Yeah, it does a little. It is supposed to symbolise light and light will brighten colours but not necessarily make it white.

SmokeyDope commented

2023-04-27 23:56:57 +02:00

Do you guys think a slightly less bright pixel would look good on the berry? It looks a bit too white to me.

Yeah, it does a little. It is supposed to symbolise light and light will brighten colours but not necessarily make it white.

How do you guys feel about this shade? A little more grey-redish
New shade on left plant old white on right plant

> Do you guys think a slightly less bright pixel would look good on the berry? It looks a bit too white to me. > Yeah, it does a little. It is supposed to symbolise light and light will brighten colours but not necessarily make it white. How do you guys feel about this shade? A little more grey-redish New shade on left plant old white on right plant

Screenshot from 2023-04-27 17-55-01.png

585 KiB

👍 1 ❤️ 1

kneekoo commented

2023-04-28 01:04:45 +02:00

How do you guys feel about this shade? A little more grey-redish
New shade on left plant old white on right plant

It looks better to me, and I'm fine if everyone likes it. :) If it were up to me, I'd make it a touch darker.

> How do you guys feel about this shade? A little more grey-redish > New shade on left plant old white on right plant It looks better to me, and I'm fine if everyone likes it. :) If it were up to me, I'd make it a touch darker.

SmokeyDope commented

2023-04-28 01:09:58 +02:00

How do you guys feel about this shade? A little more grey-redish
New shade on left plant old white on right plant

It looks better to me, and I'm fine if everyone likes it. :) If it were up to me, I'd make it a touch darker.

Heres just a touch darker

> > How do you guys feel about this shade? A little more grey-redish > > New shade on left plant old white on right plant > > It looks better to me, and I'm fine if everyone likes it. :) If it were up to me, I'd make it a touch darker. Heres just a touch darker

Screenshot from 2023-04-27 19-09-40.png

585 KiB

👍 1 🎉 1

kneekoo commented

2023-04-28 01:17:39 +02:00

Awesome, thanks for that! :D

ancientmarinerdev commented

2023-04-28 04:24:13 +02:00

How do you guys feel about this shade? A little more grey-redish
New shade on left plant old white on right plant

It looks better to me, and I'm fine if everyone likes it. :) If it were up to me, I'd make it a touch darker.

Heres just a touch darker

Nailed it. Good work :).

> > > How do you guys feel about this shade? A little more grey-redish > > > New shade on left plant old white on right plant > > > > It looks better to me, and I'm fine if everyone likes it. :) If it were up to me, I'd make it a touch darker. > > Heres just a touch darker Nailed it. Good work :).

🎉 1

SmokeyDope commented

2023-05-02 19:44:35 +02:00

Thanks for the feedback everyone :) I think this is ready to go if were all happy with how things turned out.

🎉 1

MrRar force-pushed sweet-berry-texture-change from 4078cbdc9e to 1448a5e098

2023-05-02 20:51:44 +02:00

Compare

MrRar approved these changes 2023-05-02 20:53:51 +02:00

MrRar left a comment

Definitely an improvement.

MrRar referenced this issue from a commit

2023-05-02 20:54:59 +02:00

Merge pull request 'New sweet berry textures' (#3654) from sweet-berry-texture-change into master

MrRar merged commit 3e768c6a6f into master

2023-05-02 20:55:00 +02:00

MrRar deleted branch sweet-berry-texture-change

2023-05-02 20:55:19 +02:00

MrRar commented

2023-05-02 20:57:27 +02:00

I tried the interactive rebase. I had to type the word squash a thousand times!

ancientmarinerdev added this to the 0.84.0 - Very Nice milestone 2023-05-02 21:03:22 +02:00

ancientmarinerdev added the

graphics

label 2023-05-02 21:03:32 +02:00

Ghost commented

2023-05-02 21:34:26 +02:00

First-time contributor

I tried the interactive rebase. I had to type the word squash a thousand times!

Ouch, lol.

> I tried the interactive rebase. I had to type the word squash a thousand times! > Ouch, lol.

ancientmarinerdev commented

2023-05-02 22:19:30 +02:00

I tried the interactive rebase. I had to type the word squash a thousand times!

I think you can use the letter only, for a fixup (a squash with keeping oldest commit message) you can have f at the start of the line. It's documented that way from command line.

> I tried the interactive rebase. I had to type the word squash a thousand times! > I think you can use the letter only, for a fixup (a squash with keeping oldest commit message) you can have f at the start of the line. It's documented that way from command line.

MrRar commented

2023-05-04 19:56:04 +02:00

I tried the interactive rebase. I had to type the word squash a thousand times!

I think you can use the letter only, for a fixup (a squash with keeping oldest commit message) you can have f at the start of the line. It's documented that way from command line.

OK. I'll try that next time I guess.

> > I tried the interactive rebase. I had to type the word squash a thousand times! > > > > I think you can use the letter only, for a fixup (a squash with keeping oldest commit message) you can have f at the start of the line. It's documented that way from command line. OK. I'll try that next time I guess.

Sign in to join this conversation.

No reviewers