Improve French translation #3531

syl · 2023-03-10T23:18:38+01:00

syl commented

2023-03-10 23:18:38 +01:00

Hello, I took some time improving the French translation.
There is a much more to do but it's enough for a first PR.

Hello, I took some time improving the French translation. There is a much more to do but it's enough for a first PR.

syl added 2 commits 2023-03-10 23:18:44 +01:00

96b2f6a01d Improve French translation

21dbf583ee Add syl in credits

AFCMS added the

translation

label 2023-03-12 18:42:02 +01:00

AFCMS approved these changes 2023-03-12 18:45:59 +01:00

AFCMS left a comment

Good job 👍

Not a big fan of the following changes, but it makes sense in french. Minecraft does it that way too.

- Diamond Pickaxe=Pioche en Diamant
+ Diamond Pickaxe=Pioche en diamant

(I am french)

Good job :+1: Not a big fan of the following changes, but it makes sense in french. Minecraft does it that way too. ```diff - Diamond Pickaxe=Pioche en Diamant + Diamond Pickaxe=Pioche en diamant ``` (I am french)

kneekoo commented

2023-03-12 21:09:36 +01:00

Good job 👍

Thanks for reviewing this. :) I noticed some good stuff in there, as well as some that isn't clear to me - like verbs ending in -ez instead of -er. But as I'm not qualified to validate this, I'm glad you did. :)

Not a big fan of the following changes, but it makes sense in french. Minecraft does it that way too.
- Diamond Pickaxe=Pioche en Diamant
+ Diamond Pickaxe=Pioche en diamant
(I am french)

English capitalizes words in titles, but many languages don't. People new(er) to translations tend to gloss over this detail and when they try to make the translation closer to the English strings, they can end up capitalizing words as well, which is actually wrong. I did the same about two decades ago. :P

> Good job :+1: Thanks for reviewing this. :) I noticed some good stuff in there, as well as some that isn't clear to me - like verbs ending in *-ez* instead of *-er*. But as I'm not qualified to validate this, I'm glad you did. :) > Not a big fan of the following changes, but it makes sense in french. Minecraft does it that way too. > > ```diff > - Diamond Pickaxe=Pioche en Diamant > + Diamond Pickaxe=Pioche en diamant > ``` > > (I am french) English capitalizes words in titles, but many languages don't. People new(er) to translations tend to gloss over this detail and when they try to make the translation closer to the English strings, they can end up capitalizing words as well, which is actually wrong. I did the same about two decades ago. :P

ancientmarinerdev commented

2023-03-12 21:55:07 +01:00

Thanks for the translations! Must have been a lot of work. Really appreciated.

Oh, and thanks for reviewing, AFCMS! The extent of my French is pomme de terre, which is the best label to use to describe my laptop, so wasn't looking forward to the review process :).

Thanks for the translations! Must have been a lot of work. Really appreciated. Oh, and thanks for reviewing, AFCMS! The extent of my French is pomme de terre, which is the best label to use to describe my laptop, so wasn't looking forward to the review process :).

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-03-12 21:55:27 +01:00

ancientmarinerdev referenced this issue from a commit

2023-03-12 21:55:38 +01:00

Merge pull request 'Improve French translation' (#3531) from syl/MineClone2:master into master

ancientmarinerdev merged commit 994f720385 into master

2023-03-12 21:55:38 +01:00

Sign in to join this conversation.

No reviewers