Vine Colouring Improvements #3480
No reviewers
Labels
No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: VoxeLibre/VoxeLibre#3480
Loading…
Reference in New Issue
No description provided.
Delete Branch "vine_rotation_calculation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Before this pull request, vines could only grab the biome's colour once and never again, because the conversion of the vine's colours relied on the vine's
param2
to know the correct rotation, but this meant that the rotation could no longer be found after conversion, since theparam2
of said vine has since changed by being added to other numbers.Now, the rotation of the vines even after grabbing the biome's colour is found by trying to subtract certain numbers from the vine until certain numbers are found which would correspond with the correct rotation of said vines.
a9f5efcbc0
toa457853938
Works, looks good to me.
Good catch! Thanks for fixing.