Vine Colouring Improvements #3480

Merged
Ghost merged 2 commits from vine_rotation_calculation into master 2023-02-28 04:10:59 +01:00
First-time contributor

Before this pull request, vines could only grab the biome's colour once and never again, because the conversion of the vine's colours relied on the vine's param2 to know the correct rotation, but this meant that the rotation could no longer be found after conversion, since the param2 of said vine has since changed by being added to other numbers.

Now, the rotation of the vines even after grabbing the biome's colour is found by trying to subtract certain numbers from the vine until certain numbers are found which would correspond with the correct rotation of said vines.

Before this pull request, vines could only grab the biome's colour once and never again, because the conversion of the vine's colours relied on the vine's `param2` to know the correct rotation, but this meant that the rotation could no longer be found after conversion, since the `param2` of said vine has since changed by being added to other numbers. Now, the rotation of the vines even after grabbing the biome's colour is found by trying to subtract certain numbers from the vine until certain numbers are found which would correspond with the correct rotation of said vines.
Ghost added the
nodes
API
code quality
enhancement
labels 2023-02-24 13:32:35 +01:00
Ghost force-pushed vine_rotation_calculation from a9f5efcbc0 to a457853938 2023-02-27 21:25:48 +01:00 Compare
Ghost approved these changes 2023-02-28 04:10:44 +01:00
Ghost left a comment
Author
First-time contributor

Works, looks good to me.

Works, looks good to me.
Ghost merged commit 51c374b31f into master 2023-02-28 04:10:59 +01:00
Ghost deleted branch vine_rotation_calculation 2023-02-28 04:11:07 +01:00
Ghost added this to the 0.83.0 - Safe and Sound milestone 2023-02-28 04:11:19 +01:00

Good catch! Thanks for fixing.

Good catch! Thanks for fixing.
Sign in to join this conversation.
No reviewers
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#3480
No description provided.