Fix hungry sheep and hyrdophobic passive mobs #3435

ancientmarinerdev · 2023-02-11T01:38:47+01:00

ancientmarinerdev commented

2023-02-11 01:38:47 +01:00

Originally env_damage was at the end of the mob_step. As we have had issues with missing references, we have moved this to the start so we can escape processing asap. This led to this code running more frequently and breath took almost a second to go rather than 15 and mobs drowned quickly before they floated to surface. Sheep also swapped out blocks more frequently.

Looking into this history of mob_step, a number of things were after this and moved including opinion sounds, and picking up items etc. I've ensure some things aren't processed as frequently. We're still using the same timer but we do need to change this soon to avoid piggybacking and any issues that could come from this.

Testing

Mobs spawned high above water no longer die on submerge

Sheep are less peckish.

Mobs are less jittery on edge of water

Opinion sound is a little less painful.

Fixes #3432 Fixes #3428 Originally env_damage was at the end of the mob_step. As we have had issues with missing references, we have moved this to the start so we can escape processing asap. This led to this code running more frequently and breath took almost a second to go rather than 15 and mobs drowned quickly before they floated to surface. Sheep also swapped out blocks more frequently. Looking into this history of mob_step, a number of things were after this and moved including opinion sounds, and picking up items etc. I've ensure some things aren't processed as frequently. We're still using the same timer but we do need to change this soon to avoid piggybacking and any issues that could come from this. ### Testing Mobs spawned high above water no longer die on submerge Sheep are less peckish. Mobs are less jittery on edge of water Opinion sound is a little less painful.

👍 2 ❤️ 1 🚀 1

ancientmarinerdev added 1 commit 2023-02-11 01:38:52 +01:00

2fd7f8c69f Fix hungry sheep and hyrdophobic passive mobs

ancientmarinerdev referenced this pull request

2023-02-11 01:47:33 +01:00

[WIP] env_damage fires too often, sheep eat landscape #3434

ancientmarinerdev changed title from ~~WIP: Fix hungry sheep and hyrdophobic passive mobs~~ to Fix hungry sheep and hyrdophobic passive mobs

2023-02-11 02:19:14 +01:00

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-02-11 11:26:01 +01:00

ancientmarinerdev merged commit 35a75491f4 into master

2023-02-11 11:26:21 +01:00

ancientmarinerdev referenced this issue from a commit