Make minecart rails unable to be broken with water & lava #3415

SmokeyDope · 2023-02-07T23:27:05+01:00

SmokeyDope commented

2023-02-07 23:27:05 +01:00

This PR Fixes #3136

Water & lava being unable to break rails is correct vanilla mc parity.

Testing

place down some rails and place some water next to them. Do they break? They shouldn't.

This PR Fixes #3136 Water & lava being unable to break rails is correct vanilla mc parity. ### Testing place down some rails and place some water next to them. Do they break? They shouldn't.

Michieal commented

2023-02-08 00:04:30 +01:00

Awesome! Thank you for making this. :)

It blocks the fluid's flow too, right?

Awesome! Thank you for making this. :) It blocks the fluid's flow too, right?

SmokeyDope commented

2023-02-08 00:24:00 +01:00

Awesome! Thank you for making this. :)

It blocks the fluid's flow too, right?

It sure does!

> Awesome! Thank you for making this. :) > > It blocks the fluid's flow too, right? It sure does!

Screenshot from 2023-02-07 18-23-27.png

716 KiB

❤️ 1

SmokeyDope changed title from ~~Make minecart rails unable to be broken with water~~ to Make minecart rails unable to be broken with water & lava

2023-02-08 00:26:19 +01:00

ancientmarinerdev force-pushed minecart_track_water_breaking_3 from f466526c57 to 71671f8b5f

2023-02-09 02:54:02 +01:00

Compare

ancientmarinerdev approved these changes 2023-02-09 02:55:52 +01:00

ancientmarinerdev left a comment

2 commits for a 1 line change... really?!

We're not giving out prizes for commits. Whoever is reading version history probably won't be amused.

Anyway, MC has some really weird features. Thanks for fixing this :).

2 commits for a 1 line change... really?! We're not giving out prizes for commits. Whoever is reading version history probably won't be amused. Anyway, MC has some really weird features. Thanks for fixing this :).

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-02-09 02:56:27 +01:00

SmokeyDope commented

2023-02-09 03:01:45 +01:00

It slipped my mind that lava needed to be changed too until just after I commited water, what can I say ¯_(ツ)_/¯

Point taken.

(Besides its not like anyones reading version history anyway that things like the necronomicon, by the time you can read it fluently your already crazy.)

It slipped my mind that lava needed to be changed too until just after I commited water, what can I say ¯\_(ツ)_/¯ Point taken. (Besides its not like anyones reading version history anyway that things like the necronomicon, by the time you can read it fluently your already crazy.)

ancientmarinerdev referenced this issue from a commit

2023-02-09 03:03:52 +01:00

Merge pull request 'Make minecart rails unable to be broken with water & lava' (#3415) from minecart_track_water_breaking_3 into master

ancientmarinerdev merged commit 088cda4f1c into master

2023-02-09 03:03:53 +01:00

ancientmarinerdev deleted branch minecart_track_water_breaking_3

2023-02-09 03:04:10 +01:00

ancientmarinerdev commented

2023-02-09 03:05:53 +01:00

It slipped my mind that lava needed to be changed too until just after I commited water, what can I say ¯_(ツ)_/¯

Point taken.

(Besides its not like anyones reading version history anyway that things like the necronomicon, by the time you can read it fluently your already crazy.)

Ah, fair enough. Mistakes happen :).

I actually read it a lot. I use IntelliJ, and I often right click and git history on a file to see what people did and why. If you do a git blame first on a line that baffles you, and then a git history, you can get into the mind of the person who coded it.

Sometimes though, you really wish you didn't ;).

Version history is very useful! Especially when things regress and break.

> It slipped my mind that lava needed to be changed too until just after I commited water, what can I say ¯\_(ツ)_/¯ > > Point taken. > > (Besides its not like anyones reading version history anyway that things like the necronomicon, by the time you can read it fluently your already crazy.) > > Ah, fair enough. Mistakes happen :). I actually read it a lot. I use IntelliJ, and I often right click and git history on a file to see what people did and why. If you do a git blame first on a line that baffles you, and then a git history, you can get into the mind of the person who coded it. Sometimes though, you really wish you didn't ;). Version history is very useful! Especially when things regress and break.

😆 1

Sign in to join this conversation.

No reviewers