Fix "mcl_core:dirt_with_dry_grass" to be "mcl_core:dirt_with_grass" with the savanna color index. #3408

Michieal · 2023-02-06T03:21:43+01:00

Michieal commented

2023-02-06 03:21:43 +01:00

Tell us about your pull request! Reference related issues, if necessary

This PR fixes #2117
And, this PR fixes #676 (even though it is closed, the "fix" didn't work as expected.)

Testing

Tell us how to test your changes!

Have an old world, and use this to fix the node. look for unknown nodes / nodes with no texture.

Tell us about your pull request! Reference related issues, if necessary This PR fixes #2117 And, this PR fixes #676 (even though it is closed, the "fix" didn't work as expected.) ### Testing Tell us how to test your changes! Have an old world, and use this to fix the node. look for unknown nodes / nodes with no texture.

👍 1

Michieal added 1 commit 2023-02-06 03:21:50 +01:00

de00b7228e Fix "mcl_core:dirt_with_dry_grass" to be "mcl_core:dirt_with_grass" with the savanna color index.

kneekoo commented

2023-02-06 20:42:55 +01:00

I still get these with the updated code.

I still get these with the updated code. ![no texture in an old world](https://i.imgur.com/Ruht4Iq.jpg)

ancientmarinerdev commented

2023-02-06 21:51:58 +01:00

I still get these with the updated code.

I'm wondering if it's because it already ran on your world.

run_at_every_load = false,

may help locally. It would need a later version number if that bit after block name is game version.

If it thinks it's run, it'll probably not try again.

You can try:

minetest.log("action", "Lbm running")

If you want to see if it's triggering. Reeeee!!11!!

> I still get these with the updated code. > > ![no texture in an old world](https://i.imgur.com/Ruht4Iq.jpg) I'm wondering if it's because it already ran on your world. run_at_every_load = false, may help locally. It would need a later version number if that bit after block name is game version. If it thinks it's run, it'll probably not try again. You can try: minetest.log("action", "Lbm running") If you want to see if it's triggering. Reeeee!!11!!

Michieal commented

2023-02-06 22:50:11 +01:00

I can change it to run at every load. Since it's replacing nodes, it should have a seriously reduced performance hit, than say an lbm that runs at every load that doesn't swap out nodes. That should fix any existing nodes that the old version ran on previously.

I can change it to run at every load. Since it's replacing nodes, it should have a seriously reduced performance hit, than say an lbm that runs at every load that *doesn't* swap out nodes. That *should* fix any existing nodes that the old version ran on previously.

👍 1

Michieal added 1 commit 2023-02-06 22:55:17 +01:00

ec7a97ba3e Made LBM run at every load, so that it catches anything missed from previous passes.

Michieal added 1 commit 2023-02-06 22:56:24 +01:00

0e000e6491 Merge branch 'master' into fix_dirt_dry_grass

ancientmarinerdev commented

2023-02-09 03:51:04 +01:00

I can change it to run at every load. Since it's replacing nodes, it should have a seriously reduced performance hit, than say an lbm that runs at every load that doesn't swap out nodes. That should fix any existing nodes that the old version ran on previously.

Fair points, it looks good. It would be good to get feedback from Nicu or someone who has this issue first then I'm happy to merge.

> I can change it to run at every load. Since it's replacing nodes, it should have a seriously reduced performance hit, than say an lbm that runs at every load that *doesn't* swap out nodes. That *should* fix any existing nodes that the old version ran on previously. Fair points, it looks good. It would be good to get feedback from Nicu or someone who has this issue first then I'm happy to merge.

❤️ 1

kneekoo commented

2023-02-10 03:18:30 +01:00

Fixed, thanks a lot! :D

❤️ 1

ancientmarinerdev approved these changes 2023-02-10 03:48:22 +01:00

ancientmarinerdev left a comment

Awesome stuff. Simple yet effective and another happy customer :).

Thanks for fixing this.

Awesome stuff. Simple yet effective and another happy customer :). Thanks for fixing this.

❤️ 1

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-02-10 03:50:10 +01:00