remove "mushroom" from the names of crimson fungus and warped fungus #3406

SmokeyDope · 2023-02-06T01:30:47+01:00

SmokeyDope commented

2023-02-06 01:30:47 +01:00

The names of crimson fungus and warped fungus are incorrect. Currently they are called "crimson fungus mushroom" and "warped fungus mushroom". "mushroom" should not be there.

Testing

go into creative and pull up the items. What are they called? you'll probably see "mushroom", at the end.

The names of crimson fungus and warped fungus are incorrect. Currently they are called "crimson fungus mushroom" and "warped fungus mushroom". "mushroom" should not be there. ### Testing go into creative and pull up the items. What are they called? you'll probably see "mushroom", at the end.

👍 1

kneekoo commented

2023-02-06 01:54:52 +01:00

The change makes sense. The downside is that with this we won't be able to bring up all of these in the creative search results by typing "mushroom". So having "Mushroom" in the name wasn't the right solution, just one of convenience.

If possible, we should introduce a tag/property for items, so we can have the right names, but also easily find similar items. I recently assumed "fish" would bring up all the fish-related stuff in creative mode, but that wasn't the case. :)

The change makes sense. The downside is that with this we won't be able to bring up all of these in the creative search results by typing "mushroom". So having "Mushroom" in the name wasn't the right solution, just one of convenience. If possible, we should introduce a tag/property for items, so we can have the right names, but also easily find similar items. I recently assumed "fish" would bring up all the [fish-related stuff](#3276) in creative mode, but that wasn't the case. :)

🚀 1

SmokeyDope commented

2023-02-06 02:02:50 +01:00

I like that idea, something similar to groups but explicitly for creative search phrases. something like
creative_search = S{"plant", "mushroom", "decoration", "nether"}

edit: or just put the names in the tool tip like so

	_tt_help = S("Crimson fungus is a mushroom found in the nether's crimson forest."),
	_doc_items_longdesc = S("Crimson fungus is a mushroom found in the nether's crimson forest."),

Sometimes I feel like a big dummy haha. TY michieal and PrarieWind!

I like that idea, something similar to groups but explicitly for creative search phrases. something like creative_search = S{"plant", "mushroom", "decoration", "nether"} edit: or just put the names in the tool tip like so ``` _tt_help = S("Crimson fungus is a mushroom found in the nether's crimson forest."), _doc_items_longdesc = S("Crimson fungus is a mushroom found in the nether's crimson forest."), ``` Sometimes I feel like a big dummy haha. TY michieal and PrarieWind!

👍 2 ❤️ 1

SmokeyDope commented

2023-02-06 02:28:13 +01:00

Im not sure how to impliment something like that, but if someone figures it out I am willing to commit the time to go through and add that stuff to nodes

👍 2

SmokeyDope closed this pull request

2023-02-06 02:28:16 +01:00

SmokeyDope reopened this pull request

2023-02-06 02:49:29 +01:00

SmokeyDope commented

2023-02-06 02:51:39 +01:00

Oh so thats what the close button does lol whoops

👍 1 😆 2

Michieal commented

2023-02-06 04:26:39 +01:00

Yeah, don't do that. lmao!

Michieal commented

2023-02-06 08:35:16 +01:00

I like that idea, something similar to groups but explicitly for creative search phrases. something like
creative_search = S{"plant", "mushroom", "decoration", "nether"}

Search "job" in creative. Note that the Lectern comes up. Hover over the lectern, to see where the word "job" is at. Apply that to existing items that should be tagged. Thank me when done. :D

edit: to be fair, I did say how to do it here.

> I like that idea, something similar to groups but explicitly for creative search phrases. something like > creative_search = S{"plant", "mushroom", "decoration", "nether"} Search "job" in creative. Note that the Lectern comes up. Hover over the lectern, to see where the word "job" is at. Apply that to existing items that should be tagged. Thank me when done. :D edit: to be fair, I did say how to do it [here](https://git.minetest.land/MineClone2/MineClone2/issues/3276#issuecomment-57967).

🚀 1

Ghost commented

2023-02-06 18:25:42 +01:00

First-time contributor

~~Put mushroom in the tooltip.~~

~~Put mushroom in the tooltip.~~

🚀 2

SmokeyDope commented

2023-02-06 18:28:12 +01:00

Im on it, thanks for the recommendation

👍 1

ancientmarinerdev approved these changes 2023-02-09 02:28:15 +01:00

ancientmarinerdev left a comment

It looks good to me. You haven't been around too long, but so far, I think you are a fun-gi!

🎉 2 😆 3

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-02-09 04:22:03 +01:00

ancientmarinerdev force-pushed change_fungus_name from 8ea869e930 to dfbee5cb93

2023-02-09 04:22:26 +01:00

Compare

Ghost commented

2023-02-09 19:16:29 +01:00

First-time contributor

@SmokeyDope would you like to hit the green create merge commit button?

Ghost approved these changes 2023-02-09 19:17:16 +01:00

Ghost left a comment

First-time contributor

Looks good to me 👍.

ancientmarinerdev referenced this issue from a commit

2023-02-09 19:22:07 +01:00

Merge pull request 'remove "mushroom" from the names of crimson fungus and warped fungus' (#3406) from SmokeyDope/MineClone2:change_fungus_name into master

ancientmarinerdev merged commit 428b1b2c12 into master

2023-02-09 19:22:07 +01:00

Ghost commented

2023-02-09 19:24:09 +01:00

First-time contributor

Nothing like taking the fun out of it. I was really excited to merge my first pull request when I got merge privs. :(

😆 1

ancientmarinerdev commented

2023-02-09 19:24:33 +01:00

@SmokeyDope would you like to hit the green create merge commit button?

I'm not sure if he has the access at present. He has contributor status. I think only developer status has that.

To be honest, I would prefer to be the one doing the merging. I want to know what is going in and when. I want to make sure it's tagged correctly and if multiple people are working on something, I'd prefer the bigger one going in first, especially if the PR was created first. It's harder to deal with merge conflicts for bigger branches.

I had meant to merge in yesterday but the conflict checking is a little slow atm.

> @SmokeyDope would you like to hit the green create merge commit button? I'm not sure if he has the access at present. He has contributor status. I think only developer status has that. To be honest, I would prefer to be the one doing the merging. I want to know what is going in and when. I want to make sure it's tagged correctly and if multiple people are working on something, I'd prefer the bigger one going in first, especially if the PR was created first. It's harder to deal with merge conflicts for bigger branches. I had meant to merge in yesterday but the conflict checking is a little slow atm.

SmokeyDope deleted branch change_fungus_name

2023-02-09 20:57:22 +01:00

Sign in to join this conversation.

No reviewers