VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
60
133
Fork 177
Code Issues 977 Pull Requests 89 Projects 4 Releases Wiki Activity

Extra Breaking Animation Frame #3343

Merged
ancientmarinerdev merged 1 commits from extra_break_animation_frame into master 2023-01-22 16:07:27 +01:00
Conversation 8 Commits 1 Files Changed 1
Ghost commented 2023-01-21 17:44:48 +01:00
First-time contributor
Copy Link

This pull request adds one extra frame to the breaking animation.

This pull request adds one extra frame to the breaking animation.
Ghost added the
graphics
 label 2023-01-21 17:44:48 +01:00
AFCMS commented 2023-01-21 19:16:36 +01:00
Member
Copy Link

Why is this needed? (just curious)

Why is this needed? (just curious)
Ghost commented 2023-01-22 09:11:15 +01:00
Author
First-time contributor
Copy Link

Why is this needed? (just curious)

It has always bugged me that there were only 9 frames in the cracking animation instead of the standard 10.

>Why is this needed? (just curious) It has always bugged me that there were only 9 frames in the cracking animation instead of the standard 10.
kneekoo commented 2023-01-22 11:56:56 +01:00
Contributor
Copy Link

Well, it makes for a (bit) smoother cracking animation, so that's nice. :)

P.S. What could possibly go wrong? :D

Well, it makes for a (bit) smoother cracking animation, so that's nice. :) P.S. What could possibly go wrong? :D
Ghost commented 2023-01-22 14:45:36 +01:00
Author
First-time contributor
Copy Link

Well, it makes for a (bit) smoother cracking animation, so that's nice. :)

P.S. What could possibly go wrong? :D

Well, feel free to approve, then. The pull request is ready, after all.

>Well, it makes for a (bit) smoother cracking animation, so that's nice. :) >P.S. What could possibly go wrong? :D Well, feel free to approve, then. The pull request is ready, after all.
ancientmarinerdev commented 2023-01-22 15:06:33 +01:00
Owner
Copy Link

Why is this needed? (just curious)

It has always bugged me that there were only 9 frames in the cracking animation instead of the standard 10.

Texture pack issue?

> >Why is this needed? (just curious) > > It has always bugged me that there were only 9 frames in the cracking animation instead of the standard 10. Texture pack issue?
AFCMS approved these changes 2023-01-22 15:48:51 +01:00
AFCMS left a comment
Member
Copy Link

There are 10 frames in MC

Will allow better texturepack compatibility

There are 10 frames in MC Will allow better texturepack compatibility
👍 1
ancientmarinerdev commented 2023-01-22 15:59:06 +01:00
Owner
Copy Link

I think frames 1 and 2 at least were new though they all look like they've changed to my eyes. Where did they come from? Is this your own changes, or from somewhere else?

I think frames 1 and 2 at least were new though they all look like they've changed to my eyes. Where did they come from? Is this your own changes, or from somewhere else?
kneekoo commented 2023-01-22 16:05:46 +01:00
Contributor
Copy Link

The brightness seems like the only difference, plus the crack in the smallest frame, which is either a resized or tweaked frame of the current smallest. Perfectly fine by me. :)

The brightness seems like the only difference, plus the crack in the smallest frame, which is either a resized or tweaked frame of the current smallest. Perfectly fine by me. :)
👍 1
ancientmarinerdev commented 2023-01-22 16:06:24 +01:00
Owner
Copy Link

The brightness seems like the only difference, plus the crack in the smallest frame, which is either a resized or tweaked frame of the current smallest. Perfectly fine by me. :)

Thanks for clarifying. I'll merge.

> The brightness seems like the only difference, plus the crack in the smallest frame, which is either a resized or tweaked frame of the current smallest. Perfectly fine by me. :) Thanks for clarifying. I'll merge.
ancientmarinerdev force-pushed extra_break_animation_frame from 1ce786b31c to b6951d00b9 2023-01-22 16:06:59 +01:00 Compare
ancientmarinerdev merged commit ad9beebc70 into master 2023-01-22 16:07:27 +01:00
ancientmarinerdev deleted branch extra_break_animation_frame 2023-01-22 16:07:34 +01:00
ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-01-22 16:07:52 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
AFCMS
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
0.83.0 - Safe and Sound
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#3343
No description provided.
Delete Branch "extra_break_animation_frame"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?