Nether & End Biome Sky/Fog Colours #3342

Ghost · 2023-01-20T16:51:20+01:00

Ghost commented

2023-01-20 16:51:20 +01:00

First-time contributor

This pull request finally allows for the Nether & the End to have biome specific sky colours and/or fog colours.

Previously, it was only the overworld biomes that had this feature fully implemented.

This pull request finally allows for the Nether & the End to have biome specific sky colours and/or fog colours. Previously, it was only the overworld biomes that had this feature fully implemented.

Ghost added 2 commits 2023-01-20 16:51:25 +01:00

f6a3fe2128 Make Nether & End use biome sky- or fog colours

a1ad84370c Move locals upward & uncomment some things

Some locals relating to the biome sky colours and fog colours have been moved upward since there otherwise were some issues.

The sky colours and fog colours of the Nether & End biomes have also been uncommented.

Ghost added the

mapgen

API

Testing / Retest

labels 2023-01-20 17:21:06 +01:00

Ghost added 1 commit 2023-01-24 08:21:52 +01:00

7712c45c4e Fix conflict

Ghost added 1 commit 2023-01-24 08:22:12 +01:00

f84bdbd777 Merge branch 'master' into biome_skycolor_otherworlds

Ghost added 1 commit 2023-01-24 08:27:40 +01:00

f3bed9f599 Move locals upward & uncomment some things (again)

Ghost requested review from ancientmarinerdev 2023-01-24 14:32:32 +01:00

ancientmarinerdev commented

2023-01-26 00:08:59 +01:00

The code looks like an improvement, but after testing, I'm not sure if I can see any difference. I'm not too good with look and feel changes. Does this change anything?

Ghost commented

2023-01-26 09:26:43 +01:00

First-time contributor

The code looks like an improvement, but after testing, I'm not sure if I can see any difference. I'm not too good with look and feel changes. Does this change anything?

Well, all it does is make the biomes in the Nether & the End use the sky colours and fog colours system that the overworld currently uses.

The biomes in the Nether & End already had sky and/or fog colours, but they weren't given via the biome sky and/or fog colour API. Now they are.

>The code looks like an improvement, but after testing, I'm not sure if I can see any difference. I'm not too good with look and feel changes. Does this change anything? Well, all it does is make the biomes in the Nether & the End use the sky colours and fog colours system that the overworld currently uses. The biomes in the Nether & End already had sky and/or fog colours, but they weren't given via the biome sky and/or fog colour API. Now they are.

ancientmarinerdev approved these changes 2023-01-26 23:49:22 +01:00

ancientmarinerdev left a comment

Ok, thanks for explaining. The code is an improvement, so that's a good thing. I've tested it and I have not seen any issues. I usually prefer to see changes that add to the gameplay/look and feel in PR's. "Code quality" changes on their own just feel like creating risk without the benefit to users to justify it. I don't usually refactor code unless I'm going to add something extra in the area and it justifies it to do it at that point (ideally in separate commits, of course).

Hopefully, you have something in mind.

Ok, thanks for explaining. The code is an improvement, so that's a good thing. I've tested it and I have not seen any issues. I usually prefer to see changes that add to the gameplay/look and feel in PR's. "Code quality" changes on their own just feel like creating risk without the benefit to users to justify it. I don't usually refactor code unless I'm going to add something extra in the area and it justifies it to do it at that point (ideally in separate commits, of course). Hopefully, you have something in mind.

👍 1

ancientmarinerdev referenced this issue from a commit

2023-01-26 23:49:57 +01:00

Merge pull request 'Nether & End Biome Sky/Fog Colours' (#3342) from biome_skycolor_otherworlds into master

ancientmarinerdev merged commit 63360bcab2 into master

2023-01-26 23:49:57 +01:00

ancientmarinerdev deleted branch biome_skycolor_otherworlds

2023-01-26 23:50:14 +01:00

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-01-26 23:50:44 +01:00

Ghost referenced this pull request

2023-02-18 17:58:47 +01:00

Sky colour should change depending on biome temperature #2808