Add bookshelves and anvils as structure constructed nodes #3133

Ghost · 2022-12-15T04:22:32+01:00

Ghost commented

2022-12-15 04:22:32 +01:00

First-time contributor

Bookshelves and anvils that are generated in structures are unusable. This PR fixes that issue.

Testing

On master, see how bookshelves in woodland outposts and anvils in pillager outposts are unusable. Also notice in the woodland outposts that there is a double chest in the farm room that doesn't work. On branch, confirm that they are usable now. Confirm that pillager outpost wall nodes are built and connect correctly. Also confirm that the barrels that replace the double chests in the woodland outpost work.

Issues Fixed

This PR Fixes #3130

Bookshelves and anvils that are generated in structures are unusable. This PR fixes that issue. ### Testing On master, see how bookshelves in woodland outposts and anvils in pillager outposts are unusable. Also notice in the woodland outposts that there is a double chest in the farm room that doesn't work. On branch, confirm that they are usable now. Confirm that pillager outpost wall nodes are built and connect correctly. Also confirm that the barrels that replace the double chests in the woodland outpost work. ### Issues Fixed This PR Fixes #3130

❤️ 1 🚀 1

Ghost force-pushed structure_construct_nodes from 0021a2bade to 3c0d68c7a0

2022-12-15 23:46:37 +01:00

Compare

Ghost force-pushed structure_construct_nodes from 0025c62fa2 to 18ab5015e3

2022-12-16 02:48:09 +01:00

Compare

ancientmarinerdev reviewed 2022-12-19 00:56:02 +01:00

mods/MAPGEN/mcl_structures/pillager_outpost.lua Outdated

					
				@ -69,2 +70,3 @@

						mcl_structures.spawn_mobs("mobs_mc:iron_golem",{"mesecons_button:button_stone_off"},p1,p2,pr,1)

						mcl_structures.construct_nodes(p1,p2,{"group:wall"})

						for _,n in pairs(minetest.find_nodes_in_area(p1,p2,{"group:wall"})) do

							local def = minetest.registered_nodes[minetest.get_node(n).name:gsub("_%d+$","")]

ancientmarinerdev commented

2022-12-19 00:56:02 +01:00

Out of curiosity, what does this change do? I see for the other changes, it calls on_construct for bookshelf and anvil, but why is this done for the walls?

What issue was there previously with walls?

Out of curiosity, what does this change do? I see for the other changes, it calls on_construct for bookshelf and anvil, but why is this done for the walls? What issue was there previously with walls?

Ghost commented

2022-12-19 02:03:42 +01:00

First-time contributor

Whoops wrong button. Anyway, its the old code that makes the wall nodes in the pillager outpost actually connect. The mcl_structures.construct_nodes function wasnt working, probably due to the amount of wall nodes, so I replaced it with the old working code. If you were to spawnstruct a pillager outpost (the one without the outside cages) in certain spots, the rotation of the schematic messes up the wall nodes, so this makes sure that they connect every time no matter the spot.

ancientmarinerdev commented

2022-12-19 02:13:32 +01:00

Ah, I see. Thanks for explaining that!

Ghost marked this conversation as resolved