Fish buckets save and restore object properties in item entity #3013

cora · 2022-11-25T04:03:18+01:00

cora commented

2022-11-25 04:03:18 +01:00

This refactors / rewrites the fish bucket code to not use the bucket api at all – it was clearly not made for this kind of thing. It also puts it in a separate file in mcl_buckets.

If the properties metadata field is set on the bucket item, the placing will set the object properties from that after spawn.

Correspondingly axolotls and tropical fish set this meta field on_rightclick bucket pickup.

This way the textures and other properties (mesh is also important for t-fish) are persistent over bucket transfers.

This PR fixes #3008
This PR fixes #3006

This refactors / rewrites the fish bucket code to not use the bucket api at all – it was clearly not made for this kind of thing. It also puts it in a separate file in mcl_buckets. If the properties metadata field is set on the bucket item, the placing will set the object properties from that after spawn. Correspondingly axolotls and tropical fish set this meta field on_rightclick bucket pickup. This way the textures and other properties (mesh is also important for t-fish) are persistent over bucket transfers. This PR fixes #3008 This PR fixes #3006

👍 1

Ghost commented

2022-11-25 04:48:08 +01:00

First-time contributor

Should it check for flowing river water too?

cora commented

2022-11-25 13:51:54 +01:00

should it check for flowing normal water ? It would only even make a difference when theres flowing river water and ground directly beneath it which i dont think really occurs naturally.

Michieal commented

2022-11-25 15:06:23 +01:00

What about when players make an aquarium, to put the aquatics in? That could be river water... depending on mapgen.

cora commented

2022-11-25 15:13:16 +01:00

so when they release a fish from a bucket and there is only flowing river water it would place a normal water source .. sounds ok to me - it seems unlikely anyone would make a river water aquarium in the first place if only for the sheer work that means bc river water isn't renewable.

Michieal commented

2022-11-25 15:15:42 +01:00

I was thinking the valley mapgen players. riverwater would be common. but replacing the river water with regular water would be okay imho.

cora commented

2022-11-25 15:28:32 +01:00

it would still be a huge pain to get all that river water for your aquarium as you'd have to manually transport every single source. It does not replicate like normal water does.

👍 1

Michieal commented

2022-11-25 15:58:55 +01:00

I see your point, even though my brain immediately retorted "oh, kinda like going down and mining 800 deepslate to build a castle..." lol.

The amount of buckets needed to do that would probably make it too much work for most players, so I see what you say. And they would probably exhaust any nearby water sources.

I see your point, even though my brain immediately retorted "oh, kinda like going down and mining 800 deepslate to build a castle..." lol. The amount of buckets needed to do that would probably make it too much work for most players, so I see what you say. And they would probably exhaust any nearby water sources.

cora commented

2022-11-26 02:26:36 +01:00

I've made it so you can place it in flowing river water. But not take from it to prevent unintended water dupe.

cora referenced this pull request

2022-11-26 02:29:47 +01:00

Release 0.81.0 #2952

Ghost commented

2022-11-26 03:56:39 +01:00

First-time contributor

Seems the meta data is saved to the empty buckets and they no longer stack, and the unlimited water placement in creative is broken again.

👍 1

cora commented