Sweet berries: Add rightclick harvesting #2971

cora · 2022-11-16T03:00:41+01:00

cora commented

2022-11-16 03:00:41 +01:00

This PR fixes #2885

rightclick a a grown sweetberry bush
watch it drop sweet berries and degrow

This PR fixes #2885 * rightclick a a grown sweetberry bush * watch it drop sweet berries and degrow

🎉 2

Ghost commented

2022-11-16 04:53:06 +01:00

First-time contributor

Seems to conflict with bonemealing, but otherwise, works as advertised.

cora commented

2022-11-16 05:57:26 +01:00

mmmmh yeah ig that needs to be fixed

cora commented

2022-11-16 17:26:58 +01:00

fixed .. although mcl_dye is really dumb ... it has all the bonemealing for plants individually hardcoded - and depends on mcl_farming

this should be untangled some time.

fixed .. although mcl_dye is really dumb ... it has all the bonemealing for plants individually hardcoded - and depends on mcl_farming this should be untangled some time.

cora force-pushed sweet_berries from 476251eddc to fa0038805c

2022-11-16 17:27:31 +01:00

Compare

Ghost commented

2022-11-17 20:22:51 +01:00

First-time contributor

Well, kabou started work on a bonemeal api before he disappeared, hopefully that will get finished someday.

cora commented

2022-11-17 20:34:15 +01:00

probably easier to redo it though than to try and figure out what they were doing on an old version of the code.

Ghost force-pushed sweet_berries from fa0038805c to 142f3d6d5a

2022-11-17 20:42:09 +01:00

Compare

Ghost approved these changes 2022-11-17 20:48:17 +01:00

Ghost left a comment

First-time contributor

Works. Looks good, and I like the bonemeal harvest mechanic.

Ghost merged commit eaccd71558 into master

2022-11-17 20:48:32 +01:00

Ghost referenced this issue from a commit

2022-11-17 20:48:32 +01:00

Merge pull request 'Sweet berries: Add rightclick harvesting' (#2971) from sweet_berries into master

Ghost deleted branch sweet_berries

2022-11-17 20:48:41 +01:00

Michieal commented

2022-11-18 03:17:31 +01:00

A registered dyes table, like what I used in signs, should probably also be created.
Wools use one thing, colors uses another, etc. That way we can get the color of every dye past, present, future...

A registered dyes table, like what I used in signs, should probably also be created. Wools use one thing, colors uses another, etc. That way we can get the color of every dye past, present, future...

Sign in to join this conversation.

No reviewers