Add colors.txt file to tools/ #2953

cora · 2022-11-15T02:54:17+01:00

cora commented

2022-11-15 02:54:17 +01:00

As provided by RankoSaotome on mcl2 discord

👍 2 ❤️ 1 🚀 1

AFCMS commented

2022-11-15 08:29:04 +01:00

Maybe we could make updating it a part of the release process?

Ghost commented

2022-11-15 09:16:42 +01:00

First-time contributor

What does said "colors.txt" file do exactly?

👍 1

MrRar commented

2022-11-15 15:04:35 +01:00

What is this and how does it relate to colors.json in mcl_maps?

cora commented

2022-11-15 15:38:40 +01:00

I don't think making the release process even more complicated is a good idea. Plus this would require to take note of all nodes added as well (yk additionally to the stuff you already need to keep track of).

I think it's absolutely fine if whoever adds nodes or whoever uses minetestmapper adds missing colors (that's what it's for @MrRar) .

I don't think making the release process even more complicated is a good idea. Plus this would require to take note of all nodes added as well (yk additionally to the stuff you already need to keep track of). I think it's absolutely fine if whoever adds nodes or whoever uses minetestmapper adds missing colors (that's what it's for @MrRar) .

❤️ 1

Ghost force-pushed add_colors_txt from ad08f555aa to 51d4f075b2

2022-11-15 23:13:07 +01:00

Compare

Ghost approved these changes 2022-11-15 23:16:24 +01:00

Ghost merged commit 4255143087 into master

2022-11-15 23:16:55 +01:00

Ghost referenced this issue from a commit

2022-11-15 23:16:58 +01:00

Merge pull request 'Add colors.txt file to tools/' (#2953) from add_colors_txt into master

Ghost deleted branch add_colors_txt

2022-11-15 23:16:59 +01:00

Michieal commented

2022-11-16 06:25:20 +01:00

What does said "colors.txt" file do exactly?

It is used for the Minetest Mapper program. The mapper program uses it to color pixels in the output image that it makes, after scanning all of the nodes that you've explored / loaded. (Ie, that the engine has generated / changed.)

What is this and how does it relate to colors.json in mcl_maps?

Not related to colors.json in mcl_maps, though we might want to be update that as we add new nodes. Though, depending on formats, we might be able to use the colors.txt to quickly update colors.json.

the minetest mapper program has a utility to generate a colors.txt, but it will usually use the one in the main minetest dir in your /usr/bin/ dir. Problems with this, though, include the fact that it does NOT take into account for how we color the textures in code. A primary example of this is that the grass is grey, even though it's green when the node is registered.

Another good example is that things like water logged nodes are going to be off as they are multi-textured.

That said, this is a popular utility that players use to see where they have been and have explored.

> What does said "colors.txt" file do exactly? It is used for the Minetest Mapper program. The mapper program uses it to color pixels in the output image that it makes, after scanning all of the nodes that you've explored / loaded. (Ie, that the engine has generated / changed.) > What is this and how does it relate to colors.json in mcl_maps? Not related to colors.json in mcl_maps, though we might want to be update that as we add new nodes. Though, depending on formats, we might be able to use the colors.txt to quickly update colors.json. the minetest mapper program has a utility to generate a colors.txt, but it will usually use the one in the main minetest dir in your /usr/bin/ dir. Problems with this, though, include the fact that it does *NOT* take into account for how we color the textures in code. A primary example of this is that the grass is grey, even though it's green when the node is registered. Another good example is that things like water logged nodes are going to be off as they are multi-textured. That said, this is a popular utility that players use to see where they have been and have explored.

👍 1

Sign in to join this conversation.

No reviewers