Fix boss bars scaling issue with non 16x texture packs #2767

As there do not seem to be any available publicly, someone who actually has a non 16px texture pack test these from now please. All I can say it does not appear to break the default textures.

cora commented

2022-10-13 16:45:50 +02:00

And no before a certain someone posts a link to mtg texture packs: those do not help here. We need mcl2 specific textures as mtg does not have any bossbars

cora commented

2022-10-13 16:50:19 +02:00

I mean another option for your texture packs not to get messed up is to not include the textures that do get messed up like bossbars ...

Ghost commented

2022-10-13 18:01:45 +02:00

First-time contributor

I have tested it out, and it seems like there is some weird stretching issue going on with the bossbars for some weird reason.

In any case, this is much better than the oversized bossbars that would go outside of the screen.

I have tested it out, and it seems like there is some weird stretching issue going on with the bossbars for some weird reason. In any case, this is much better than the oversized bossbars that would go outside of the screen.

Bossbar Wither.png

900 KiB

Bossbar Dragon.png

1.3 MiB

talamh commented

2022-10-13 18:40:07 +02:00

I have tested it out, and it seems like there is some weird stretching issue going on with the bossbars for some weird reason.

In any case, this is much better than the oversized bossbars that would go outside of the screen.

Do your mcl_bossbars.png and mcl_bossbars_empty.png images have the same dimensions?

Also they must have the aspect ratio 70:182 same as the originals.

> I have tested it out, and it seems like there is some weird stretching issue going on with the bossbars for some weird reason. > > In any case, this is much better than the oversized bossbars that would go outside of the screen. Do your mcl_bossbars.png and mcl_bossbars_empty.png images have the same dimensions? Also they must have the aspect ratio 70:182 same as the originals.

Ghost commented

2022-10-13 18:59:12 +02:00

First-time contributor

No, they do not, but this is an issue on the texture pack's end, and not mine.

After all, they were designed with MineCraft in mind, which uses a different method of displaying a lot of GUI elements.

But after using a different texture pack's bossbars, which DO use the 70:182 dimensions, it seems to all look fine, except for the corners being weird, but that is something that I can live with.

No, they do not, but this is an issue on the texture pack's end, and not mine. After all, they were designed with MineCraft in mind, which uses a different method of displaying a lot of GUI elements. But after using a different texture pack's bossbars, which DO use the 70:182 dimensions, it seems to all look fine, except for the corners being weird, but that is something that I can live with.

DokuCraft BossBar.png

1.3 MiB

talamh commented

2022-10-13 19:07:31 +02:00

No, they do not. This is an issue on the texture pack's end, and not mine.

After all, they were designed with MineCraft in mind, which uses a different method of displaying a lot of GUI elements, and they thus do not need to worry about scaling issues, as MineCraft takes care of them.

But after using a different texture pack's bossbars, which DO use the 70:182 dimensions, it seems to all look fine, except for the corners being weird, but that is something that I can live with.

What is the name of the texture pack that is causing the issue?

> No, they do not. This is an issue on the texture pack's end, and not mine. > > After all, they were designed with MineCraft in mind, which uses a different method of displaying a lot of GUI elements, and they thus do not need to worry about scaling issues, as MineCraft takes care of them. > > But after using a different texture pack's bossbars, which DO use the 70:182 dimensions, it seems to all look fine, except for the corners being weird, but that is something that I can live with. What is the name of the texture pack that is causing the issue?

Ghost commented

2022-10-13 19:14:57 +02:00

First-time contributor

Just Faithful (Complaince) 32X Original, found here: https://faithfulpack.net/faithful32x/latest

The problem with the bossbars is that they are slimmer in this texture pack, which causes scaling issues.

Just Faithful (Complaince) 32X Original, found here: https://faithfulpack.net/faithful32x/latest The problem with the bossbars is that they are slimmer in this texture pack, which causes scaling issues.

talamh added 1 commit 2022-10-13 21:03:52 +02:00

07e419905b Fixed typo in image resizing in bossbars

talamh commented

2022-10-13 21:09:03 +02:00

Just Faithful (Complaince) 32X Original, found here: https://faithfulpack.net/faithful32x/latest

The problem with their bossbars is that they are slimmer, which causes scaling issues.

I'd made a typo in the rescaling, a set of parenthesis got lost somewhere along the way. All works as intended now:

> Just Faithful (Complaince) 32X Original, found here: https://faithfulpack.net/faithful32x/latest > > The problem with their bossbars is that they are slimmer, which causes scaling issues. I'd made a typo in the rescaling, a set of parenthesis got lost somewhere along the way. All works as intended now: ![](https://i.imgur.com/JdIaxid.png) ![](https://i.imgur.com/fM3aKkc.png)

👍 1

cora commented

2022-10-13 21:18:06 +02:00

if it's in the same branch it should automatically update ... this commit made it anyways:

07e419905b

if it's in the same branch it should automatically update ... this commit made it anyways: https://git.minetest.land/MineClone2/MineClone2/commit/07e419905bdbcf5718ff7e61121cab1bf0bde04b

talamh commented

2022-10-13 21:24:43 +02:00

if it's in the same branch it should automatically update ... this commit made it anyways:

07e419905b

Yes that's the commit, thanks.

> if it's in the same branch it should automatically update ... this commit made it anyways: > > https://git.minetest.land/MineClone2/MineClone2/commit/07e419905bdbcf5718ff7e61121cab1bf0bde04b Yes that's the commit, thanks.

Ghost commented

2022-10-13 21:33:48 +02:00

First-time contributor

This is going to seem a bit off-topic, but I have noticed in your screenshots that the grass block shadows have not been changed at all to fit with the texture packs that you use.

In case you were wondering, the MineCraft equivalent to mcl_dirt_grass_shadow.png is supposed to be grass_block_side.png

I do apologise, if you kept the Pixel Perfection shadows on purpose.

This is going to seem a bit off-topic, but I have noticed in your screenshots that the grass block shadows have not been changed at all to fit with the texture packs that you use. In case you were wondering, the MineCraft equivalent to mcl_dirt_grass_shadow.png is supposed to be grass_block_side.png I do apologise, if you kept the Pixel Perfection shadows on purpose.

talamh commented

2022-10-13 21:52:07 +02:00

This is going to seem a bit off-topic, but I have noticed in your screenshots that the grass block shadows have not been changed at all to fit with the texture packs that you use.

In case you were wondering, the MineCraft equivalent to mcl_dirt_grass_shadow.png is supposed to be grass_block_side.png

I do apologise, if you kept the Pixel Perfection shadows on purpose.

Good spot noticing I'd not converted that texture. My converter has a debug feature that colorizes textures that have been converted, makes it easy to spot most unconverted textures but not that one:

It also prints a list of any MineClone 2 textures that are not modified so I was aware of it just have not gotten around to it yet. Shouldn't be too hard to spot 3 other textures yet to be converted from that screenshot!

> This is going to seem a bit off-topic, but I have noticed in your screenshots that the grass block shadows have not been changed at all to fit with the texture packs that you use. > > In case you were wondering, the MineCraft equivalent to mcl_dirt_grass_shadow.png is supposed to be grass_block_side.png > > I do apologise, if you kept the Pixel Perfection shadows on purpose. Good spot noticing I'd not converted that texture. My converter has a debug feature that colorizes textures that have been converted, makes it easy to spot most unconverted textures but not that one: ![](https://i.imgur.com/CQNnEKw.png) It also prints a list of any MineClone 2 textures that are not modified so I was aware of it just have not gotten around to it yet. Shouldn't be too hard to spot 3 other textures yet to be converted from that screenshot!

👍 1

cora approved these changes 2022-10-16 01:04:42 +02:00

cora left a comment

Well this still doesn't break default textures ^^ I assume it actually works from what has been said ...

cora referenced this issue from a commit

2022-10-16 01:04:54 +02:00

Merge pull request 'Fix boss bars scaling issue with non 16x texture packs' (#2767) from talamh/MineClone2:bossbars_fix into master

cora merged commit efcd0c8dcc into master

2022-10-16 01:04:55 +02:00

Sign in to join this conversation.

No reviewers