Mob Spawn Egg Texture Updates #2702

Merged
cora merged 3 commits from spawn_egg_texture_updates into master 2022-10-04 11:39:59 +02:00
First-time contributor

These changes fix the icon for the Free The End advancement. It also added the new spawn egg textures to spawn egg api function.

Fixes an suggestion/issue discussed in Discord.

These changes fix the icon for the Free The End advancement. It also added the new spawn egg textures to spawn egg api function. Fixes an suggestion/issue discussed in Discord.
Ghost added 3 commits 2022-10-03 20:12:28 +02:00
Member

The only issue with changing the register_egg function is if the turtle egg gets added it has its own texture in Minecraft and isn't made from the greyscale images.

Could have a register_tinted_egg that takes the background and foreground colors, creates the texture modifier and passes it to register_egg. Keeps both options available.

"Update forgotten blaze egg texture definition" Lol my reaction to that was "WTF I grepped the source twice to make sure I hadn't missed any eggs!"

The only issue with changing the register_egg function is if the turtle egg gets added it has its own texture in Minecraft and isn't made from the greyscale images. Could have a register_tinted_egg that takes the background and foreground colors, creates the texture modifier and passes it to register_egg. Keeps both options available. "Update forgotten blaze egg texture definition" Lol my reaction to that was "WTF I grepped the source twice to make sure I hadn't missed any eggs!"
Author
First-time contributor

"Update forgotten blaze egg texture definition" Lol my reaction to that was "WTF I grepped the source twice to make sure I hadn't missed any eggs!"

Lol, sorry, no, that was my own fault, not yours.

"The only issue with changing the register_egg function is if the turtle egg gets added it has its own texture in Minecraft and isn't made from the greyscale images."

O...k? I looked it up on the minecraft wiki. It has a spawn egg, but it also has the normal placable eggs. Basically, turtles and chickens have two ways to spawn manually, but both have standard spawn eggs like every other mob.

> "Update forgotten blaze egg texture definition" Lol my reaction to that was "WTF I grepped the source twice to make sure I hadn't missed any eggs!" > Lol, sorry, no, that was my own fault, not yours. > "The only issue with changing the register_egg function is if the turtle egg gets added it has its own texture in Minecraft and isn't made from the greyscale images." > O...k? I looked it up on the minecraft wiki. It has a spawn egg, but it also has the normal placable eggs. Basically, turtles and chickens have two ways to spawn manually, but both have standard spawn eggs like every other mob.
Member

The turtle egg has a different design to the other spawn eggs:

It is not generated from the greyscale images, it has a full color texture of its own:

The turtle egg has a different design to the other spawn eggs: ![](https://i.imgur.com/VEio9Di.png) It is not generated from the greyscale images, it has a full color texture of its own: ![](https://i.imgur.com/434py7q.png)
Author
First-time contributor

Ok. I personally think it can have a grayscale texture here though.

Ok. I personally think it can have a grayscale texture here though.
Member

Ah I just checked again that turtle egg image is not the turtles spawn egg, my mistake.

Ah I just checked again that turtle egg image is not the turtles spawn egg, my mistake.
cora approved these changes 2022-10-04 11:39:50 +02:00
cora left a comment
Contributor

works

works
cora merged commit 60cfbe4bfe into master 2022-10-04 11:39:59 +02:00
cora deleted branch spawn_egg_texture_updates 2022-10-04 11:40:04 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#2702
No description provided.