VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
57
134
Fork 173
Code Issues 944 Pull Requests 90 Projects 4 Releases Wiki Activity

Added Formspec to Bookshelf #2603

Merged
cora merged 2 commits from bookshelf_inventory into master 2022-08-31 12:02:58 +02:00
Conversation 8 Commits 2 Files Changed 2 +100 -1
Ghost commented 2022-08-29 04:23:59 +02:00
First-time contributor
Copy Link

Adds an inventory to bookshelves, so players can store books in the "normal" storage method for books.

Adds an inventory to bookshelves, so players can store books in the "normal" storage method for books.
👍 1 👎 2 😕 1
Ghost commented 2022-08-29 15:50:55 +02:00
Author
First-time contributor
Copy Link

Hmm...do I need to add a container group at all? If so...which one? It only allows books to freely move into it.

Hmm...do I need to add a container group at all? If so...which one? It only allows books to freely move into it.
Ghost force-pushed bookshelf_inventory from 9530defb32 to 453f4b6cf2 2022-08-30 22:14:05 +02:00 Compare
Ghost force-pushed bookshelf_inventory from 453f4b6cf2 to 8bcf80422d 2022-08-30 23:36:39 +02:00 Compare
Ghost added 1 commit 2022-08-31 01:42:17 +02:00
cora approved these changes 2022-08-31 12:02:45 +02:00
cora left a comment
Contributor
Copy Link

works

works
cora merged commit 7c686c8b79 into master 2022-08-31 12:02:58 +02:00
cora deleted branch bookshelf_inventory 2022-08-31 12:03:05 +02:00
AFCMS commented 2022-08-31 18:08:43 +02:00
Member
Copy Link

but why 😭

this is completly non mc feature

but why :sob: this is completly non mc feature
Ghost commented 2022-08-31 18:50:20 +02:00
Author
First-time contributor
Copy Link

but why 😭

this is completly non mc feature

So? Its a very well wanted and useful feature...why are we so worried about exact Minecraft parity? Its the little things like this that start to set MineClone2 apart from Minecraft and make it better. Besides, why have bookshelves if you can't use them to store books? Doesn't make sense to me at all.

> but why :sob: > > this is completly non mc feature So? Its a very well wanted and useful feature...why are we so worried about **exact** Minecraft parity? Its the little things like this that start to set MineClone2 apart from Minecraft and make it better. Besides, why have bookshelves if you can't use them to store books? Doesn't make sense to me at all.
👍 1
cora commented 2022-08-31 18:59:46 +02:00
Contributor
Copy Link

Oh I thought it is lol. Well doesn't really influence gameplay I guess as its a lot more expensive than universal containers of the same

Oh I thought it is lol. Well doesn't really influence gameplay I guess as its a lot more expensive than universal containers of the same
Ghost commented 2022-08-31 19:00:23 +02:00
Author
First-time contributor
Copy Link

And you can only place books in it.

And you can only place books in it.
cora commented 2022-08-31 19:00:56 +02:00
Contributor
Copy Link

Maybe we should add a setting and make them optional though

Maybe we should add a setting and make them optional though
👍 2
kneekoo commented 2022-08-31 21:23:57 +02:00
Contributor
Copy Link

This might be related. It triggered when I joined a newly created world.

WARNING[Main]: Undeclared global variable "close_gui" accessed at ....minetest/games/mineclone2/mods/ITEMS/mcl_books/init.lua:447
This might be related. It triggered when I joined a newly created world. ``` WARNING[Main]: Undeclared global variable "close_gui" accessed at ....minetest/games/mineclone2/mods/ITEMS/mcl_books/init.lua:447 ```
Ghost commented 2022-08-31 21:48:11 +02:00
Author
First-time contributor
Copy Link

This might be related. It triggered when I joined a newly created world.

WARNING[Main]: Undeclared global variable "close_gui" accessed at ....minetest/games/mineclone2/mods/ITEMS/mcl_books/init.lua:447

One fix coming up @kneekoo.

> This might be related. It triggered when I joined a newly created world. > > ``` > WARNING[Main]: Undeclared global variable "close_gui" accessed at ....minetest/games/mineclone2/mods/ITEMS/mcl_books/init.lua:447 > ``` One fix coming up @kneekoo.
👍 2
Sign in to join this conversation.
Reviewers
No reviewers
cora
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-Minecraft feature

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#2603
No description provided.
Delete Branch "bookshelf_inventory"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?