Clearmobs: clear empty nametagged as well as nil (#2429) #2433

cora · 2022-07-15T04:44:20+02:00

cora commented

2022-07-15 04:44:20 +02:00

This PR fixes #2429

For some reason horses get an empty string as nametag.

Testing

In survival:

/findbiome Plains
wait for horses to spawn
/clearmobs
without this patch horses do not get removed
with this patch they do (unless tamed)

Note that in creative they are all tamed and if you spawn them with an egg they're tamed too so this needs to be done via natural spawning in survival.

This PR fixes #2429 For some reason horses get an empty string as nametag. #### Testing *In survival:* * /findbiome Plains * wait for horses to spawn * /clearmobs * without this patch horses do not get removed * with this patch they do (unless tamed) Note that in creative they are all tamed and if you spawn them with an egg they're tamed too so this needs to be done via natural spawning in survival.

cora added 1 commit 2022-07-15 04:44:24 +02:00

aab3180269 clear empty nametag as well as nil

TheRandomLegoBrick commented

2022-07-15 06:17:55 +02:00

It works :)

MysticTempest commented

2022-07-15 06:43:18 +02:00

Yes, works.

Though, as an FYI; you need to hold sneak while using mob spawn eggs in order for them to be un-tamed.

Description:
https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/ENTITIES/mcl_mobs/api.lua#L4270

And, actual code for this:
https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/ENTITIES/mcl_mobs/api.lua#L4321-L4326

Yes, works. Though, as an FYI; you need to hold sneak while using mob spawn eggs in order for them to be un-tamed. Description: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/ENTITIES/mcl_mobs/api.lua#L4270 And, actual code for this: https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/ENTITIES/mcl_mobs/api.lua#L4321-L4326

👍 2

MysticTempest approved these changes 2022-07-15 06:43:31 +02:00

cora merged commit 14cba8197e into master

2022-07-15 13:54:04 +02:00

cora referenced this issue from a commit

2022-07-15 13:54:05 +02:00

Merge pull request 'Clearmobs: clear empty nametagged as well as nil (#2429)' (#2433) from fix_clearmobs_horses into master

cora deleted branch fix_clearmobs_horses

2022-07-15 13:54:16 +02:00

Sign in to join this conversation.

No reviewers