Replace all melon/pumpkin stems in woodland_cabins with unconnected variants. #2409

MysticTempest · 2022-07-10T02:51:18+02:00

MysticTempest commented

2022-07-10 02:51:18 +02:00

Per the discussion in the following issue: MineClone2/MineClone2#2396

This PR replaces all melon/pumpkin stems placed by "mcl_structures" in woodland_cabins; with their mature, unconnected variants. This will partially fix their broken placement in the aforementioned issue.

Testing:
You may want to comment out the following line to ensure only the mansion spawns when testing.
https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/MAPGEN/mcl_structures/woodland_mansion.lua#L17

		--modpath.."/schematics/mcl_structures_woodland_cabin.mts",

Now, on a new, test world in creative mode.
Run the following commands.

grantme all
spawnstruct woodland_cabin

This should generate a new mansion at your location. Fly in, & verify all the stems are unconnected variants.
Then dig the pumpkins & melons, but leave the stems intact. Wait a couple minutes & verify that you see the growith of a new melon/pumpkin.
And, that the stem updated, and auto-connected to the new gourd.

Per the discussion in the following issue: https://git.minetest.land/MineClone2/MineClone2/issues/2396 This PR replaces all melon/pumpkin stems placed by "mcl_structures" in woodland_cabins; with their mature, unconnected variants. This will partially fix their broken placement in the aforementioned issue. **Testing:** You may want to comment out the following line to ensure only the mansion spawns when testing. https://git.minetest.land/MineClone2/MineClone2/src/branch/master/mods/MAPGEN/mcl_structures/woodland_mansion.lua#L17 ``` --modpath.."/schematics/mcl_structures_woodland_cabin.mts", ``` Now, on a new, test world in creative mode. Run the following commands. ``` grantme all spawnstruct woodland_cabin ``` This should generate a new mansion at your location. Fly in, & verify all the stems are unconnected variants. Then dig the pumpkins & melons, but leave the stems intact. Wait a couple minutes & verify that you see the growith of a new melon/pumpkin. And, that the stem updated, and auto-connected to the new gourd.

MysticTempest added 1 commit 2022-07-10 02:51:24 +02:00

484ad2b630 Replace all melon/pumpkin stems in woodland_cabins with unconnected variants.

cora approved these changes 2022-07-10 11:39:38 +02:00

cora left a comment

works

cora merged commit c900c04194 into master

2022-07-10 11:41:14 +02:00

cora referenced this issue from a commit

2022-07-10 11:41:15 +02:00

Merge pull request 'Replace all melon/pumpkin stems in woodland_cabins with unconnected variants.' (#2409) from melonpumpkin_stem_patch into master

cora deleted branch melonpumpkin_stem_patch

2022-07-10 11:41:19 +02:00