VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
62
134
Fork 181
Code Issues 954 Pull Requests 91 Projects 4 Releases Wiki Activity

Add sus stews via subtree #2288

Merged
cora merged 15 commits from sus_stew into master 2022-06-08 22:19:47 +02:00
Conversation 5 Commits 15 Files Changed 6 +369
cora commented 2022-06-08 11:15:39 +02:00
Contributor
Copy Link

https://git.minetest.land/chmodsayshello/mcl_sus_stew is actively maintained (and used in mcl5). This includes it as a git subtree so future updates can be pulled in easily.

https://git.minetest.land/chmodsayshello/mcl_sus_stew is actively maintained (and used in mcl5). This includes it as a git subtree so future updates can be pulled in easily.
cora added 15 commits 2022-06-08 11:15:43 +02:00
d1149ee49a Add 'mods/ITEMS/mcl_sus_stew/' from commit '6048efbc988390321952e9ba1da4f6342df59cbf' 
git-subtree-dir: mods/ITEMS/mcl_sus_stew
git-subtree-mainline: 8d9131eda3
git-subtree-split: 6048efbc98
MysticTempest commented 2022-06-08 14:53:43 +02:00
Member
Copy Link

Tested, and it works.

Looks like we can also add an allium variant later; since we already have fire resistance & well, alliums.

https://minecraft.fandom.com/wiki/Flower#Suspicious_stew

Tested, and it works. Looks like we can also add an allium variant later; since we already have fire resistance & well, alliums. https://minecraft.fandom.com/wiki/Flower#Suspicious_stew
MysticTempest approved these changes 2022-06-08 14:53:56 +02:00
chmodsayshello reviewed 2022-06-08 17:48:02 +02:00
mods/ITEMS/mcl_sus_stew/LICENSE
@ -0,0 +1,232 @@
GNU GENERAL PUBLIC LICENSE
chmodsayshello commented 2022-06-08 17:48:02 +02:00
Member
Copy Link

I licsensed mcl_sus_stew under GPLv3, since it's the same licsense MineClone2 uses, you can delte the licsense file in this mod

I licsensed mcl_sus_stew under GPLv3, since it's the same licsense MineClone2 uses, you can delte the licsense file in this mod
cora commented 2022-06-08 17:57:15 +02:00
Author
Contributor
Copy Link

As we're subtreeing it from the repo I'd leave these in otherwise they will probably conflict on update

As we're subtreeing it from the repo I'd leave these in otherwise they will probably conflict on update
chmodsayshello reviewed 2022-06-08 17:49:26 +02:00
mods/ITEMS/mcl_sus_stew/Note
@ -0,0 +1 @@
The texture for the suspicious stew is from the Minecraft resourcepack "Pixel Perfection Legacy" (https://www.curseforge.com/minecraft/texture-packs/pixel-perfection-legacy), wich is licensed under CC BY-SA 4.0 (Creative Commons license)!
chmodsayshello commented 2022-06-08 17:49:26 +02:00
Member
Copy Link

Mineclone2 already uses pretty much all textures from PixelPerfection and PixelPerfection Legacy, so I guess that note is pointless here

Mineclone2 already uses pretty much all textures from PixelPerfection and PixelPerfection Legacy, so I guess that note is pointless here
chmodsayshello reviewed 2022-06-08 17:50:57 +02:00
mods/ITEMS/mcl_sus_stew/mod.conf
@ -0,0 +1,3 @@
name = mcl_sus_stew
author = chmodsayshello
chmodsayshello commented 2022-06-08 17:50:57 +02:00
Member
Copy Link

since the mod doesn't have much code, and you changed a lot for the better, feel free to add your name here as well

since the mod doesn't have much code, and you changed a lot for the better, feel free to add your name here as well
chmodsayshello commented 2022-06-08 17:55:25 +02:00
Member
Copy Link

https://git.minetest.land/chmodsayshello/mcl_sus_stew is actively maintained (and used in mcl5). This includes it as a git subtree so future updates can be pulled in easily.

In mcl5, they told me that adding an extra mod for such a low priority feature is not worth it, and to implement it in mcl_mushrooms, so it won't be 100% compatible

> https://git.minetest.land/chmodsayshello/mcl_sus_stew is actively maintained (and used in mcl5). This includes it as a git subtree so future updates can be pulled in easily. In mcl5, they told me that adding an extra mod for such a low priority feature is not worth it, and to implement it in `mcl_mushrooms`, so it won't be 100% compatible
chmodsayshello added the
items
Minecraft >= 1.13
mcl5
 labels 2022-06-08 17:56:01 +02:00
chmodsayshello commented 2022-06-08 17:56:51 +02:00
Member
Copy Link

Why do we have two Mineclone5 labels? I added both because I don't know which one is the "correct" one for this PR

Why do we have two Mineclone5 labels? I added both because I don't know which one is the "correct" one for this PR
cora commented 2022-06-08 18:50:05 +02:00
Author
Contributor
Copy Link

Oh lol the "mineclone5" one is from back when mcl5 was a mcl2 branch I think

Oh lol the "mineclone5" one is from back when mcl5 was a mcl2 branch I think
cora commented 2022-06-08 18:51:37 +02:00
Author
Contributor
Copy Link

I added the mcla and mcl5 one for if someone from those projects is looking for stuff they could steal ... For PRs/issues that are probably relevant for them

I added the mcla and mcl5 one for if someone from those projects is looking for stuff they could steal ... For PRs/issues that are probably relevant for them
cora merged commit ad55ba435a into master 2022-06-08 22:19:47 +02:00
cora deleted branch sus_stew 2022-06-08 22:19:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MysticTempest
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#2288
No description provided.
Delete Branch "sus_stew"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?