Potion Fixes: #2191

MysticTempest · 2022-05-09T12:13:22+02:00

MysticTempest commented

2022-05-09 12:13:22 +02:00

This PR ensures all potion icons disappear after their effect is gone.
And, stops the Breath bar from flashing when water_breathing is in effect.

It replaces this PR: MineClone2/MineClone2#1956
And, will fix: MineClone2/MineClone2#1744

Potion Icon Testing:
Start a new world, in creative mode to easily acquire the potions.
I recommend the "lingering" versions; as they have a short timer for their effects.
But, this bug applied to all potions. So, feel free to verify with the longer timers.

Potions that were broken:

Fire Resistance Potion
Water Breathing Potion
Invsibility Potion
Leaping Potion
Night Vision Potion

(slow & swift are handled together in the code)
6. Swiftness Potion
7. Slowness Potion

Before this PR, the icons won't disappear after the timer is up. With this PR, they disappear automatically.

Water Breathing Testing:
Reuse the same world as above, and test the effects of the water breathing potion underwater.
The breath bar should no longer be flashing constantly with this PR.

This PR ensures all potion icons disappear after their effect is gone. And, stops the Breath bar from flashing when water_breathing is in effect. It replaces this PR: https://git.minetest.land/MineClone2/MineClone2/pulls/1956 And, will fix: https://git.minetest.land/MineClone2/MineClone2/issues/1744 --- **Potion Icon Testing:** Start a new world, in creative mode to easily acquire the potions. I recommend the "lingering" versions; as they have a short timer for their effects. But, this bug applied to all potions. So, feel free to verify with the longer timers. **Potions that were broken:** 1. Fire Resistance Potion 2. Water Breathing Potion 3. Invsibility Potion 4. Leaping Potion 5. Night Vision Potion (slow & swift are handled together in the code) 6. Swiftness Potion 7. Slowness Potion Before this PR, the icons won't disappear after the timer is up. With this PR, they disappear automatically. --- **Water Breathing Testing:** Reuse the same world as above, and test the effects of the water breathing potion underwater. The breath bar should no longer be flashing constantly with this PR.

👍 3

MysticTempest force-pushed Fix_waterbreathing_and_potion_icons from 7aa7451a17 to 44b1d583a7

2022-05-09 12:20:16 +02:00

Compare

cora approved these changes 2022-05-09 12:23:10 +02:00

cora left a comment

Tested all mentioned potions: Potions still work, after timeout: Icon disappears correctly, effect still stops, water breathing bar does not pop up during water breathing anymore.

good work <3

Tested all mentioned potions: Potions still work, after timeout: Icon disappears correctly, effect still stops, water breathing bar does not pop up during water breathing anymore. good work <3

❤️ 1

cora merged commit 7c263c6a18 into master

2022-05-09 12:25:52 +02:00

cora referenced this issue from a commit

2022-05-09 12:25:53 +02:00

Merge pull request 'Potion Fixes:' (#2191) from Fix_waterbreathing_and_potion_icons into master

cora deleted branch Fix_waterbreathing_and_potion_icons

2022-05-09 12:25:57 +02:00

MysticTempest referenced this pull request

2022-05-09 12:54:00 +02:00

Fix water breathing problem #1956

MysticTempest referenced this pull request

2022-05-09 12:54:33 +02:00

potions HUD icons arent removed then the potion status is removed #1744

kneekoo commented

2022-05-09 15:26:15 +02:00

I haven't checked this yet, but does this also cover the effects of golden apples?

cora commented

2022-05-09 16:03:03 +02:00

I haven't checked this yet, but does this also cover the effects of golden apples?

I think it does since that uses the same code as potions afaik

> I haven't checked this yet, but does this also cover the effects of golden apples? I think it does since that uses the same code as potions afaik

👍 1

MysticTempest commented

2022-05-09 16:03:21 +02:00

I haven't checked this yet, but does this also cover the effects of golden apples?

Yes, the golden apples just call upon the mcl_potions functions for their effects. So, the fix applies to them as well.

Edit: Hehe, Cora you beat me to the reply by seconds.

> I haven't checked this yet, but does this also cover the effects of golden apples? Yes, the golden apples just call upon the mcl_potions functions for their effects. So, the fix applies to them as well. Edit: Hehe, Cora you beat me to the reply by seconds.

Sign in to join this conversation.

No reviewers