Add "cobble" group. #2174

kabou · 2022-05-04T17:04:43+02:00

kabou commented

2022-05-04 17:04:43 +02:00

This PR implements the "cobble" group. It currently comprises only of "mcl_core:cobble", but as we are about to add deepslate and blackstone mods, there are nodes in those that are also eligible to cobble group membership.

The benfit of the cobble group is that crafting recipes do not have to be repeated unnecessarily for all the different types of cobble. Instead recipes can specify "group:cobble".

The cobble group can also be used to specify repair material for worn tools. The anvil code does not need adaptation for it as it already supports "group:wood".

Wiki reference: https://minecraft.fandom.com/wiki/Tiers#Tiers

Please review timely, so that this can be merged and the deepslate and blackstone mods can be adapted to make use of it.

Add cobble group to GROUPS.md, to be used in crafting recipes.
Add cobblestone to the cobble group.
Update crafting recipes for stone tools (pick, shovel, axe, sword and
hoe), furnace and brewing stand to use any cobble group stone.
Update crafting recipes of dispensers, droppers, observers, pistons
and walllevers to use any cobble group stone.
Update repair material for stone tools (pick, shovel, axe, sword and
hoe) to use any cobble group stone.

This PR implements the "cobble" group. It currently comprises only of "mcl_core:cobble", but as we are about to add deepslate and blackstone mods, there are nodes in those that are also eligible to cobble group membership. The benfit of the cobble group is that crafting recipes do not have to be repeated unnecessarily for all the different types of cobble. Instead recipes can specify "group:cobble". The cobble group can also be used to specify repair material for worn tools. The anvil code does not need adaptation for it as it already supports "group:wood". Wiki reference: https://minecraft.fandom.com/wiki/Tiers#Tiers Please review timely, so that this can be merged and the deepslate and blackstone mods can be adapted to make use of it. * Add `cobble` group to GROUPS.md, to be used in crafting recipes. * Add cobblestone to the `cobble` group. * Update crafting recipes for stone tools (pick, shovel, axe, sword and hoe), furnace and brewing stand to use any cobble group stone. ~~Update crafting recipes of dispensers, droppers, observers, pistons and walllevers to use any cobble group stone.~~ * Update repair material for stone tools (pick, shovel, axe, sword and hoe) to use any cobble group stone.

👍 3

kabou added 3 commits 2022-05-04 17:04:48 +02:00

b0ae135b3c Add `cobble` group.

* Add `cobble` group to GROUPS.md, to be used in crafting recipes.

9edb40b5c5 Add cobblestone to the `cobble` group.

64bb50dfd5 Change some crafting recipes to use group:cobble.

* Update crafting recipes for stone tools (pick, shovel, axe, sword and
hoe), furnace and brewing stand to use any cobble group stone.

kabou commented

2022-05-04 17:10:15 +02:00

To be used in #2141 and #2142

kabou referenced this pull request

2022-05-04 17:14:52 +02:00

Add deepslate, copper and raw_ores by NO11 #2141

MysticTempest commented

2022-05-04 18:08:03 +02:00

The brewing stand*, furnace, and tools are okay. But, according to the wiki; redstone nodes only uses cobble.

https://minecraft.fandom.com/wiki/Cobbled_Deepslate#Usage

Cobbled deepslate cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904.

https://minecraft.fandom.com/wiki/Blackstone#Usage

Blackstone cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904.

MC-177904: https://bugs.mojang.com/browse/MC-177904

*Brewing stand has some conflicting info. But, I think that's based on Java vs Bedrock recipes.

The brewing stand*, furnace, and tools are okay. But, according to the wiki; redstone nodes only uses cobble. https://minecraft.fandom.com/wiki/Cobbled_Deepslate#Usage >Cobbled deepslate cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904. https://minecraft.fandom.com/wiki/Blackstone#Usage >Blackstone cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904. MC-177904: https://bugs.mojang.com/browse/MC-177904 *Brewing stand has some conflicting info. But, I think that's based on Java vs Bedrock recipes.

👍 1

kabou commented

2022-05-04 18:33:30 +02:00

The brewing stand*, furnace, and tools are okay. But, according to the wiki; redstone nodes only uses cobble.

https://minecraft.fandom.com/wiki/Cobbled_Deepslate#Usage

Cobbled deepslate cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904.

https://minecraft.fandom.com/wiki/Blackstone#Usage

Blackstone cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904.

MC-177904: https://bugs.mojang.com/browse/MC-177904

Oh thanks. Yes, I had my doubts, but it wasn't immediately obvious from my cursory reading of the wiki. Anyway, I put the redstone bits in a separate commit, so that it would be easy to revert in case it was wrong.

*Brewing stand has some conflicting info. But, I think that's based on Java vs Bedrock recipes.

What I found in wiki positively states that it can be crafted with other cobbles.

https://minecraft.fandom.com/wiki/Brewing_Stand#Crafting

That mojang bug that you linked states the opposite though.

> The brewing stand*, furnace, and tools are okay. But, according to the wiki; redstone nodes only uses cobble. > > https://minecraft.fandom.com/wiki/Cobbled_Deepslate#Usage > >Cobbled deepslate cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904. > > https://minecraft.fandom.com/wiki/Blackstone#Usage > >Blackstone cannot be used to craft dispensers, droppers, pistons, or other blocks that use cobblestone in their recipes. This is intended per MC-177904. > > MC-177904: https://bugs.mojang.com/browse/MC-177904 Oh thanks. Yes, I had my doubts, but it wasn't immediately obvious from my cursory reading of the wiki. Anyway, I put the redstone bits in a separate commit, so that it would be easy to revert in case it was wrong. > *Brewing stand has some conflicting info. But, I think that's based on Java vs Bedrock recipes. What I found in wiki positively states that it can be crafted with other cobbles. https://minecraft.fandom.com/wiki/Brewing_Stand#Crafting That mojang bug that you linked states the opposite though.

kneekoo commented

2022-05-04 18:38:20 +02:00

Has anyone tested crafting the stand in JE? I can do it if necessary.

MysticTempest commented

2022-05-04 18:46:57 +02:00

*Brewing stand has some conflicting info. But, I think that's based on Java vs Bedrock recipes.

What I found in wiki positively states that it can be crafted with other cobbles.

https://minecraft.fandom.com/wiki/Brewing_Stand#Crafting

That mojang bug that you linked states the opposite though.

Yea, hence the footnote. I'm not too sure about that.

Has anyone tested crafting the stand in JE? I can do it if necessary.

No, I haven't had a chance. That'd be helpful if you could!

> > *Brewing stand has some conflicting info. But, I think that's based on Java vs Bedrock recipes. > > What I found in wiki positively states that it can be crafted with other cobbles. > > https://minecraft.fandom.com/wiki/Brewing_Stand#Crafting > > That mojang bug that you linked states the opposite though. Yea, hence the footnote. I'm not too sure about that. > Has anyone tested crafting the stand in JE? I can do it if necessary. No, I haven't had a chance. That'd be helpful if you could!

kneekoo commented

2022-05-04 19:54:37 +02:00

I just tried in Java Edition and you can craft the brewing stand with all of these: Cobblestone, Blackstone or Cobbled Deepslate.

👍 1

MysticTempest commented

2022-05-04 20:45:43 +02:00

I just tried in Java Edition and you can craft the brewing stand with all of these: Cobblestone, Blackstone or Cobbled Deepslate.

Thanks for checking!

> I just tried in Java Edition and you can craft the brewing stand with all of these: Cobblestone, Blackstone or Cobbled Deepslate. Thanks for checking!

kabou commented

2022-05-04 21:11:18 +02:00

Allright, shall I revert the redstone related crafting changes then?

kabou commented

2022-05-04 22:12:21 +02:00

Reverted the dispensers, droppers, observers, pistons and walllevers crafting recipes to their original versions.

MysticTempest commented

2022-05-04 22:40:01 +02:00

Allright, shall I revert the redstone related crafting changes then?

Reverted the dispensers, droppers, observers, pistons and walllevers crafting recipes to their original versions.

Thanks. I'm not seeing any typos, and I tested in-game; looks good.

> Allright, shall I revert the redstone related crafting changes then? > > Reverted the dispensers, droppers, observers, pistons and walllevers crafting recipes to their original versions. Thanks. I'm not seeing any typos, and I tested in-game; looks good.

MysticTempest approved these changes 2022-05-04 22:40:18 +02:00

kabou referenced this pull request

2022-05-04 23:34:53 +02:00

Add blackstone by debian044 #2142

kabou referenced this pull request

2022-05-04 23:39:15 +02:00

Add deepslate, copper and raw_ores by NO11 #2141

cora force-pushed cobble_group from b4b8280570 to f1a494ea62

2022-05-05 01:01:45 +02:00

Compare

cora approved these changes 2022-05-05 01:04:47 +02:00

cora left a comment