Add setting to disable ores generation #1174

Merged
kay27 merged 3 commits from :master into master 2021-02-25 11:04:14 +01:00
Member

Fix #874 by adding a setting to disable natural mineral generation.

Fix #874 by adding a setting to disable natural mineral generation.
AFCMS added 2 commits 2021-02-22 13:38:26 +01:00
AFCMS changed title from Add to Add setting to disable ores generation 2021-02-22 13:38:41 +01:00
Contributor

@AFCMS there are also some settings changed - can you please explain briefly what you do?

@AFCMS there are also some settings changed - can you please explain briefly what you do?
AFCMS added 1 commit 2021-02-22 20:12:37 +01:00
Author
Member

@AFCMS there are also some settings changed - can you please explain briefly what you do?

Done!

> @AFCMS there are also some settings changed - can you please explain briefly what you do? Done!
Author
Member

Ready for merge.

Ready for merge.
Contributor

I see it's ready.
Please forgive me my stupidity but I can't find the description e. g. what you do by this:

-		y_min          = mcl_worlds.layer_to_y(30),
+		y_min          = mcl_worlds.layer_to_y(31),

etc...

That's why I need to check it myself which might take a long, or you may briefly describe your ideas right here.

Because what I see - this isn't just "Add setting to disable ores generation".

I see it's ready. Please forgive me my stupidity but I can't find the description e. g. what you do by this: ```diff - y_min = mcl_worlds.layer_to_y(30), + y_min = mcl_worlds.layer_to_y(31), ``` etc... That's why I need to check it myself which might take a long, or you may briefly describe your ideas right here. Because what I see - this isn't just "Add setting to disable ores generation".
Author
Member

I see it's ready.
Please forgive me my stupidity but I can't find the description e. g. what you do by this:

-		y_min          = mcl_worlds.layer_to_y(30),
+		y_min          = mcl_worlds.layer_to_y(31),

etc...

That's why I need to check it myself which might take a long, or you may briefly describe your ideas right here.

Because what I see - this isn't just "Add setting to disable ores generation".

Strange. I didn't work on layer.
I will investigate.

> I see it's ready. > Please forgive me my stupidity but I can't find the description e. g. what you do by this: > ```diff > - y_min = mcl_worlds.layer_to_y(30), > + y_min = mcl_worlds.layer_to_y(31), > ``` > etc... > > That's why I need to check it myself which might take a long, or you may briefly describe your ideas right here. > > Because what I see - this isn't just "Add setting to disable ores generation". Strange. I didn't work on layer. I will investigate.
Author
Member

Ok,
It's just a graphical problem.
I selected all the ores code and press "tab".
There is NO changes in values.
It is just a mess in the viewer of mesehub.
See the image, many ore registration are shifted.

Ok, It's just a graphical problem. I selected all the ores code and press "tab". There is NO changes in values. It is just a mess in the viewer of mesehub. See the image, many ore registration are shifted.
kay27 merged commit e23ad6cabf into master 2021-02-25 11:04:14 +01:00
Contributor

Thanks so much for explaining!

Thanks so much for explaining!
Author
Member

@kay27 Do you know if it is possible to update my forked repo from the web interface? I haven't see any button like in GitHub.

@kay27 Do you know if it is possible to update my forked repo from the web interface? I haven't see any button like in GitHub.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#1174
No description provided.